delta/curl.git, branch bagder/ftp-sock-accepted

ftp: convert 'sock_accepted' to a plain boolean

2020-02-14T23:00:45+00:00

This was an array indexed with sockindex but it was only ever used for
the secondary socket.

TODO: Paged searches on LDAP server

2020-02-14T22:05:38+00:00

Closes #4452

TODO: CURLOPT_SSL_CTX_FUNCTION for LDAPS

2020-02-14T22:03:21+00:00

Closes #4108

azure: disable brotli on the macos debug-builds

2020-02-14T15:16:09+00:00

Because of:

brotli/decode.h:204:33: error: variable length array used [-Werror,-Wvla]
    const uint8_t encoded_buffer[BROTLI_ARRAY_PARAM(encoded_size)],

Closes #4925

tool_home: Fix the copyright year being out of date

2020-02-13T00:40:08+00:00

Follow up to 9dc350b6.

tool_homedir: Change GetEnv() to use libcurl's curl_getenv()

2020-02-12T23:37:31+00:00

- Deduplicate GetEnv() code.

- On Windows change ultimate call to use Windows API
  GetEnvironmentVariable() instead of C runtime getenv().

Prior to this change both libcurl and the tool had their own GetEnv
which over time diverged. Now the tool's GetEnv is a wrapper around
curl_getenv (libcurl API function which is itself a wrapper around
libcurl's GetEnv).

Furthermore this change fixes a bug in that Windows API
GetEnvironmentVariable() is called instead of C runtime getenv() to get
the environment variable since some changes aren't always visible to the
latter.

Reported-by: Christoph M. Becker

Fixes https://github.com/curl/curl/issues/4774
Closes https://github.com/curl/curl/pull/4863

strerror.h: Copyright year out of date

2020-02-12T22:07:21+00:00

Follow-up to 1c4fa67e8a8fcf6

strerror: Increase STRERROR_LEN 128 -> 256

2020-02-12T21:58:56+00:00

STRERROR_LEN is the constant used throughout the library to set the size
of the buffer on the stack that the curl strerror functions write to.

Prior to this change some extended length Windows error messages could
be truncated.

Closes https://github.com/curl/curl/pull/4920

multi: fix outdated comment

2020-02-12T21:55:33+00:00

- Do not say that conn->data is "cleared" by multi_done().

If the connection is in use then multi_done assigns another easy handle
still using the connection to conn->data, therefore in that case it is
not cleared.

Closes https://github.com/curl/curl/pull/4901

easy: remove dead code

2020-02-12T21:54:51+00:00

multi is already assigned to data->multi by curl_multi_add_handle.

Closes https://github.com/curl/curl/pull/4900