From 7bdbe3db9f65afabf1a7536eb286fa4afa11b02b Mon Sep 17 00:00:00 2001 From: Raymond Hettinger Date: Sat, 6 Sep 2003 04:25:54 +0000 Subject: SF bug #801342: Bug (documentation or real, your choice) in random.sample. random.sample() uses one of two algorithms depending on the ratio of the sample size to the population size. One of the algorithms accepted any iterable population argument so long as it defined __len__(). The other had a stronger requirement that the population argument be indexable. While it met the documentation specifications which insisted that the population argument be a sequence, it made random.sample() less usable with sets. So, the second algorithm was modified to coerce non-indexable iterables and dictionaries into a tuple before proceeding. --- Lib/test/test_random.py | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'Lib/test/test_random.py') diff --git a/Lib/test/test_random.py b/Lib/test/test_random.py index c9103e8f87..fbd418457a 100644 --- a/Lib/test/test_random.py +++ b/Lib/test/test_random.py @@ -86,6 +86,16 @@ class TestBasicOps(unittest.TestCase): else: self.fail() + def test_sample_inputs(self): + # SF bug #801342 -- population can be any iterable defining __len__() + from sets import Set + self.gen.sample(Set(range(20)), 2) + self.gen.sample(range(20), 2) + self.gen.sample(xrange(20), 2) + self.gen.sample(dict.fromkeys('abcdefghijklmnopqrst'), 2) + self.gen.sample(str('abcdefghijklmnopqrst'), 2) + self.gen.sample(tuple('abcdefghijklmnopqrst'), 2) + def test_gauss(self): # Ensure that the seed() method initializes all the hidden state. In # particular, through 2.2.1 it failed to reset a piece of state used -- cgit v1.2.1