From d2aa2fdc6f81efaa4b7e3aee7544881260705e77 Mon Sep 17 00:00:00 2001 From: Antoine Pitrou Date: Tue, 19 May 2015 20:52:27 +0200 Subject: Issue #23985: Fix a possible buffer overrun when deleting a slice from the front of a bytearray and then appending some other bytes data. Patch by Martin Panter. --- Lib/test/test_bytes.py | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) (limited to 'Lib/test/test_bytes.py') diff --git a/Lib/test/test_bytes.py b/Lib/test/test_bytes.py index e15807e516..6b58e74dd8 100644 --- a/Lib/test/test_bytes.py +++ b/Lib/test/test_bytes.py @@ -947,6 +947,22 @@ class ByteArrayTest(BaseBytesTest, unittest.TestCase): b.extend(range(100, 110)) self.assertEqual(list(b), list(range(10, 110))) + def test_fifo_overrun(self): + # Test for issue #23985, a buffer overrun when implementing a FIFO + # Build Python in pydebug mode for best results. + b = bytearray(10) + b.pop() # Defeat expanding buffer off-by-one quirk + del b[:1] # Advance start pointer without reallocating + b += bytes(2) # Append exactly the number of deleted bytes + del b # Free memory buffer, allowing pydebug verification + + def test_del_expand(self): + # Reducing the size should not expand the buffer (issue #23985) + b = bytearray(10) + size = sys.getsizeof(b) + del b[:1] + self.assertLessEqual(sys.getsizeof(b), size) + def test_extended_set_del_slice(self): indices = (0, None, 1, 3, 19, 300, 1<<333, -1, -2, -31, -300) for start in indices: -- cgit v1.2.1