From 619f98045d73859688e5cfdb946d183e6d493a64 Mon Sep 17 00:00:00 2001 From: Manan Kumar Garg <62146744+MananKGarg@users.noreply.github.com> Date: Mon, 5 Oct 2020 02:58:43 +0530 Subject: Typo fix (GH-22496) Multiple typo fixes in code comments Automerge-Triggered-By: @Mariatta --- setup.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'setup.py') diff --git a/setup.py b/setup.py index 04b1358bc9..476f8c4149 100644 --- a/setup.py +++ b/setup.py @@ -1881,9 +1881,9 @@ class PyBuildExt(build_ext): # you want to build and link with a framework build of Tcl and Tk # that is not in /Library/Frameworks, say, in your private # $HOME/Library/Frameworks directory or elsewhere. It turns - # out to be difficult to make that work automtically here + # out to be difficult to make that work automatically here # without bringing into play more tools and magic. That case - # can be hamdled using a recipe with the right arguments + # can be handled using a recipe with the right arguments # to detect_tkinter_explicitly(). # # Note also that the fallback case here is to try to use the @@ -1891,7 +1891,7 @@ class PyBuildExt(build_ext): # be forewarned that they are deprecated by Apple and typically # out-of-date and buggy; their use should be avoided if at # all possible by installing a newer version of Tcl and Tk in - # /Library/Frameworks before bwfore building Python without + # /Library/Frameworks before building Python without # an explicit SDK or by configuring build arguments explicitly. from os.path import join, exists @@ -1908,7 +1908,7 @@ class PyBuildExt(build_ext): else: # Use case #1: no explicit SDK selected. # Search the local system-wide /Library/Frameworks, - # not the one in the default SDK, othewise fall back to + # not the one in the default SDK, otherwise fall back to # /System/Library/Frameworks whose header files may be in # the default SDK or, on older systems, actually installed. framework_dirs = [ @@ -1924,7 +1924,7 @@ class PyBuildExt(build_ext): if not exists(join(F, fw + '.framework')): break else: - # ok, F is now directory with both frameworks. Continure + # ok, F is now directory with both frameworks. Continue # building break else: -- cgit v1.2.1 From 7992579cd27f14f472acc37aca537eec55f681ef Mon Sep 17 00:00:00 2001 From: Kyle Evans Date: Tue, 13 Oct 2020 15:04:44 -0500 Subject: bpo-40422: Move _Py_closerange to fileutils.c (GH-22680) This API is relatively lightweight and organizationally, given that it's used by multiple modules, it makes sense to move it to fileutils. Requires making sure that _posixsubprocess is compiled with the appropriate Py_BUIILD_CORE_BUILTIN macro. --- setup.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'setup.py') diff --git a/setup.py b/setup.py index 476f8c4149..d3fd7bca64 100644 --- a/setup.py +++ b/setup.py @@ -950,7 +950,8 @@ class PyBuildExt(build_ext): self.add(Extension('_csv', ['_csv.c'])) # POSIX subprocess module helper. - self.add(Extension('_posixsubprocess', ['_posixsubprocess.c'])) + self.add(Extension('_posixsubprocess', ['_posixsubprocess.c'], + extra_compile_args=['-DPy_BUILD_CORE_MODULE'])) def detect_test_extensions(self): # Python C API test module -- cgit v1.2.1