From 172bb39452ae8b3ccdf5d1f23ead46f44200cd49 Mon Sep 17 00:00:00 2001 From: Serhiy Storchaka Date: Sat, 30 Mar 2019 08:33:02 +0200 Subject: bpo-22831: Use "with" to avoid possible fd leaks in tools (part 2). (GH-10927) --- Tools/scripts/combinerefs.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'Tools/scripts/combinerefs.py') diff --git a/Tools/scripts/combinerefs.py b/Tools/scripts/combinerefs.py index 7ca95267c9..49ccca7390 100755 --- a/Tools/scripts/combinerefs.py +++ b/Tools/scripts/combinerefs.py @@ -85,9 +85,7 @@ def read(fileiter, pat, whilematch): else: break -def combine(fname): - f = open(fname) - +def combinefile(f): fi = iter(f) for line in read(fi, re.compile(r'^Remaining objects:$'), False): @@ -121,8 +119,11 @@ def combine(fname): print('[%s->%s]' % (addr2rc[addr], rc), end=' ') print(guts, addr2guts[addr]) - f.close() print("%d objects before, %d after" % (before, after)) +def combine(fname): + with open(fname) as f: + combinefile(f) + if __name__ == '__main__': combine(sys.argv[1]) -- cgit v1.2.1