From 252033d50effa08046ac34fcc406bc99796ab88b Mon Sep 17 00:00:00 2001 From: Oren Milman Date: Mon, 11 Sep 2017 09:28:39 +0300 Subject: bpo-31411: Prevent raising a SystemError in case warnings.onceregistry is not a dictionary. (#3485) --- Python/_warnings.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'Python/_warnings.c') diff --git a/Python/_warnings.c b/Python/_warnings.c index 5230318788..078bdcb039 100644 --- a/Python/_warnings.c +++ b/Python/_warnings.c @@ -86,6 +86,12 @@ get_once_registry(void) return NULL; return _PyRuntime.warnings.once_registry; } + if (!PyDict_Check(registry)) { + PyErr_SetString(PyExc_TypeError, + "warnings.onceregistry must be a dict"); + Py_DECREF(registry); + return NULL; + } Py_DECREF(_PyRuntime.warnings.once_registry); _PyRuntime.warnings.once_registry = registry; return registry; @@ -437,7 +443,7 @@ warn_explicit(PyObject *category, PyObject *message, Py_RETURN_NONE; if (registry && !PyDict_Check(registry) && (registry != Py_None)) { - PyErr_SetString(PyExc_TypeError, "'registry' must be a dict"); + PyErr_SetString(PyExc_TypeError, "'registry' must be a dict or None"); return NULL; } -- cgit v1.2.1