From a44d353e2b6d947d36ab9d36c1fc84335a0878fe Mon Sep 17 00:00:00 2001 From: Fred Drake Date: Fri, 30 Jun 2000 15:01:00 +0000 Subject: Trent Mick : The common technique for printing out a pointer has been to cast to a long and use the "%lx" printf modifier. This is incorrect on Win64 where casting to a long truncates the pointer. The "%p" formatter should be used instead. The problem as stated by Tim: > Unfortunately, the C committee refused to define what %p conversion "looks > like" -- they explicitly allowed it to be implementation-defined. Older > versions of Microsoft C even stuck a colon in the middle of the address (in > the days of segment+offset addressing)! The result is that the hex value of a pointer will maybe/maybe not have a 0x prepended to it. Notes on the patch: There are two main classes of changes: - in the various repr() functions that print out pointers - debugging printf's in the various thread_*.h files (these are why the patch is large) Closes SourceForge patch #100505. --- Objects/methodobject.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'Objects/methodobject.c') diff --git a/Objects/methodobject.c b/Objects/methodobject.c index 580bb2f25b..ec98de492a 100644 --- a/Objects/methodobject.c +++ b/Objects/methodobject.c @@ -148,9 +148,9 @@ meth_repr(m) sprintf(buf, "", m->m_ml->ml_name); else sprintf(buf, - "", + "", m->m_ml->ml_name, m->m_self->ob_type->tp_name, - (long)m->m_self); + m->m_self); return PyString_FromString(buf); } -- cgit v1.2.1