From 64ffee7ad2655c7de9b3b6548aad0c317877ec49 Mon Sep 17 00:00:00 2001
From: Zackery Spytz <zspytz@gmail.com>
Date: Mon, 29 Oct 2018 10:03:26 -0600
Subject: [2.7] Fix a possible "double decref" in termios.tcgetattr().
 (GH-10194) (GH-10218)

(cherry picked from commit 53835e92d315340444e3dd083b3f69a590b00e07)
---
 Modules/termios.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'Modules')

diff --git a/Modules/termios.c b/Modules/termios.c
index e26e714e0e..4349df6481 100644
--- a/Modules/termios.c
+++ b/Modules/termios.c
@@ -120,11 +120,11 @@ termios_tcgetattr(PyObject *self, PyObject *args)
     PyList_SetItem(v, 3, PyInt_FromLong((long)mode.c_lflag));
     PyList_SetItem(v, 4, PyInt_FromLong((long)ispeed));
     PyList_SetItem(v, 5, PyInt_FromLong((long)ospeed));
-    PyList_SetItem(v, 6, cc);
-    if (PyErr_Occurred()){
+    if (PyErr_Occurred()) {
         Py_DECREF(v);
         goto err;
     }
+    PyList_SetItem(v, 6, cc);
     return v;
   err:
     Py_DECREF(cc);
-- 
cgit v1.2.1