From 0cb96de2699fa032ef1379ebb62a4dfb66ee5fde Mon Sep 17 00:00:00 2001 From: Guido van Rossum Date: Wed, 1 Oct 1997 04:29:29 +0000 Subject: Apply two changes, systematically: (1) Use PyErr_NewException("module.class", NULL, NULL) to create the exception object. (2) Remove all calls to Py_FatalError(); instead, return or ignore the errors -- the import code now checks PyErr_Occurred() after calling a module's init function, so it's no longer a fatal error for the initialization to fail. Also did some small cleanups, e.g. removed unnecessary test for "already initialized" from initfpectl(), and unified initposix()/initnt(). I haven't checked this very thoroughly, so while the changes are pretty trivial -- beware of untested code! --- Modules/sunaudiodev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'Modules/sunaudiodev.c') diff --git a/Modules/sunaudiodev.c b/Modules/sunaudiodev.c index 6155445a61..d0edea6220 100644 --- a/Modules/sunaudiodev.c +++ b/Modules/sunaudiodev.c @@ -508,9 +508,7 @@ initsunaudiodev() m = Py_InitModule("sunaudiodev", sunaudiodev_methods); d = PyModule_GetDict(m); - SunAudioError = PyString_FromString("sunaudiodev.error"); + SunAudioError = PyErr_NewException("sunaudiodev.error", NULL, NULL); if (SunAudioError) PyDict_SetItemString(d, "error", SunAudioError); - if (PyErr_Occurred()) - Py_FatalError("can't initialize sunaudiodev module"); } -- cgit v1.2.1