From 387729e183365a366c48fce7a9abfcaf4ec6ff4e Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Tue, 26 May 2015 00:43:58 +0200 Subject: Issue #23840: tokenize.open() now closes the temporary binary file on error to fix a resource warning. --- Lib/tokenize.py | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) (limited to 'Lib/tokenize.py') diff --git a/Lib/tokenize.py b/Lib/tokenize.py index ed4153cec6..cf18bf9f2d 100644 --- a/Lib/tokenize.py +++ b/Lib/tokenize.py @@ -435,11 +435,15 @@ def open(filename): detect_encoding(). """ buffer = _builtin_open(filename, 'rb') - encoding, lines = detect_encoding(buffer.readline) - buffer.seek(0) - text = TextIOWrapper(buffer, encoding, line_buffering=True) - text.mode = 'r' - return text + try: + encoding, lines = detect_encoding(buffer.readline) + buffer.seek(0) + text = TextIOWrapper(buffer, encoding, line_buffering=True) + text.mode = 'r' + return text + except: + buffer.close() + raise def tokenize(readline): -- cgit v1.2.1