From 76b645124b3aaa34bc664eece43707c01ef1b382 Mon Sep 17 00:00:00 2001 From: Flavian Hautbois Date: Fri, 26 Jul 2019 03:30:33 +0200 Subject: bpo-29446: tkinter 'import *' only imports what it should (GH-14864) Add __all__ to tkinter.__init__ and submodules. Replace 'import *' with explicit imports in some submodules. --- Lib/tkinter/test/test_tkinter/test_misc.py | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'Lib/tkinter/test/test_tkinter/test_misc.py') diff --git a/Lib/tkinter/test/test_tkinter/test_misc.py b/Lib/tkinter/test/test_tkinter/test_misc.py index 1d1a3c29f6..9d5a93ef6f 100644 --- a/Lib/tkinter/test/test_tkinter/test_misc.py +++ b/Lib/tkinter/test/test_tkinter/test_misc.py @@ -7,6 +7,20 @@ support.requires('gui') class MiscTest(AbstractTkTest, unittest.TestCase): + def test_all(self): + self.assertIn("Widget", tkinter.__all__) + # Check that variables from tkinter.constants are also in tkinter.__all__ + self.assertIn("CASCADE", tkinter.__all__) + self.assertIsNotNone(tkinter.CASCADE) + # Check that sys, re, and constants are not in tkinter.__all__ + self.assertNotIn("re", tkinter.__all__) + self.assertNotIn("sys", tkinter.__all__) + self.assertNotIn("constants", tkinter.__all__) + # Check that an underscored functions is not in tkinter.__all__ + self.assertNotIn("_tkerror", tkinter.__all__) + # Check that wantobjects is not in tkinter.__all__ + self.assertNotIn("wantobjects", tkinter.__all__) + def test_repr(self): t = tkinter.Toplevel(self.root, name='top') f = tkinter.Frame(t, name='child') -- cgit v1.2.1