From 0f4f048fa5ff06438a4624bc1dc02aa458a79748 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Charles-Fran=C3=A7ois=20Natali?= Date: Mon, 13 Oct 2014 19:19:26 +0100 Subject: Issue #22435: Fix a file descriptor leak when SocketServer bind fails. --- Lib/test/test_socketserver.py | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'Lib/test') diff --git a/Lib/test/test_socketserver.py b/Lib/test/test_socketserver.py index 0617b30a69..0276f993f9 100644 --- a/Lib/test/test_socketserver.py +++ b/Lib/test/test_socketserver.py @@ -302,6 +302,16 @@ class SocketServerTest(unittest.TestCase): t.join() s.server_close() + def test_tcpserver_bind_leak(self): + # Issue #22435: the server socket wouldn't be closed if bind()/listen() + # failed. + # Create many servers for which bind() will fail, to see if this result + # in FD exhaustion. + for i in range(1024): + with self.assertRaises(OverflowError): + socketserver.TCPServer((HOST, -1), + socketserver.StreamRequestHandler) + def test_main(): if imp.lock_held(): -- cgit v1.2.1