From 5b10b9824780b2181158902067912ee9e7b04657 Mon Sep 17 00:00:00 2001 From: Serhiy Storchaka Date: Tue, 5 Mar 2019 10:06:26 +0200 Subject: bpo-22831: Use "with" to avoid possible fd leaks in tests (part 2). (GH-10929) --- Lib/test/test_zipimport_support.py | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) (limited to 'Lib/test/test_zipimport_support.py') diff --git a/Lib/test/test_zipimport_support.py b/Lib/test/test_zipimport_support.py index 84d526c3db..8856101750 100644 --- a/Lib/test/test_zipimport_support.py +++ b/Lib/test/test_zipimport_support.py @@ -122,15 +122,13 @@ class ZipSupportTests(unittest.TestCase): test_src) zip_name, run_name = make_zip_script(d, 'test_zip', script_name) - z = zipfile.ZipFile(zip_name, 'a') - for mod_name, src in sample_sources.items(): - z.writestr(mod_name + ".py", src) - z.close() + with zipfile.ZipFile(zip_name, 'a') as z: + for mod_name, src in sample_sources.items(): + z.writestr(mod_name + ".py", src) if verbose: - zip_file = zipfile.ZipFile(zip_name, 'r') - print ('Contents of %r:' % zip_name) - zip_file.printdir() - zip_file.close() + with zipfile.ZipFile(zip_name, 'r') as zip_file: + print ('Contents of %r:' % zip_name) + zip_file.printdir() os.remove(script_name) sys.path.insert(0, zip_name) import test_zipped_doctest -- cgit v1.2.1