From 18e95b4176256f100429a806d0455406df98f984 Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Thu, 14 Sep 2017 08:43:04 -0700 Subject: bpo-31234: Join threads in tests (#3572) Call thread.join() on threads to prevent the "dangling threads" warning. --- Lib/test/test_smtplib.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'Lib/test/test_smtplib.py') diff --git a/Lib/test/test_smtplib.py b/Lib/test/test_smtplib.py index 4c9b7d367c..040ad4e059 100644 --- a/Lib/test/test_smtplib.py +++ b/Lib/test/test_smtplib.py @@ -611,7 +611,9 @@ class TooLongLineTests(unittest.TestCase): self.sock.settimeout(15) self.port = support.bind_port(self.sock) servargs = (self.evt, self.respdata, self.sock) - threading.Thread(target=server, args=servargs).start() + thread = threading.Thread(target=server, args=servargs) + thread.start() + self.addCleanup(thread.join) self.evt.wait() self.evt.clear() -- cgit v1.2.1