From 091e95e9004b794280ab35becec2c3e30dd5e96e Mon Sep 17 00:00:00 2001 From: Wolfgang Maier Date: Thu, 5 Apr 2018 17:19:44 +0200 Subject: bpo-33203: Ensure random.choice always raises IndexError on empty sequence (GH-6338) --- Lib/test/test_random.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'Lib/test/test_random.py') diff --git a/Lib/test/test_random.py b/Lib/test/test_random.py index 468c4a467e..eee245df48 100644 --- a/Lib/test/test_random.py +++ b/Lib/test/test_random.py @@ -651,7 +651,10 @@ class MersenneTwister_TestBasicOps(TestBasicOps, unittest.TestCase): # Population range too large (n >= maxsize) self.gen._randbelow(maxsize+1, maxsize = maxsize) self.gen._randbelow(5640, maxsize = maxsize) - + # issue 33203: test that _randbelow raises ValueError on + # n == 0 also in its getrandbits-independent branch. + with self.assertRaises(ValueError): + self.gen._randbelow(0, maxsize=maxsize) # This might be going too far to test a single line, but because of our # noble aim of achieving 100% test coverage we need to write a case in # which the following line in Random._randbelow() gets executed: -- cgit v1.2.1