From 590fe02ebdc2ec11347441ae31e71d2d6cd52ad3 Mon Sep 17 00:00:00 2001 From: Thomas Wouters Date: Tue, 25 Mar 2003 18:50:19 +0000 Subject: CommandTests.testgetoutput(): Make sure we aren't masking any errors raised in tempfile.mkdtemp() by referencing the (then) unbound local 'dir'. --- Lib/test/test_commands.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'Lib/test/test_commands.py') diff --git a/Lib/test/test_commands.py b/Lib/test/test_commands.py index ef87d79240..0f7d15f184 100644 --- a/Lib/test/test_commands.py +++ b/Lib/test/test_commands.py @@ -27,6 +27,7 @@ class CommandTests(unittest.TestCase): # we use mkdtemp in the next line to create an empty directory # under our exclusive control; from that, we can invent a pathname # that we _know_ won't exist. This is guaranteed to fail. + dir = None try: dir = tempfile.mkdtemp() name = os.path.join(dir, "foo") @@ -34,7 +35,8 @@ class CommandTests(unittest.TestCase): status, output = getstatusoutput('cat ' + name) self.assertNotEquals(status, 0) finally: - os.rmdir(dir) + if dir is not None: + os.rmdir(dir) def test_getstatus(self): # This pattern should match 'ls -ld /.' on any posix -- cgit v1.2.1