From 992ec46acc1267729da141f683f2594f00ba9f57 Mon Sep 17 00:00:00 2001 From: Serhiy Storchaka Date: Wed, 14 Oct 2015 19:21:24 +0300 Subject: Issue #25406: Fixed a bug in C implementation of OrderedDict.move_to_end() that caused segmentation fault or hang in iterating after moving several items to the start of ordered dict. --- Lib/test/test_collections.py | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'Lib/test/test_collections.py') diff --git a/Lib/test/test_collections.py b/Lib/test/test_collections.py index 4124f91e15..3ed3abdf2f 100644 --- a/Lib/test/test_collections.py +++ b/Lib/test/test_collections.py @@ -1995,6 +1995,20 @@ class OrderedDictTests: with self.assertRaises(KeyError): od.move_to_end('x', 0) + def test_move_to_end_issue25406(self): + OrderedDict = self.module.OrderedDict + od = OrderedDict.fromkeys('abc') + od.move_to_end('c', last=False) + self.assertEqual(list(od), list('cab')) + od.move_to_end('a', last=False) + self.assertEqual(list(od), list('acb')) + + od = OrderedDict.fromkeys('abc') + od.move_to_end('a') + self.assertEqual(list(od), list('bca')) + od.move_to_end('c') + self.assertEqual(list(od), list('bac')) + def test_sizeof(self): OrderedDict = self.module.OrderedDict # Wimpy test: Just verify the reported size is larger than a regular dict -- cgit v1.2.1