From ba22e8f174309979d90047c5dc64fcb63bc2c32e Mon Sep 17 00:00:00 2001 From: Berker Peksag Date: Tue, 25 Feb 2020 06:19:03 +0300 Subject: bpo-30566: Fix IndexError when using punycode codec (GH-18632) Trying to decode an invalid string with the punycode codec shoud raise UnicodeError. --- Lib/test/test_codecs.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) (limited to 'Lib/test/test_codecs.py') diff --git a/Lib/test/test_codecs.py b/Lib/test/test_codecs.py index 3aec34c7f1..8d9cb90890 100644 --- a/Lib/test/test_codecs.py +++ b/Lib/test/test_codecs.py @@ -1343,6 +1343,18 @@ class PunycodeTest(unittest.TestCase): puny = puny.decode("ascii").encode("ascii") self.assertEqual(uni, puny.decode("punycode")) + def test_decode_invalid(self): + testcases = [ + (b"xn--w&", "strict", UnicodeError()), + (b"xn--w&", "ignore", "xn-"), + ] + for puny, errors, expected in testcases: + with self.subTest(puny=puny, errors=errors): + if isinstance(expected, Exception): + self.assertRaises(UnicodeError, puny.decode, "punycode", errors) + else: + self.assertEqual(puny.decode("punycode", errors), expected) + # From http://www.gnu.org/software/libidn/draft-josefsson-idn-test-vectors.html nameprep_tests = [ -- cgit v1.2.1