From 1eda9e7c3074bfe37674c8140b3d02bf94caf4f3 Mon Sep 17 00:00:00 2001 From: "Gregory P. Smith" Date: Sat, 30 Nov 2013 19:02:57 -0800 Subject: Fixes Issue #15798 - subprocess.Popen() no longer fails if file descriptor 0, 1 or 2 is closed. --- Lib/subprocess.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'Lib/subprocess.py') diff --git a/Lib/subprocess.py b/Lib/subprocess.py index c3a278836c..a659087ab6 100644 --- a/Lib/subprocess.py +++ b/Lib/subprocess.py @@ -1368,7 +1368,10 @@ class Popen(object): executable_list = tuple( os.path.join(os.fsencode(dir), executable) for dir in os.get_exec_path(env)) - fds_to_keep = set(pass_fds) + # Never close stdin, stdout and stderr for the child. + fds_to_keep = {0,1,2} + fds_to_keep.update(pass_fds) + # Our child uses this one to signal error before exec(). fds_to_keep.add(errpipe_write) self.pid = _posixsubprocess.fork_exec( args, executable_list, -- cgit v1.2.1