From 11529195cae2438a3ac003babcb1b11af67c4037 Mon Sep 17 00:00:00 2001 From: Eric Smith Date: Tue, 4 Sep 2007 23:04:22 +0000 Subject: Changed some ValueError's to KeyError and IndexError. Corrected code for invalid conversion specifier. Added tests to verify. Modified string.Formatter to correctly expand format_spec's, and added a limit to recursion depth. Added _vformat() method to support both of these. --- Lib/string.py | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) (limited to 'Lib/string.py') diff --git a/Lib/string.py b/Lib/string.py index 9b00a62e88..03179fbb44 100644 --- a/Lib/string.py +++ b/Lib/string.py @@ -202,6 +202,13 @@ class Formatter: def vformat(self, format_string, args, kwargs): used_args = set() + result = self._vformat(format_string, args, kwargs, used_args, 2) + self.check_unused_args(used_args, args, kwargs) + return result + + def _vformat(self, format_string, args, kwargs, used_args, recursion_depth): + if recursion_depth < 0: + raise ValueError('Max string recursion exceeded') result = [] for literal_text, field_name, format_spec, conversion in \ self.parse(format_string): @@ -223,10 +230,13 @@ class Formatter: # do any conversion on the resulting object obj = self.convert_field(obj, conversion) + # expand the format spec, if needed + format_spec = self._vformat(format_spec, args, kwargs, + used_args, recursion_depth-1) + # format the object and append to the result result.append(self.format_field(obj, format_spec)) - self.check_unused_args(used_args, args, kwargs) return ''.join(result) @@ -251,9 +261,9 @@ class Formatter: return repr(value) elif conversion == 's': return str(value) - else: - assert conversion is None + elif conversion is None: return value + raise ValueError("Unknown converion specifier {0!s}".format(conversion)) # returns an iterable that contains tuples of the form: -- cgit v1.2.1