From 877766dee8e60c7971ed0cabba89fbe981c2ab1b Mon Sep 17 00:00:00 2001 From: Antoine Pitrou Date: Sat, 19 Mar 2011 17:00:37 +0100 Subject: Issue #11459: A `bufsize` value of 0 in subprocess.Popen() really creates unbuffered pipes, such that select() works properly on them. --- Lib/os.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'Lib/os.py') diff --git a/Lib/os.py b/Lib/os.py index aa1a40f7a7..b46c02f580 100644 --- a/Lib/os.py +++ b/Lib/os.py @@ -629,11 +629,13 @@ if not _exists("urandom"): return bs # Supply os.popen() -def popen(cmd, mode="r", buffering=None): +def popen(cmd, mode="r", buffering=-1): if not isinstance(cmd, str): raise TypeError("invalid cmd type (%s, expected string)" % type(cmd)) if mode not in ("r", "w"): raise ValueError("invalid mode %r" % mode) + if buffering == 0 or buffering == None: + raise ValueError("popen() does not support unbuffered streams") import subprocess, io if mode == "r": proc = subprocess.Popen(cmd, -- cgit v1.2.1