From 7b998e9f522e088675005eadc4bf934f3d212dc6 Mon Sep 17 00:00:00 2001 From: Antoine Pitrou Date: Mon, 4 Oct 2010 21:55:14 +0000 Subject: GzipFile.peek improvements, suggested by Nir Aides. --- Lib/gzip.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'Lib/gzip.py') diff --git a/Lib/gzip.py b/Lib/gzip.py index 58e866b132..7c3fd5157e 100644 --- a/Lib/gzip.py +++ b/Lib/gzip.py @@ -342,16 +342,18 @@ class GzipFile(io.BufferedIOBase): def peek(self, n): if self.mode != READ: import errno - raise IOError(errno.EBADF, "read() on write-only GzipFile object") + raise IOError(errno.EBADF, "peek() on write-only GzipFile object") - # Do not return ridiculously small buffers + # Do not return ridiculously small buffers, for one common idiom + # is to call peek(1) and expect more bytes in return. if n < 100: n = 100 if self.extrasize == 0: if self.fileobj is None: return b'' try: - self._read(max(self.max_read_chunk, n)) + # 1024 is the same buffering heuristic used in read() + self._read(max(n, 1024)) except EOFError: pass offset = self.offset - self.extrastart -- cgit v1.2.1