From 5abd76a75d633a1ba6f5fcc66b0bc4799b9e2eaa Mon Sep 17 00:00:00 2001 From: R David Murray Date: Mon, 10 Sep 2012 10:15:58 -0400 Subject: #14649: clarify DocTestSuite error when there are no docstrings. Also adds tests to verify the documented behavior (which is probably a bug, as indicated in the added comments). Patch by Chris Jerdonek. --- Lib/doctest.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'Lib/doctest.py') diff --git a/Lib/doctest.py b/Lib/doctest.py index cc3b425075..e189c8feba 100644 --- a/Lib/doctest.py +++ b/Lib/doctest.py @@ -2333,7 +2333,12 @@ def DocTestSuite(module=None, globs=None, extraglobs=None, test_finder=None, elif not tests: # Why do we want to do this? Because it reveals a bug that might # otherwise be hidden. - raise ValueError(module, "has no tests") + # It is probably a bug that this exception is not also raised if the + # number of doctest examples in tests is zero (i.e. if no doctest + # examples were found). However, we should probably not be raising + # an exception at all here, though it is too late to make this change + # for a maintenance release. See also issue #14649. + raise ValueError(module, "has no docstrings") tests.sort() suite = unittest.TestSuite() -- cgit v1.2.1