From fd512d76456b65c529a5bc58d8cfe73e4a10de7a Mon Sep 17 00:00:00 2001 From: Vincent Michel Date: Thu, 8 Nov 2018 13:21:47 +0100 Subject: bpo-35065: Remove `StreamReaderProtocol._untrack_reader` (#10212) The call to `_untrack_reader` is performed too soon, causing the protocol to forget about the reader before `connection_lost` can run and feed the EOF to the reader. See bpo-35065. --- Lib/asyncio/subprocess.py | 5 ----- 1 file changed, 5 deletions(-) (limited to 'Lib/asyncio/subprocess.py') diff --git a/Lib/asyncio/subprocess.py b/Lib/asyncio/subprocess.py index c86de3d087..90fc00de83 100644 --- a/Lib/asyncio/subprocess.py +++ b/Lib/asyncio/subprocess.py @@ -36,11 +36,6 @@ class SubprocessStreamProtocol(streams.FlowControlMixin, info.append(f'stderr={self.stderr!r}') return '<{}>'.format(' '.join(info)) - def _untrack_reader(self): - # StreamWriter.close() expects the protocol - # to have this method defined. - pass - def connection_made(self, transport): self._transport = transport -- cgit v1.2.1