From d165e14e29b45a22450263722f5c2c386c3a748a Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Wed, 13 Sep 2017 05:53:10 -0700 Subject: bpo-31448, test_poplib: Fix ResourceWarning (#3542) Call POP3.close(), don't close close directly the sock attribute. --- Lib/test/test_poplib.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Lib/test/test_poplib.py b/Lib/test/test_poplib.py index d7a26bc14c..721ea25201 100644 --- a/Lib/test/test_poplib.py +++ b/Lib/test/test_poplib.py @@ -488,7 +488,7 @@ class TestTimeouts(TestCase): finally: socket.setdefaulttimeout(None) self.assertEqual(pop.sock.gettimeout(), 30) - pop.sock.close() + pop.close() def testTimeoutNone(self): self.assertIsNone(socket.getdefaulttimeout()) @@ -498,12 +498,12 @@ class TestTimeouts(TestCase): finally: socket.setdefaulttimeout(None) self.assertIsNone(pop.sock.gettimeout()) - pop.sock.close() + pop.close() def testTimeoutValue(self): pop = poplib.POP3(HOST, self.port, timeout=30) self.assertEqual(pop.sock.gettimeout(), 30) - pop.sock.close() + pop.close() def test_main(): -- cgit v1.2.1