delta/cpython-git.git/Python/_warnings.c, branch v3.6.7 github.com: python/cpython.git [3.6] bpo-32591: fix abort in _PyErr_WarnUnawaitedCoroutine during shutdown (GH-5337) (#6536) 2018-05-31T10:20:46+00:00 T. Wouters thomas@python.org 2018-05-31T10:20:46+00:00 500a419a7a68c32650717b213f0f5ab0461bb16b When an unawaited coroutine is collected very late in shutdown -- like, during the final GC at the end of PyImport_Cleanup -- then it was triggering an interpreter abort, because we'd try to look up the "warnings" module and not only was it missing (we were prepared for that), but the entire module system was missing (which we were not prepared for). I've tried to fix this at the source, by making the utility function get_warnings_attr robust against this in general. Note that it already has the convention that it can return NULL without setting an error, which is how it signals that the attribute it was asked to fetch is missing, and that all callers already check for NULL returns. There's a similar check for being late in shutdown at the top of warn_explicit, which might be unnecessary after this fix, but I'm not sure so I'm going to leave it.. (cherry picked from commit dba976b8a28d6e5daa66ef31a6a7c694a9193f6a) Co-authored-by: Nathaniel J. Smith <njs@pobox.com> 
When an unawaited coroutine is collected very late in shutdown --
like, during the final GC at the end of PyImport_Cleanup -- then it
was triggering an interpreter abort, because we'd try to look up the
"warnings" module and not only was it missing (we were prepared for
that), but the entire module system was missing (which we were not
prepared for).

I've tried to fix this at the source, by making the utility function
get_warnings_attr robust against this in general. Note that it already
has the convention that it can return NULL without setting an error,
which is how it signals that the attribute it was asked to fetch is
missing, and that all callers already check for NULL returns.

There's a similar check for being late in shutdown at the top of
warn_explicit, which might be unnecessary after this fix, but I'm not
sure so I'm going to leave it..
(cherry picked from commit dba976b8a28d6e5daa66ef31a6a7c694a9193f6a)

Co-authored-by: Nathaniel J. Smith <njs@pobox.com>
 [3.6] bpo-31285: Remove splitlines identifier from Python/_warnings.c (GH-3803) (#3829) 2017-09-29T19:26:45+00:00 Miss Islington (bot) 31488909+miss-islington@users.noreply.github.com 2017-09-29T19:26:45+00:00 66c2b9f13ef2197a5212fd58372173124df76467 (forgot to remove it in GH-3219) (cherry picked from commit 8b4ff53c440dfcde40fbeb02c5e666c85190528f) 
(forgot to remove it in GH-3219)
(cherry picked from commit 8b4ff53c440dfcde40fbeb02c5e666c85190528f)
 [3.6] bpo-31285: Fix an assertion failure and a SystemError in warnings.warn_explicit. (GH-3219) (#3775) 2017-09-27T04:38:03+00:00 Serhiy Storchaka storchaka@gmail.com 2017-09-27T04:38:03+00:00 90fe25a051bd8cf64d52be533c9b60cad9bdd7fb (cherry picked from commit 91fb0afe181986b48abfc6092dcca912b39de51d) 
(cherry picked from commit 91fb0afe181986b48abfc6092dcca912b39de51d)
 [3.6] bpo-31566: Fix an assertion failure in _warnings.warn() in case of a bad __name__ global. (GH-3717) (#3730) 2017-09-24T20:14:41+00:00 Miss Islington (bot) 31488909+miss-islington@users.noreply.github.com 2017-09-24T20:14:41+00:00 415cc1fa57710614ed3384d0cafc58ccf7adee8c (cherry picked from commit 5d3e80021ab33360191eb0fbff34e0246c913884) 
(cherry picked from commit 5d3e80021ab33360191eb0fbff34e0246c913884)
 [3.6] bpo-31416: Fix assertion failures in case of a bad warnings.filters or warnings.defaultaction. (GH-3496) (#3509) 2017-09-12T06:48:27+00:00 Serhiy Storchaka storchaka@gmail.com 2017-09-12T06:48:27+00:00 9adc87b0f82e5169c5f44739f89212a86013d1c4 Patch by Oren Milman.. (cherry picked from commit 9d984fd2b097c8c29479d1c3eb740995fe1ccb0d) 
Patch by Oren Milman..
(cherry picked from commit 9d984fd2b097c8c29479d1c3eb740995fe1ccb0d)
 [3.6] bpo-31411: Prevent raising a SystemError in case warnings.onceregistry is not a dictionary. (GH-3485). (#3494) 2017-09-11T07:01:47+00:00 Serhiy Storchaka storchaka@gmail.com 2017-09-11T07:01:47+00:00 7972ed2111ea2f01e8712eef91bcf2260e05ad8b (cherry picked from commit 252033d50effa08046ac34fcc406bc99796ab88b) 
(cherry picked from commit 252033d50effa08046ac34fcc406bc99796ab88b)
 Issue #28701: Replace PyUnicode_CompareWithASCIIString with _PyUnicode_EqualToASCIIString. 2016-11-16T08:19:20+00:00 Serhiy Storchaka storchaka@gmail.com 2016-11-16T08:19:20+00:00 3b73ea127892d0e1f9d8f12f88e4f9c0ba0b89b1 The latter function is more readable, faster and doesn't raise exceptions. 
The latter function is more readable, faster and doesn't raise exceptions.
Issue #28701: Replace PyUnicode_CompareWithASCIIString with _PyUnicode_EqualToASCIIString. 2016-11-16T08:17:58+00:00 Serhiy Storchaka storchaka@gmail.com 2016-11-16T08:17:58+00:00 f4934ea77da38516731a75fbf9458b248d26dd81 The latter function is more readable, faster and doesn't raise exceptions. 
The latter function is more readable, faster and doesn't raise exceptions.
Issue #26200: Added Py_SETREF and replaced Py_XSETREF with Py_SETREF 2016-04-10T15:12:01+00:00 Serhiy Storchaka storchaka@gmail.com 2016-04-10T15:12:01+00:00 f01e408c1688a207eba18444da8c151c872fba59 in places where Py_DECREF was used. 
in places where Py_DECREF was used.
Issue #26200: Added Py_SETREF and replaced Py_XSETREF with Py_SETREF 2016-04-10T15:05:40+00:00 Serhiy Storchaka storchaka@gmail.com 2016-04-10T15:05:40+00:00 57a01d3a0ee20ee9eea69b658c6bac0f39541625 in places where Py_DECREF was used. 
in places where Py_DECREF was used.