From 19ff28bd95b79e421059fdccf6b07e0a23f12aa3 Mon Sep 17 00:00:00 2001 From: Tim Wawrzynczak Date: Wed, 23 Oct 2019 14:48:12 -0600 Subject: ec_sync: Remove vb2ex_get_expected_image() callback This callback is redundant, because vboot takes the buffer pointer and just passes it straight into vb2ex_ec_update_image(), so clearly the platform must be able to find the image on its own. Remove it, and also remove the arguments to vb2ex_ec_update_image which were the image and its size. BUG=none BRANCH=none TEST=make runtests Cq-Depend: chromium:1910562 Change-Id: I35548cc0bde761cf08337489af0772bbdf46de4d Signed-off-by: Tim Wawrzynczak Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1877065 Reviewed-by: Julius Werner --- tests/vb2_ec_sync_tests.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) (limited to 'tests/vb2_ec_sync_tests.c') diff --git a/tests/vb2_ec_sync_tests.c b/tests/vb2_ec_sync_tests.c index 241a1206..86159463 100644 --- a/tests/vb2_ec_sync_tests.c +++ b/tests/vb2_ec_sync_tests.c @@ -176,15 +176,6 @@ vb2_error_t vb2ex_ec_hash_image(enum vb2_firmware_selection select, return *hash_size ? VB2_SUCCESS : VB2_ERROR_MOCK; } -vb2_error_t vb2ex_ec_get_expected_image(enum vb2_firmware_selection select, - const uint8_t **image, int *image_size) -{ - static uint8_t fake_image[64] = {5, 6, 7, 8}; - *image = fake_image; - *image_size = sizeof(fake_image); - return get_expected_retval; -} - vb2_error_t vb2ex_ec_get_expected_image_hash(enum vb2_firmware_selection select, const uint8_t **hash, int *hash_size) { @@ -194,8 +185,7 @@ vb2_error_t vb2ex_ec_get_expected_image_hash(enum vb2_firmware_selection select, return want_ec_hash_size ? VB2_SUCCESS : VB2_ERROR_MOCK; } -vb2_error_t vb2ex_ec_update_image(enum vb2_firmware_selection select, - const uint8_t *image, int image_size) +vb2_error_t vb2ex_ec_update_image(enum vb2_firmware_selection select) { if (select == VB_SELECT_FIRMWARE_READONLY) { ec_ro_updated = 1; -- cgit v1.2.1