From 7d205000b0ad85c35b724dd5ba71bc648627d826 Mon Sep 17 00:00:00 2001 From: Joel Kitching Date: Thu, 5 Dec 2019 15:02:32 +0800 Subject: vboot: remove static linking support from Makefile Previously, futility and crossystem needed to be statically linked. (futility had both futility and futility_s.) Since there's no longer any need to statically link any binaries built by vboot_reference, remove this support from the Makefile. BUG=b:124141368, chromium:765499 TEST=make clean && make runtests BRANCH=none Change-Id: I8c2b5c5b5aa86bbecb0c264f688dfdac4b19ca7e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1954976 Tested-by: Joel Kitching Commit-Queue: Joel Kitching Reviewed-by: Julius Werner --- Makefile | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) (limited to 'Makefile') diff --git a/Makefile b/Makefile index 05b94c6b..2116741a 100644 --- a/Makefile +++ b/Makefile @@ -575,9 +575,6 @@ UTIL_SCRIPTS += \ utility/vbutil_what_keys endif -# These utilities should also provide static linked version (*_s). -UTIL_NAMES_STATIC = - UTIL_NAMES = \ utility/crossystem \ utility/dumpRSAPublicKey \ @@ -594,8 +591,7 @@ LZMA_LIBS = $(shell ${PKG_CONFIG} --libs liblzma) YAML_LIBS = $(shell ${PKG_CONFIG} --libs yaml-0.1) endif -UTIL_BINS_STATIC := $(addsuffix _s,$(addprefix ${BUILD}/,${UTIL_NAMES_STATIC})) -UTIL_BINS = $(addprefix ${BUILD}/,${UTIL_NAMES}) ${UTIL_BINS_STATIC} +UTIL_BINS = $(addprefix ${BUILD}/,${UTIL_NAMES}) ALL_OBJS += $(addsuffix .o,${UTIL_BINS}) @@ -1008,12 +1004,8 @@ cgpt_wrapper_install: cgpt_install ${CGPT_WRAPPER} # These have their own headers too. ${BUILD}/utility/%: INCLUDES += -Iutility/include -${UTIL_BINS} ${UTIL_BINS_STATIC}: ${UTILLIB} -${UTIL_BINS} ${UTIL_BINS_STATIC}: LIBS = ${UTILLIB} - -# Utilities for auto-update toolkits must be statically linked. -${UTIL_BINS_STATIC}: LDFLAGS += -static - +${UTIL_BINS}: ${UTILLIB} +${UTIL_BINS}: LIBS = ${UTILLIB} .PHONY: utils utils: ${UTIL_BINS} ${UTIL_SCRIPTS} @@ -1149,7 +1141,6 @@ ${UTIL_DEFAULTS}: # Some utilities need external crypto functions CRYPTO_LIBS := $(shell ${PKG_CONFIG} --libs libcrypto) -CRYPTO_STATIC_LIBS := $(shell ${PKG_CONFIG} --libs libcrypto --static) ${BUILD}/utility/dumpRSAPublicKey: LDLIBS += ${CRYPTO_LIBS} ${BUILD}/utility/pad_digest_utility: LDLIBS += ${CRYPTO_LIBS} -- cgit v1.2.1