From a4c92cb149aec7143b6f552d1456f8a0475cc17f Mon Sep 17 00:00:00 2001 From: Shawn Nematbakhsh Date: Tue, 30 Oct 2012 15:17:33 -0700 Subject: vboot_reference: Fix keyboard input lag at confirm screen. Changing languages is terribly slow at the confirm screen, when switching from dev to normal. Reduce sleep time to improve user experience. BUG=chrome-os-partner:15726 TEST=boot in dev, hit space, hit arrows rapidly to change language, observe no lag. BRANCH=butterfly, stout Change-Id: I0943debc31d78dcfce87e7f7d4537ae47f5f8cfd Reviewed-on: https://gerrit.chromium.org/gerrit/36956 Reviewed-by: Duncan Laurie Reviewed-by: Bill Richardson Commit-Ready: Shawn Nematbakhsh Tested-by: Shawn Nematbakhsh Reviewed-by: Randall Spangler Reviewed-on: https://gerrit.chromium.org/gerrit/37938 Tested-by: Simon Glass --- firmware/lib/vboot_api_kernel.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/firmware/lib/vboot_api_kernel.c b/firmware/lib/vboot_api_kernel.c index a35fd31a..ffcb75ce 100644 --- a/firmware/lib/vboot_api_kernel.c +++ b/firmware/lib/vboot_api_kernel.c @@ -105,6 +105,8 @@ uint32_t VbTryLoadKernel(VbCommonParams* cparams, LoadKernelParams* p, return retval; } +#define CONFIRM_KEY_DELAY 20 /* Check confirm screen keys every 20ms */ + /* Ask the user to confirm something. We should display whatever the question * is first, then call this. ESC is always "no", ENTER is always "yes", and * we'll specify what SPACE means. We don't return until one of those keys is @@ -139,7 +141,7 @@ static int VbUserConfirms(VbCommonParams* cparams, int space_means_no) { default: VbCheckDisplayKey(cparams, key, &vnc); } - VbExSleepMs(1000); + VbExSleepMs(CONFIRM_KEY_DELAY); } /* not reached, but compiler will complain without it */ return -1; -- cgit v1.2.1