From 8f7b7055a134d003920b4a67a951d23ad7b1f939 Mon Sep 17 00:00:00 2001 From: Hung-Te Lin Date: Wed, 21 May 2014 11:15:57 +0800 Subject: lib: Handle return error code of VbExDisplaySetDimension correctly. The return value of VbExDisplaySetDimension should be handled as VbError_t, which means we should print error message when it's not zero. Also add the return code to debug message. BRANCH=none BUG=none TEST=emerge-nyan coreboot chromeos-bootimage, enter recovery screen. Not seeing error messages anymore. Change-Id: Icafdfd933d799e8496fedcf1633339065c6962a3 Reviewed-on: https://chromium-review.googlesource.com/200679 Reviewed-by: Bill Richardson Commit-Queue: Hung-Te Lin Tested-by: Hung-Te Lin --- firmware/lib/vboot_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/firmware/lib/vboot_display.c b/firmware/lib/vboot_display.c index 669c4e8d..6e0c93ac 100644 --- a/firmware/lib/vboot_display.c +++ b/firmware/lib/vboot_display.c @@ -239,11 +239,11 @@ VbError_t VbDisplayScreenFromGBB(VbCommonParams *cparams, uint32_t screen, ret = VbExDisplaySetDimension( image_info.width, image_info.height); - if (!ret) { + if (ret) { VBDEBUG(("VbExDisplaySetDimension" - "(%d,%d): failed.\n", + "(%d,%d): failed (%#x).\n", image_info.width, - image_info.height)); + image_info.height, ret)); } } -- cgit v1.2.1