From 7cdd879fe9381015aa01be36c0937bac8690253e Mon Sep 17 00:00:00 2001 From: Jacob Garber Date: Tue, 13 Aug 2019 14:50:16 -0600 Subject: tests: Add array bounds check Ensure that mock_keypresses_count is in bounds before accessing the mock_keyflags array. BUG=none TEST=make clean && make runtests BRANCH=none Change-Id: Ifa8fce5438f2e2547c9e316038466244eee7bfa9 Signed-off-by: Jacob Garber Found-by: Coverity CID 198899 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1752048 Reviewed-by: Joel Kitching --- tests/vboot_api_kernel2_tests.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/vboot_api_kernel2_tests.c b/tests/vboot_api_kernel2_tests.c index 2469512e..49a4233a 100644 --- a/tests/vboot_api_kernel2_tests.c +++ b/tests/vboot_api_kernel2_tests.c @@ -157,7 +157,8 @@ uint32_t VbExKeyboardRead(void) uint32_t VbExKeyboardReadWithFlags(uint32_t *key_flags) { if (mock_keypress_count < ARRAY_SIZE(mock_keypress)) { - if (key_flags != NULL) + if (key_flags != NULL && + mock_keypress_count < ARRAY_SIZE(mock_keyflags)) *key_flags = mock_keyflags[mock_keypress_count]; return mock_keypress[mock_keypress_count++]; } else -- cgit v1.2.1