From 5cb2e84a191583f0e4d01ee6077404f85531f6c7 Mon Sep 17 00:00:00 2001 From: Patrick Georgi Date: Tue, 27 Aug 2019 17:27:39 +0200 Subject: futility/updater: Check that image exists before digging into it Found by Coverity Scan BUG=none BRANCH=none TEST=none Change-Id: I2544a4e84ecadc262e08aaa4e6f056d710d807f5 Signed-off-by: Patrick Georgi Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1771972 Reviewed-by: Julius Werner Reviewed-by: Hung-Te Lin Tested-by: Patrick Georgi Commit-Queue: Patrick Georgi --- futility/updater.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/futility/updater.c b/futility/updater.c index ef75d747..4d523e29 100644 --- a/futility/updater.c +++ b/futility/updater.c @@ -618,6 +618,11 @@ static int load_firmware_version(struct firmware_image *image, int load_firmware_image(struct firmware_image *image, const char *file_name, struct archive *archive) { + if (!file_name) { + ERROR("No file name given\n"); + return -1; + } + VB2_DEBUG("Load image file from %s...\n", file_name); if (!archive_has_entry(archive, file_name)) { -- cgit v1.2.1