From 43949662d8f4738afa3c8b641e7a2d198a658138 Mon Sep 17 00:00:00 2001 From: Bill Richardson Date: Tue, 15 Jan 2013 14:08:36 -0800 Subject: Revert "Trigger sync right after writing." This reverts commit f3613b60c7374dfcf54c922d46c7da8feeb22000. That commit attempts to solve a disk-syncing problem by forcing numerous sync() calls inside cgpt. However, it's too much of a sledgehammer approach. Some subset of buildbots now run a short test suite when compiling vboot_reference. On my z620, commit f3613b60c737 increases the time to run "make runcgpttests" from 1.6 seconds to over eight minutes. We need a different solution to this problem. BUG=chromium-os:35992 TEST=manual BRANCH=none To test: cd vboot_reference make && make runtests Change-Id: I0489906103dbc93edf201570bd9158621c651d54 Signed-off-by: Bill Richardson Reviewed-on: https://gerrit.chromium.org/gerrit/41306 Reviewed-by: Randall Spangler --- cgpt/cgpt_common.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/cgpt/cgpt_common.c b/cgpt/cgpt_common.c index 8247a5a8..193f2e1e 100644 --- a/cgpt/cgpt_common.c +++ b/cgpt/cgpt_common.c @@ -269,12 +269,7 @@ int DriveClose(struct drive *drive, int update_as_needed) { } } - // Sync early! - fsync(drive->fd); - syncfs(drive->fd); - close(drive->fd); - sync(); if (drive->gpt.primary_header) free(drive->gpt.primary_header); -- cgit v1.2.1