diff options
| author | Jacob Garber <jgarber1@ualberta.ca> | 2019-08-07 12:03:10 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-08-24 00:20:16 +0000 |
| commit | b3ae709ea68a2e98b1f1d2d52b9d4c48bfeb3c30 (patch) | |
| tree | 725519c8cb7f11758e10525c2818b467fd47af13 | |
| parent | 62898ffcbd4ed13ac0c92ad4b8f21e62ec6d7ab0 (diff) | |
| download | vboot-b3ae709ea68a2e98b1f1d2d52b9d4c48bfeb3c30.tar.gz | |
Makefile: Enable -Wimplicit-fallthrough
Implicit fallthroughs are always a source of trouble, so let's get the
compiler to catch them for us. Intentional fallthroughs can be marked
using the /* fall through */ comment to silence this warning.
BUG=none
TEST=make clean && make runtests
BRANCH=none
Change-Id: I66a9edc810674a732c0530cd78b5aa8a2c37f562
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1742640
Reviewed-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
| -rw-r--r-- | Makefile | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -142,7 +142,7 @@ COMMON_FLAGS := -pipe ${WERROR} -Wall -Wstrict-prototypes -Wtype-limits \ -Wundef -Wmissing-prototypes -Wno-trigraphs -Wredundant-decls \ -Wwrite-strings -Wstrict-aliasing -Wshadow -Wdate-time \ -Wno-address-of-packed-member -ffunction-sections -fdata-sections \ - ${DEBUG_FLAGS} + -Wimplicit-fallthrough ${DEBUG_FLAGS} # Note: FIRMWARE_ARCH is defined by the Chromium OS ebuild. ifeq (${FIRMWARE_ARCH}, arm) |