delta/coreboot/vboot.git/tests, branch stabilize-12441.B

tests: Add array bounds check

2019-08-17T01:13:01+00:00

Ensure that mock_keypresses_count is in bounds before accessing the
mock_keyflags array.

BUG=none
TEST=make clean && make runtests
BRANCH=none

Change-Id: Ifa8fce5438f2e2547c9e316038466244eee7bfa9
Signed-off-by: Jacob Garber 
Found-by: Coverity CID 198899
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1752048
Reviewed-by: Joel Kitching

vboot: vb2_shared_data offsets should hang off parent

2019-08-16T07:25:30+00:00

vb2_shared_data struct has many offsets to other objects in the
workbuf.  They are all prefixed with `workbuf_`, e.g.:
  uint32_t workbuf_data_key_offset;
  uint32_t workbuf_data_key_size;

In order to adhere to a hierarchical structure on the workbuf,
remove the workbuf_ prefix from these symbols to reflect the
relationship between vb2_shared_data and its children more
accurately.

Create a helper function vb2_member_of to safely look up a child
of a particular object in the workbuf by offset.  Pointer
arithmetic to find vb2_shared_data children is replaced with
calls to this function.

BUG=b:124141368, chromium:994060
TEST=make clean && make runtests
BRANCH=none

Change-Id: Ia82417a35d2067ee5e4f42fea0396e6325127223
Signed-off-by: Joel Kitching 
Cq-Depend: chromium:1753400
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1718264
Commit-Queue: Joel Kitching 
Tested-by: Joel Kitching 
Reviewed-by: Julius Werner

tests: Fix off-by-one error in array bounds check

2019-08-16T04:13:20+00:00

rptr points to an object with rsize number of bytes. If offset + size ==
rsize, then rptr + offset + size will point to one byte past the end of
the object during the memcpy(). Exclude this case by adding it to the
bounds check. We can also remove the offset > rsize check since it is
subsumed in the other one.

BUG=none
TEST=make clean && make runtests
BRANCH=none

Change-Id: Iceda658f420babe61bd1d9807efc8333d2044ccc
Signed-off-by: Jacob Garber 
Found-by: Coverity CID 198905
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1752766
Reviewed-by: Joel Kitching

vboot: properly check failure from VbExGetLocalizationCount

2019-08-13T13:03:55+00:00

Check the return value and result of calling
VbExGetLocalizationCount.  If something is awry,
fall back to using one language entry.

BUG=b:124141368
TEST=make clean && make runtests
BRANCH=none

Change-Id: Ieeea54bfed303a98d16f15aceab47f1ffdd10d6d
Signed-off-by: Joel Kitching 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1729773
Commit-Queue: Joel Kitching 
Tested-by: Joel Kitching 
Reviewed-by: Julius Werner

vboot/secdata: remove retries from rollback functions

2019-08-13T08:27:53+00:00

Assume that transport-layer communication to Cr50 is reliable.
No need for retries on reads/writes, or verification after write.

BUG=b:124141368, chromium:972956
TEST=make clean && make runtests
BRANCH=none

Change-Id: Ie57d1eeaa44c338bca289e371c516540aacf9437
Signed-off-by: Joel Kitching 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1729713
Tested-by: Joel Kitching 
Reviewed-by: Julius Werner 
Commit-Queue: Joel Kitching

vboot: replace VBERROR_INVALID_PARAMETER with vboot2 equivalent

2019-08-13T08:23:57+00:00

Replace vboot1-style VBERROR_INVALID_PARAMETER with vboot2 equivalent
VB2_ERROR_INVALID_PARAMETER.

BUG=b:124141368, chromium:988410
TEST=make clean && make runtests
BRANCH=none

Change-Id: I46227cd3a7d7ce84654a0093f9d64883c9563381
Signed-off-by: Joel Kitching 
Cq-Depend: chromium:1728116
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1728294
Commit-Queue: Joel Kitching 
Tested-by: Joel Kitching 
Reviewed-by: Julius Werner

vboot: replace VBERROR_SIMULATED with VB2_ERROR_MOCK

2019-08-13T08:23:56+00:00

Replace vboot1-style VBERROR_SIMULATED with VB2_ERROR_MOCK.

BUG=b:124141368, chromium:988410
TEST=make clean && make runtests
BRANCH=none

Change-Id: I9f7a21b957097672883a428a5210c14a27852085
Signed-off-by: Joel Kitching 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1722917
Commit-Queue: Joel Kitching 
Tested-by: Joel Kitching 
Reviewed-by: Julius Werner

vboot: replace VBERROR_UNKNOWN with VB2_ERROR_UNKNOWN

2019-08-13T08:23:55+00:00

Replace vboot1-style VBERROR_UNKNOWN with VB2_ERROR_UNKNOWN.

BUG=b:124141368, chromium:988410
TEST=make clean && make runtests
BRANCH=none

Change-Id: Icd2158e328142cff69ce94b5396ab021a1f7839c
Signed-off-by: Joel Kitching 
Cq-Depend: chromium:1728115
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1722916
Commit-Queue: Joel Kitching 
Tested-by: Joel Kitching 
Reviewed-by: Julius Werner

vboot: replace VBERROR_SUCCESS with VB2_SUCCESS

2019-08-13T08:23:54+00:00

Replace vboot1-style VBERROR_SUCCESS with VB2_SUCCESS
(trivial change since both are equal values).

BUG=b:124141368, chromium:988410
TEST=make clean && make runtests
BRANCH=none

Change-Id: I46e02471a031e9f36ec869d11d0b957d1c1b5769
Signed-off-by: Joel Kitching 
Cq-Depend: chromium:1728114
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1722915
Commit-Queue: Joel Kitching 
Tested-by: Joel Kitching 
Reviewed-by: Julius Werner

vboot: update vboot2 functions to use new vb2_error_t

2019-08-13T04:36:52+00:00

To make explicit when vboot2 error codes should be returned,
use the new vb2_error_t type on all functions which return
VB2_ERROR_* constants.

BUG=b:124141368, chromium:988410
TEST=make clean && make runtests
BRANCH=none

Change-Id: Idd3ee8afe8c78347783ce5fa829cb78f1e5719e2
Signed-off-by: Joel Kitching 
Cq-Depend: chromium:1728113, chromium:1728499
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1728292
Reviewed-by: Joel Kitching 
Commit-Queue: Joel Kitching 
Tested-by: Joel Kitching