<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/coreboot/vboot.git/tests, branch factory-3536.B</title>
<subtitle>review.coreboot.org: vboot.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/'/>
<entry>
<title>Move lengthy tests from 'make runtests' to 'make runlongtests'</title>
<updated>2013-01-03T19:14:51+00:00</updated>
<author>
<name>Randall Spangler</name>
<email>rspangler@chromium.org</email>
</author>
<published>2013-01-03T00:49:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=e8cfa31d548c069d73c304fea522b527fe7c7dd6'/>
<id>e8cfa31d548c069d73c304fea522b527fe7c7dd6</id>
<content type='text'>
This reduces 'make runtests' from ~90 sec on a z620 to ~8 sec, which
is short enough we can run it as part of the continuous build.

BUG=chromium-os:26317
BRANCH=none
TEST=make &amp;&amp; time make runtests &amp;&amp; time make runlongtests

Change-Id: I8165efaf8b8290ca3c8f8da73e3f8a54c2bc19f9
Reviewed-on: https://gerrit.chromium.org/gerrit/40374
Reviewed-by: Bill Richardson &lt;wfrichar@chromium.org&gt;
Commit-Queue: Randall Spangler &lt;rspangler@chromium.org&gt;
Tested-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reduces 'make runtests' from ~90 sec on a z620 to ~8 sec, which
is short enough we can run it as part of the continuous build.

BUG=chromium-os:26317
BRANCH=none
TEST=make &amp;&amp; time make runtests &amp;&amp; time make runlongtests

Change-Id: I8165efaf8b8290ca3c8f8da73e3f8a54c2bc19f9
Reviewed-on: https://gerrit.chromium.org/gerrit/40374
Reviewed-by: Bill Richardson &lt;wfrichar@chromium.org&gt;
Commit-Queue: Randall Spangler &lt;rspangler@chromium.org&gt;
Tested-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Add more recovery_reason codes</title>
<updated>2012-11-26T20:04:42+00:00</updated>
<author>
<name>Bill Richardson</name>
<email>wfrichar@chromium.org</email>
</author>
<published>2012-11-21T23:22:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=640b1c420748049c796b3f9d59406e38ff8f4774'/>
<id>640b1c420748049c796b3f9d59406e38ff8f4774</id>
<content type='text'>
There are several places where the same recovery_reason was used to report
slightly different points of failure. Let's create some new codes instead.

Remember that recovery mode is handled by RO firmware, so if an updated RW
firmware uses one of the new error codes, pressing TAB at the recovery
screen will say "We have no idea what this means". That's not a bug. This CL
deprecates the original codes, so the fact that the RO firmware doesn't
recognize it just means it's a new code reported by a new RW BIOS.

BUG=chromium-os:36562
TEST=manual
BRANCH=parrot

Run

  make &amp;&amp; make runtests

It should pass. You can test some of the error cases on actual hardware by
using

  crossystem recovery_reason=86
  reboot

and pressing TAB at the recovery screen. For that example you should see the
message

  recovery_reason: 0x56 TPM lock error in rewritable firmare

Change-Id: I123c781e6c6f6fe0284c4fd49f5f5a855eece7df
Reviewed-on: https://gerrit.chromium.org/gerrit/38652
Commit-Ready: Bill Richardson &lt;wfrichar@chromium.org&gt;
Tested-by: Bill Richardson &lt;wfrichar@chromium.org&gt;
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
There are several places where the same recovery_reason was used to report
slightly different points of failure. Let's create some new codes instead.

Remember that recovery mode is handled by RO firmware, so if an updated RW
firmware uses one of the new error codes, pressing TAB at the recovery
screen will say "We have no idea what this means". That's not a bug. This CL
deprecates the original codes, so the fact that the RO firmware doesn't
recognize it just means it's a new code reported by a new RW BIOS.

BUG=chromium-os:36562
TEST=manual
BRANCH=parrot

Run

  make &amp;&amp; make runtests

It should pass. You can test some of the error cases on actual hardware by
using

  crossystem recovery_reason=86
  reboot

and pressing TAB at the recovery screen. For that example you should see the
message

  recovery_reason: 0x56 TPM lock error in rewritable firmare

Change-Id: I123c781e6c6f6fe0284c4fd49f5f5a855eece7df
Reviewed-on: https://gerrit.chromium.org/gerrit/38652
Commit-Ready: Bill Richardson &lt;wfrichar@chromium.org&gt;
Tested-by: Bill Richardson &lt;wfrichar@chromium.org&gt;
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>CHROMIUMOS: "flimflam" init file is now named "shill"</title>
<updated>2012-11-07T07:13:33+00:00</updated>
<author>
<name>Paul Stewart</name>
<email>pstew@chromium.org</email>
</author>
<published>2012-10-31T15:47:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=0c69afc5b391ad833fc184eef8423032b9b5705a'/>
<id>0c69afc5b391ad833fc184eef8423032b9b5705a</id>
<content type='text'>
BUG=chromium-os:35909
TEST=None (need suggestions form semenzato)
BRANCH=none

Change-Id: Ife7c545a28fd70407ba2fe1a0a14e20df8e847f7
Reviewed-on: https://gerrit.chromium.org/gerrit/37020
Reviewed-by: Luigi Semenzato &lt;semenzato@chromium.org&gt;
Tested-by: Paul Stewart &lt;pstew@chromium.org&gt;
Commit-Ready: Paul Stewart &lt;pstew@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
BUG=chromium-os:35909
TEST=None (need suggestions form semenzato)
BRANCH=none

Change-Id: Ife7c545a28fd70407ba2fe1a0a14e20df8e847f7
Reviewed-on: https://gerrit.chromium.org/gerrit/37020
Reviewed-by: Luigi Semenzato &lt;semenzato@chromium.org&gt;
Tested-by: Paul Stewart &lt;pstew@chromium.org&gt;
Commit-Ready: Paul Stewart &lt;pstew@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Make cgpt_add error messages a little more verbose</title>
<updated>2012-09-26T19:02:24+00:00</updated>
<author>
<name>Vadim Bendebury</name>
<email>vbendeb@chromium.org</email>
</author>
<published>2012-09-25T00:41:18+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=65d3c277a2098d6149fb79f7881da5d78133ae57'/>
<id>65d3c277a2098d6149fb79f7881da5d78133ae57</id>
<content type='text'>
When the cgpt utility complaints about parameter errors, it is
impossible to tell what exactly went wrong. This change consolidates
error definitions and adds a function to convert integer error values
into text messages.

BRANCH=none
BUG=none
TEST=manual
  . emerge-link vbooot_reference
  . copy generated `cgpt' to a Link device
  . run command with wrong arguments with respect to the existing GPT:
   localhost var # ./cgpt add -i 3 -b 3985408 -s 1757184 -t rootfs -l ROOT-A /dev/sda
   ERROR: cgpt add: Starting LBA overlaps
   ERROR: cgpt add: -i 3 -l ROOT-A -b 3985408 -s 1757184 -t 3CB8E202-3B7E-47DD-8A3C-7FF2A13CFCEC
  . on the host, in the chroot in src/platform/vboot_reference run

   $ make &amp;&amp; make runtests

   observe all tests succeed

Change-Id: Ibd23ca0430a875f70524adc99e0509b26ae699b2
Signed-off-by: Vadim Bendebury &lt;vbendeb@chromium.org&gt;
Reviewed-on: https://gerrit.chromium.org/gerrit/34003
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When the cgpt utility complaints about parameter errors, it is
impossible to tell what exactly went wrong. This change consolidates
error definitions and adds a function to convert integer error values
into text messages.

BRANCH=none
BUG=none
TEST=manual
  . emerge-link vbooot_reference
  . copy generated `cgpt' to a Link device
  . run command with wrong arguments with respect to the existing GPT:
   localhost var # ./cgpt add -i 3 -b 3985408 -s 1757184 -t rootfs -l ROOT-A /dev/sda
   ERROR: cgpt add: Starting LBA overlaps
   ERROR: cgpt add: -i 3 -l ROOT-A -b 3985408 -s 1757184 -t 3CB8E202-3B7E-47DD-8A3C-7FF2A13CFCEC
  . on the host, in the chroot in src/platform/vboot_reference run

   $ make &amp;&amp; make runtests

   observe all tests succeed

Change-Id: Ibd23ca0430a875f70524adc99e0509b26ae699b2
Signed-off-by: Vadim Bendebury &lt;vbendeb@chromium.org&gt;
Reviewed-on: https://gerrit.chromium.org/gerrit/34003
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Add CTRL-L in dev screen to support a "legacy boot option"</title>
<updated>2012-09-21T00:32:22+00:00</updated>
<author>
<name>Stefan Reinauer</name>
<email>reinauer@chromium.org</email>
</author>
<published>2012-08-23T22:06:45+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=a2326ee152ab5b8aee924ccf794cee38d54909bd'/>
<id>a2326ee152ab5b8aee924ccf794cee38d54909bd</id>
<content type='text'>
This option is disabled per default and can be enabled with
crossystem dev_boot_legacy=1
or by setting the GBB flag
GBB_FLAG_FORCE_DEV_BOOT_LEGACY      0x00000080

BUG=chrome-os-partner:6108
TEST=crossystem dev_boot_legacy=1
     boot to dev mode screen, press CTRL-L, see SeaBIOS start
     (other CLs needed)
BRANCH=link
Signed-off-by: Stefan Reinauer &lt;reinauer@chromium.org&gt;

Change-Id: I593d2be7cff5ca07b8d08012c4514a172bd75a38
Reviewed-on: https://gerrit.chromium.org/gerrit/31265
Reviewed-by: Stefan Reinauer &lt;reinauer@chromium.org&gt;
Tested-by: Stefan Reinauer &lt;reinauer@chromium.org&gt;
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Commit-Ready: Stefan Reinauer &lt;reinauer@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This option is disabled per default and can be enabled with
crossystem dev_boot_legacy=1
or by setting the GBB flag
GBB_FLAG_FORCE_DEV_BOOT_LEGACY      0x00000080

BUG=chrome-os-partner:6108
TEST=crossystem dev_boot_legacy=1
     boot to dev mode screen, press CTRL-L, see SeaBIOS start
     (other CLs needed)
BRANCH=link
Signed-off-by: Stefan Reinauer &lt;reinauer@chromium.org&gt;

Change-Id: I593d2be7cff5ca07b8d08012c4514a172bd75a38
Reviewed-on: https://gerrit.chromium.org/gerrit/31265
Reviewed-by: Stefan Reinauer &lt;reinauer@chromium.org&gt;
Tested-by: Stefan Reinauer &lt;reinauer@chromium.org&gt;
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Commit-Ready: Stefan Reinauer &lt;reinauer@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Replace %L with %ll in format strings.</title>
<updated>2012-09-10T03:52:21+00:00</updated>
<author>
<name>Gabe Black</name>
<email>gabeblack@chromium.org</email>
</author>
<published>2012-09-09T07:50:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=172360ec5dc9b5a620d677a985ece05f4e0301bd'/>
<id>172360ec5dc9b5a620d677a985ece05f4e0301bd</id>
<content type='text'>
%L is, in some standard libraries like U-Boot's, a synonym for %ll which is
for long long integers, required by the C99 standard to be at least 64 bits.
For practical purposes that basically means %ll should be used with 64 bit
values. Since %L seems to be non-standard and, at least in U-Boot's case, %ll
is recognized in the same way, %ll seems preferable.

BUG=chrome-os-partner:8339
TEST=Booted ChromeOS using depthcharge and U-Boot. Booted with
depthcharge/libpayload which does not support %L and saw a number where %L had
been printed.
BRANCH=None

Change-Id: Id51fb5c9295e0dd65b42a5c0738eb34c8210a2b2
Signed-off-by: Gabe Black &lt;gabeblack@google.com&gt;
Reviewed-on: https://gerrit.chromium.org/gerrit/32660
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
%L is, in some standard libraries like U-Boot's, a synonym for %ll which is
for long long integers, required by the C99 standard to be at least 64 bits.
For practical purposes that basically means %ll should be used with 64 bit
values. Since %L seems to be non-standard and, at least in U-Boot's case, %ll
is recognized in the same way, %ll seems preferable.

BUG=chrome-os-partner:8339
TEST=Booted ChromeOS using depthcharge and U-Boot. Booted with
depthcharge/libpayload which does not support %L and saw a number where %L had
been printed.
BRANCH=None

Change-Id: Id51fb5c9295e0dd65b42a5c0738eb34c8210a2b2
Signed-off-by: Gabe Black &lt;gabeblack@google.com&gt;
Reviewed-on: https://gerrit.chromium.org/gerrit/32660
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Add VB_INIT_FLAG_SW_WP_ENABLED to VbInit() input flags.</title>
<updated>2012-08-28T23:39:33+00:00</updated>
<author>
<name>Bill Richardson</name>
<email>wfrichar@chromium.org</email>
</author>
<published>2012-08-28T22:00:51+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=9dc62178c97b94e5c308f1c36fd0858c316959e5'/>
<id>9dc62178c97b94e5c308f1c36fd0858c316959e5</id>
<content type='text'>
We need to know not only whether the HW WP pin is asserted, but whether the
flash chip has configured its software protection registers to actually
protect anything. This flag can be used to indicate that.

BUG=chrome-os-partner:13265
BRANCH=link
TEST=none

This just adds the flag. Nothing actually sets the flag yet, so there's
nothing to test.

Change-Id: Icba9945fb56eb3a4681486c630cbbdc9232485ef
Signed-off-by: Bill Richardson &lt;wfrichar@chromium.org&gt;
Reviewed-on: https://gerrit.chromium.org/gerrit/31642
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We need to know not only whether the HW WP pin is asserted, but whether the
flash chip has configured its software protection registers to actually
protect anything. This flag can be used to indicate that.

BUG=chrome-os-partner:13265
BRANCH=link
TEST=none

This just adds the flag. Nothing actually sets the flag yet, so there's
nothing to test.

Change-Id: Icba9945fb56eb3a4681486c630cbbdc9232485ef
Signed-off-by: Bill Richardson &lt;wfrichar@chromium.org&gt;
Reviewed-on: https://gerrit.chromium.org/gerrit/31642
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>cgpt: Fix error in modifying size of an existing partition</title>
<updated>2012-08-25T03:43:28+00:00</updated>
<author>
<name>Bill Richardson</name>
<email>wfrichar@chromium.org</email>
</author>
<published>2012-08-25T00:52:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=da77e6953c96f9bb52a04dc32b337066144879aa'/>
<id>da77e6953c96f9bb52a04dc32b337066144879aa</id>
<content type='text'>
Modifying the size of an existing partition without modifying the start as
well assumed the start was at block 0. Sometimes it was caught, often it
wasn't.

Fix the error, add a test to catch the problem.

BUG=chrome-os-partner:13090
BRANCH=all
TEST=manual

make &amp;&amp; make runtests

Change-Id: I4f5a5031a90a3e78d886ed3573f61305316a3f1f
Signed-off-by: Bill Richardson &lt;wfrichar@chromium.org&gt;
Reviewed-on: https://gerrit.chromium.org/gerrit/31418
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Modifying the size of an existing partition without modifying the start as
well assumed the start was at block 0. Sometimes it was caught, often it
wasn't.

Fix the error, add a test to catch the problem.

BUG=chrome-os-partner:13090
BRANCH=all
TEST=manual

make &amp;&amp; make runtests

Change-Id: I4f5a5031a90a3e78d886ed3573f61305316a3f1f
Signed-off-by: Bill Richardson &lt;wfrichar@chromium.org&gt;
Reviewed-on: https://gerrit.chromium.org/gerrit/31418
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Rename $GPT as $CGPT, just for clarity.</title>
<updated>2012-08-25T03:43:27+00:00</updated>
<author>
<name>Bill Richardson</name>
<email>wfrichar@chromium.org</email>
</author>
<published>2012-08-24T21:39:21+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=263ffdfdd710a33a2a12ee33179f088292b2864f'/>
<id>263ffdfdd710a33a2a12ee33179f088292b2864f</id>
<content type='text'>
I'm about to add a new test to fix some borkage with cgpt. First step is to
clean up the script a little bit.

BUG=none (yet)
BRANCH=all
TEST=manual

make &amp;&amp; make runtests

Change-Id: I2311b5eb20aff80c4a0435cf1d10331c679af3c0
Signed-off-by: Bill Richardson &lt;wfrichar@chromium.org&gt;
Reviewed-on: https://gerrit.chromium.org/gerrit/31379
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
I'm about to add a new test to fix some borkage with cgpt. First step is to
clean up the script a little bit.

BUG=none (yet)
BRANCH=all
TEST=manual

make &amp;&amp; make runtests

Change-Id: I2311b5eb20aff80c4a0435cf1d10331c679af3c0
Signed-off-by: Bill Richardson &lt;wfrichar@chromium.org&gt;
Reviewed-on: https://gerrit.chromium.org/gerrit/31379
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix broken bitmap tests</title>
<updated>2012-08-25T03:43:27+00:00</updated>
<author>
<name>Bill Richardson</name>
<email>wfrichar@chromium.org</email>
</author>
<published>2012-08-24T21:13:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=2e70c1226a511b9e331f2e9ef6226c2c9920cef4'/>
<id>2e70c1226a511b9e331f2e9ef6226c2c9920cef4</id>
<content type='text'>
When we changed the bmpblk version from 1.2 to 2.0, the tests weren't
updated.

BUG=chrome-os-partner:11078
BRANCH=all
TEST=manual

make &amp;&amp; make runtests

Change-Id: I244a9aeeb34be912fe6058687394c37d0e474890
Signed-off-by: Bill Richardson &lt;wfrichar@chromium.org&gt;
Reviewed-on: https://gerrit.chromium.org/gerrit/31377
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When we changed the bmpblk version from 1.2 to 2.0, the tests weren't
updated.

BUG=chrome-os-partner:11078
BRANCH=all
TEST=manual

make &amp;&amp; make runtests

Change-Id: I244a9aeeb34be912fe6058687394c37d0e474890
Signed-off-by: Bill Richardson &lt;wfrichar@chromium.org&gt;
Reviewed-on: https://gerrit.chromium.org/gerrit/31377
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
</pre>
</div>
</content>
</entry>
</feed>
