<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/coreboot/vboot.git/scripts, branch release-R114-15437.B</title>
<subtitle>review.coreboot.org: vboot.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/'/>
<entry>
<title>scripts: Support compressed about_os_credits.html.</title>
<updated>2023-04-25T00:20:57+00:00</updated>
<author>
<name>Miriam Zimmerman</name>
<email>mutexlox@google.com</email>
</author>
<published>2023-04-24T15:18:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=f5dcda11682c6f3ad267b73673946d425bb70fd9'/>
<id>f5dcda11682c6f3ad267b73673946d425bb70fd9</id>
<content type='text'>
BUG=b:187790036
BRANCH=none
TEST=ensure_not_tainted_license.sh /path/to/chromiumos_test_image.bin

Signed-off-by: Miriam Zimmerman &lt;mutexlox@google.com&gt;
Change-Id: Id3ad6535b1bc9635050d467208614f97e0aeca35
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4467627
Commit-Queue: Miriam Zimmerman &lt;mutexlox@chromium.org&gt;
Tested-by: Miriam Zimmerman &lt;mutexlox@chromium.org&gt;
Reviewed-by: Mike Frysinger &lt;vapier@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
BUG=b:187790036
BRANCH=none
TEST=ensure_not_tainted_license.sh /path/to/chromiumos_test_image.bin

Signed-off-by: Miriam Zimmerman &lt;mutexlox@google.com&gt;
Change-Id: Id3ad6535b1bc9635050d467208614f97e0aeca35
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4467627
Commit-Queue: Miriam Zimmerman &lt;mutexlox@chromium.org&gt;
Tested-by: Miriam Zimmerman &lt;mutexlox@chromium.org&gt;
Reviewed-by: Mike Frysinger &lt;vapier@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>sign_official_build: Add support for a second miniOS key</title>
<updated>2023-04-21T10:41:09+00:00</updated>
<author>
<name>Reka Norman</name>
<email>rekanorman@google.com</email>
</author>
<published>2023-04-20T05:50:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=350498f03a000e43a2a39100c7722997ba0db074'/>
<id>350498f03a000e43a2a39100c7722997ba0db074</id>
<content type='text'>
For recovery images, if minios_kernel.v1.keyblock exists, sign
- MINIOS-A with minios_kernel.v1.keyblock
- MINIOS-B with minios_kernel.keyblock
Otherwise, sign both with minios_kernel.keyblock.

BRANCH=None
BUG=b:266502803
TEST=- Run replace_recovery_key.sh in devkeys directory to get test keys
- Run sign_official_build.sh on a nissa recovery image
- Set recovery_key.v1.vbpubk in GBB and run recovery. After recovery
  completes, check NBR still works.
- Repeat with recovery_key.vbpubk.

Change-Id: I2336e5261ef24114c5fee302ed95b4dfa1f67c11
Signed-off-by: Reka Norman &lt;rekanorman@google.com&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4452079
Tested-by: Reka Norman &lt;rekanorman@chromium.org&gt;
Commit-Queue: Reka Norman &lt;rekanorman@chromium.org&gt;
Reviewed-by: Julius Werner &lt;jwerner@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
For recovery images, if minios_kernel.v1.keyblock exists, sign
- MINIOS-A with minios_kernel.v1.keyblock
- MINIOS-B with minios_kernel.keyblock
Otherwise, sign both with minios_kernel.keyblock.

BRANCH=None
BUG=b:266502803
TEST=- Run replace_recovery_key.sh in devkeys directory to get test keys
- Run sign_official_build.sh on a nissa recovery image
- Set recovery_key.v1.vbpubk in GBB and run recovery. After recovery
  completes, check NBR still works.
- Repeat with recovery_key.vbpubk.

Change-Id: I2336e5261ef24114c5fee302ed95b4dfa1f67c11
Signed-off-by: Reka Norman &lt;rekanorman@google.com&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4452079
Tested-by: Reka Norman &lt;rekanorman@chromium.org&gt;
Commit-Queue: Reka Norman &lt;rekanorman@chromium.org&gt;
Reviewed-by: Julius Werner &lt;jwerner@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>sign_official_build: Fix is-reven check</title>
<updated>2023-03-23T16:43:02+00:00</updated>
<author>
<name>Nicholas Bishop</name>
<email>nicholasbishop@google.com</email>
</author>
<published>2023-03-21T22:24:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=d5b59cc7ec723ae10161cfffd1c3a70a8caabe08'/>
<id>d5b59cc7ec723ae10161cfffd1c3a70a8caabe08</id>
<content type='text'>
The `get_is_reven` function added in https://crrev.com/c/4206907 was too
restrictive. When run by the signer, the board name has been modified
from "reven" to "reven-signed-mp-v2keys". Change the condition to accept
either `reven` or `reven-signed*` (note the glob). Allowing plain
"reven" is not strictly necessary, but useful for local testing.

Tested the updated function by building a reven base image, then making
variants with different CHROMEOS_RELEASE_BOARD values: "reven",
"reven-signed-mp-v2keys", and "revenator". Running
`sign_official_build.sh` on them shows that the first two are identified
as reven, and the last one is not. This can be seen by checking if
boot*.efi is signed or not, since that should not happen for reven.

BRANCH=none
BUG=b:274648121
TEST=See above
TEST=FEATURES=test emerge-reven vboot_reference

Change-Id: I099abf372b71ea3e064e91a57c5e8888de298028
Signed-off-by: Nicholas Bishop &lt;nicholasbishop@google.com&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4358400
Reviewed-by: Mike Frysinger &lt;vapier@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The `get_is_reven` function added in https://crrev.com/c/4206907 was too
restrictive. When run by the signer, the board name has been modified
from "reven" to "reven-signed-mp-v2keys". Change the condition to accept
either `reven` or `reven-signed*` (note the glob). Allowing plain
"reven" is not strictly necessary, but useful for local testing.

Tested the updated function by building a reven base image, then making
variants with different CHROMEOS_RELEASE_BOARD values: "reven",
"reven-signed-mp-v2keys", and "revenator". Running
`sign_official_build.sh` on them shows that the first two are identified
as reven, and the last one is not. This can be seen by checking if
boot*.efi is signed or not, since that should not happen for reven.

BRANCH=none
BUG=b:274648121
TEST=See above
TEST=FEATURES=test emerge-reven vboot_reference

Change-Id: I099abf372b71ea3e064e91a57c5e8888de298028
Signed-off-by: Nicholas Bishop &lt;nicholasbishop@google.com&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4358400
Reviewed-by: Mike Frysinger &lt;vapier@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>sign_official_build: Don't sign miniOS kernels in factory shims</title>
<updated>2023-03-09T07:08:43+00:00</updated>
<author>
<name>Reka Norman</name>
<email>rekanorman@google.com</email>
</author>
<published>2023-03-03T00:39:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=83315261e69bec0f2a1a4c9de8317ba0c9c84975'/>
<id>83315261e69bec0f2a1a4c9de8317ba0c9c84975</id>
<content type='text'>
Factory shims contain miniOS kernels, but they are not used, so don't
sign them. They will remain in the image signed with dev keys.

BRANCH=None
BUG=None
TEST=Run sign_official_build.sh on factory shim. Logs show miniOS
kernels are not signed, and shim still boots.

Change-Id: I4a1b72726edb7d780a3f2c2fe783f568a012ee77
Signed-off-by: Reka Norman &lt;rekanorman@google.com&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4321706
Tested-by: Reka Norman &lt;rekanorman@chromium.org&gt;
Reviewed-by: Julius Werner &lt;jwerner@chromium.org&gt;
Commit-Queue: Reka Norman &lt;rekanorman@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Factory shims contain miniOS kernels, but they are not used, so don't
sign them. They will remain in the image signed with dev keys.

BRANCH=None
BUG=None
TEST=Run sign_official_build.sh on factory shim. Logs show miniOS
kernels are not signed, and shim still boots.

Change-Id: I4a1b72726edb7d780a3f2c2fe783f568a012ee77
Signed-off-by: Reka Norman &lt;rekanorman@google.com&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4321706
Tested-by: Reka Norman &lt;rekanorman@chromium.org&gt;
Reviewed-by: Julius Werner &lt;jwerner@chromium.org&gt;
Commit-Queue: Reka Norman &lt;rekanorman@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>sign_official_build: Support a second recovery key</title>
<updated>2023-03-08T03:25:08+00:00</updated>
<author>
<name>Reka Norman</name>
<email>rekanorman@google.com</email>
</author>
<published>2023-02-06T02:54:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=d0c79c0a28fc6ea315269e183f8cd65c389a2369'/>
<id>d0c79c0a28fc6ea315269e183f8cd65c389a2369</id>
<content type='text'>
Some devices have a second recovery key, which is used to sign:
- a second recovery kernel KERN-C in recovery images
- a second installer kernel KERN-B in factory images

If a device has a second recovery key, use it to sign the second
recovery and installer kernels. Otherwise, don't sign the second
kernels. If they are present, they'll remain in the image signed with
dev keys.

BRANCH=None
BUG=b:266502803
TEST=- Run replace_recovery_key.sh in devkeys directory to get keys for
testing.
- Run sign_official_build.sh on a recovery image with KERN-C present.
- Set recovery_key.vbpubk in GBB - recovery succeeds using KERN-A.
- Set recovery_key.v1.vbpubk in GBB - recovery succeeds using KERN-C.
- Run sign_official_build.sh on a factory shim with KERN-B present.
- Set recovery_key.vbpubk in GBB - factory shim boots using KERN-A.
- Set recovery_key.v1.vbpubk in GBB - factory shim boots using KERN-B.
- Run sign_official_build.sh on a base image and check it boots.

Change-Id: I39b209e1efd4669128a12751f1c4ee94bb722d67
Signed-off-by: Reka Norman &lt;rekanorman@google.com&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4242686
Reviewed-by: Mike Frysinger &lt;vapier@chromium.org&gt;
Commit-Queue: Reka Norman &lt;rekanorman@chromium.org&gt;
Tested-by: Reka Norman &lt;rekanorman@chromium.org&gt;
Reviewed-by: Julius Werner &lt;jwerner@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Some devices have a second recovery key, which is used to sign:
- a second recovery kernel KERN-C in recovery images
- a second installer kernel KERN-B in factory images

If a device has a second recovery key, use it to sign the second
recovery and installer kernels. Otherwise, don't sign the second
kernels. If they are present, they'll remain in the image signed with
dev keys.

BRANCH=None
BUG=b:266502803
TEST=- Run replace_recovery_key.sh in devkeys directory to get keys for
testing.
- Run sign_official_build.sh on a recovery image with KERN-C present.
- Set recovery_key.vbpubk in GBB - recovery succeeds using KERN-A.
- Set recovery_key.v1.vbpubk in GBB - recovery succeeds using KERN-C.
- Run sign_official_build.sh on a factory shim with KERN-B present.
- Set recovery_key.vbpubk in GBB - factory shim boots using KERN-A.
- Set recovery_key.v1.vbpubk in GBB - factory shim boots using KERN-B.
- Run sign_official_build.sh on a base image and check it boots.

Change-Id: I39b209e1efd4669128a12751f1c4ee94bb722d67
Signed-off-by: Reka Norman &lt;rekanorman@google.com&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4242686
Reviewed-by: Mike Frysinger &lt;vapier@chromium.org&gt;
Commit-Queue: Reka Norman &lt;rekanorman@chromium.org&gt;
Tested-by: Reka Norman &lt;rekanorman@chromium.org&gt;
Reviewed-by: Julius Werner &lt;jwerner@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>scripts/../{g,s}et_gbb_flags.sh: Add delay</title>
<updated>2023-03-03T12:35:52+00:00</updated>
<author>
<name>Edward O'Callaghan</name>
<email>quasisec@google.com</email>
</author>
<published>2023-02-18T04:53:37+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=b12ad28df8b2f2afa03bf8c95d23a8de5ebe715c'/>
<id>b12ad28df8b2f2afa03bf8c95d23a8de5ebe715c</id>
<content type='text'>
Give some time to the user to reconsider and ween users off a
unsupported ABI.

BUG=b:260531154
TEST=none

Change-Id: I9cfbd032f56d7aa3ba1f19abdd26c15a785cc876
Signed-off-by: Edward O'Callaghan &lt;quasisec@google.com&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4269751
Auto-Submit: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
Commit-Queue: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
Reviewed-by: Otabek Kasimov &lt;otabek@google.com&gt;
Reviewed-by: Hung-Te Lin &lt;hungte@chromium.org&gt;
Tested-by: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
Reviewed-by: Yu-Ping Wu &lt;yupingso@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Give some time to the user to reconsider and ween users off a
unsupported ABI.

BUG=b:260531154
TEST=none

Change-Id: I9cfbd032f56d7aa3ba1f19abdd26c15a785cc876
Signed-off-by: Edward O'Callaghan &lt;quasisec@google.com&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4269751
Auto-Submit: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
Commit-Queue: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
Reviewed-by: Otabek Kasimov &lt;otabek@google.com&gt;
Reviewed-by: Hung-Te Lin &lt;hungte@chromium.org&gt;
Tested-by: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
Reviewed-by: Yu-Ping Wu &lt;yupingso@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>sign_uefi: Add support for crdyboot</title>
<updated>2023-03-02T06:24:27+00:00</updated>
<author>
<name>Nicholas Bishop</name>
<email>nicholasbishop@google.com</email>
</author>
<published>2023-02-14T21:29:22+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=10a052e3bb8d3a2a5a6eaef1c461e8d593a426a8'/>
<id>10a052e3bb8d3a2a5a6eaef1c461e8d593a426a8</id>
<content type='text'>
The crdyboot bootloader (see
https://chromium.googlesource.com/chromiumos/platform/crdyboot) for the
reven board requires some additional handling for signing:
* A public key for verifying the kernel must be injected into the
  `.vbpubk` section.
* Then the file must be signed with `sbsign` in the usual way.

Testing commands:
```
scripts/keygeneration/make_arv_root.sh arv
scripts/keygeneration/create_new_keys.sh \
    --arv-root-path arv --uefi --output reven

scripts/image_signing/sign_official_build.sh recovery \
    ~/chromiumos/src/build/images/reven/latest/chromiumos_image.bin \
    reven \
    ~/chromiumos/src/build/images/reven/latest/chromiumos_image.signed

Then boot the image in a UEFI VM.
```

BRANCH=none
BUG=b:256176281
TEST=make runtests
TEST=See testing notes above

Change-Id: Id454ff0677c397b2c399f39981862ac18c2c9985
Signed-off-by: Nicholas Bishop &lt;nicholasbishop@google.com&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4250562
Reviewed-by: Mike Frysinger &lt;vapier@chromium.org&gt;
Commit-Queue: Mike Frysinger &lt;vapier@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The crdyboot bootloader (see
https://chromium.googlesource.com/chromiumos/platform/crdyboot) for the
reven board requires some additional handling for signing:
* A public key for verifying the kernel must be injected into the
  `.vbpubk` section.
* Then the file must be signed with `sbsign` in the usual way.

Testing commands:
```
scripts/keygeneration/make_arv_root.sh arv
scripts/keygeneration/create_new_keys.sh \
    --arv-root-path arv --uefi --output reven

scripts/image_signing/sign_official_build.sh recovery \
    ~/chromiumos/src/build/images/reven/latest/chromiumos_image.bin \
    reven \
    ~/chromiumos/src/build/images/reven/latest/chromiumos_image.signed

Then boot the image in a UEFI VM.
```

BRANCH=none
BUG=b:256176281
TEST=make runtests
TEST=See testing notes above

Change-Id: Id454ff0677c397b2c399f39981862ac18c2c9985
Signed-off-by: Nicholas Bishop &lt;nicholasbishop@google.com&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4250562
Reviewed-by: Mike Frysinger &lt;vapier@chromium.org&gt;
Commit-Queue: Mike Frysinger &lt;vapier@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>scripts/image_signing/make_dev_ssd.sh: Replace flashrom call</title>
<updated>2023-02-24T09:11:05+00:00</updated>
<author>
<name>Edward O'Callaghan</name>
<email>quasisec@google.com</email>
</author>
<published>2023-02-08T04:26:47+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=e95815646eef6d58fe197f2f8ec95a69905e4b3e'/>
<id>e95815646eef6d58fe197f2f8ec95a69905e4b3e</id>
<content type='text'>
Just use futility directly.

BUG=b:260531154
TEST=```
localhost ~ # futility gbb -g --flash --rootkey=/tmp/rkey &gt;/dev/null 2&gt;&amp;1
localhost ~ # od /tmp/rkey | head -130 | md5sum | sed 's/ .*$//'
a13642246ef93daaf75bd791446fec9b
```

Change-Id: I1aa3b52f568a5e78255b52a15d68258cc9d9aa44
Signed-off-by: Edward O'Callaghan &lt;quasisec@google.com&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4269750
Reviewed-by: Yu-Ping Wu &lt;yupingso@chromium.org&gt;
Commit-Queue: Yu-Ping Wu &lt;yupingso@chromium.org&gt;
Tested-by: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
Reviewed-by: Sam McNally &lt;sammc@chromium.org&gt;
Auto-Submit: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Just use futility directly.

BUG=b:260531154
TEST=```
localhost ~ # futility gbb -g --flash --rootkey=/tmp/rkey &gt;/dev/null 2&gt;&amp;1
localhost ~ # od /tmp/rkey | head -130 | md5sum | sed 's/ .*$//'
a13642246ef93daaf75bd791446fec9b
```

Change-Id: I1aa3b52f568a5e78255b52a15d68258cc9d9aa44
Signed-off-by: Edward O'Callaghan &lt;quasisec@google.com&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4269750
Reviewed-by: Yu-Ping Wu &lt;yupingso@chromium.org&gt;
Commit-Queue: Yu-Ping Wu &lt;yupingso@chromium.org&gt;
Tested-by: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
Reviewed-by: Sam McNally &lt;sammc@chromium.org&gt;
Auto-Submit: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>{g,s}et_gbb_flags.sh: Fix removal notice message</title>
<updated>2023-02-16T09:14:24+00:00</updated>
<author>
<name>Yu-Ping Wu</name>
<email>yupingso@chromium.org</email>
</author>
<published>2023-02-15T04:39:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=59fd26b77fd66efcfc2beceda9eaafba0e74ec3e'/>
<id>59fd26b77fd66efcfc2beceda9eaafba0e74ec3e</id>
<content type='text'>
Fix the futility command in the removal notice message, by adding the
missing `--flash` option.

BUG=b:260531154
TEST=Ran set_gbb_flags.sh
BRANCH=none

Change-Id: Ic1846929661a47c40b65e67ea76f776493ee2d9c
Signed-off-by: Yu-Ping Wu &lt;yupingso@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4251505
Reviewed-by: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
Commit-Queue: Matthew Blecker &lt;matthewb@chromium.org&gt;
Reviewed-by: Matthew Blecker &lt;matthewb@chromium.org&gt;
Reviewed-by: Alexandru Stan &lt;amstan@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix the futility command in the removal notice message, by adding the
missing `--flash` option.

BUG=b:260531154
TEST=Ran set_gbb_flags.sh
BRANCH=none

Change-Id: Ic1846929661a47c40b65e67ea76f776493ee2d9c
Signed-off-by: Yu-Ping Wu &lt;yupingso@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4251505
Reviewed-by: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
Commit-Queue: Matthew Blecker &lt;matthewb@chromium.org&gt;
Reviewed-by: Matthew Blecker &lt;matthewb@chromium.org&gt;
Reviewed-by: Alexandru Stan &lt;amstan@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>sign_official_build: Silence shellcheck sed lints</title>
<updated>2023-02-14T09:00:14+00:00</updated>
<author>
<name>Nicholas Bishop</name>
<email>nicholasbishop@google.com</email>
</author>
<published>2023-02-13T19:22:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=83feacdcc05c1e2ebd56a20ccea008be49144aee'/>
<id>83feacdcc05c1e2ebd56a20ccea008be49144aee</id>
<content type='text'>
Silence all current instances of "SC2001 (style): See if you can use
${variable//search/replace} instead." Replacing complicated `sed` calls
without tests in place would likely lead to mistakes, so leave them
alone for now. The lint is not disabled globally though, so new uses can
still be flagged.

BRANCH=none
BUG=None
TEST=cros lint scripts/image_signing/sign_official_build.sh
TEST=scripts/image_signing/sign_official_build.sh recovery \
TEST=  ~/chromiumos/src/build/images/reven/latest/chromiumos_image.bin
TEST=  tests/devkeys
TEST=  ~/chromiumos/src/build/images/reven/latest/chromiumos_image.signed

Change-Id: I228e78033f891ee09db40b937b4d7a7750de8c18
Signed-off-by: Nicholas Bishop &lt;nicholasbishop@google.com&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4245621
Reviewed-by: Mike Frysinger &lt;vapier@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Silence all current instances of "SC2001 (style): See if you can use
${variable//search/replace} instead." Replacing complicated `sed` calls
without tests in place would likely lead to mistakes, so leave them
alone for now. The lint is not disabled globally though, so new uses can
still be flagged.

BRANCH=none
BUG=None
TEST=cros lint scripts/image_signing/sign_official_build.sh
TEST=scripts/image_signing/sign_official_build.sh recovery \
TEST=  ~/chromiumos/src/build/images/reven/latest/chromiumos_image.bin
TEST=  tests/devkeys
TEST=  ~/chromiumos/src/build/images/reven/latest/chromiumos_image.signed

Change-Id: I228e78033f891ee09db40b937b4d7a7750de8c18
Signed-off-by: Nicholas Bishop &lt;nicholasbishop@google.com&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4245621
Reviewed-by: Mike Frysinger &lt;vapier@chromium.org&gt;
</pre>
</div>
</content>
</entry>
</feed>
