delta/coreboot/vboot.git/host, branch stabilize-15317.B

futility/flashrom_drv: Add new skip perm flags

2023-01-06T23:27:51+00:00

flashrom now respects region permissions rather than ignoring
exit codes. While downstreaming this support we require these
flags to be set to ensure no change in behavior for futility.

BUG=b:260440773
BRANCH=none
TEST=builds

Signed-off-by: Edward O'Callaghan 
Change-Id: Id54164385d24b3a9f2bf1da8490baf05c4728cf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4127324
Commit-Queue: Edward O'Callaghan 
Reviewed-by: Yu-Ping Wu 
Tested-by: Edward O'Callaghan 
Auto-Submit: Edward O'Callaghan

crossystem: Print an error log if we fall back to WPSW_BOOT

2022-12-15T03:53:19+00:00

On new systems, WPSW_BOOT is potentially bogus. The BIOS doesn't set
it so it always reports that the device is _not_ write protected.

Let's print an error log so we have an idea if we ever fall back.

BRANCH=None
BUG=b:249498455, b:254337014
TEST=Force a failure and see the log

Change-Id: Ie741ca9f9f938382ea7e56cfd81bd273dd9bb548
Signed-off-by: Douglas Anderson 
Disallow-Recycled-Builds: test-failures
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4104708
Reviewed-by: Hung-Te Lin 
Reviewed-by: Brian Norris

Reland "crossystem: Add board_id property"

2022-11-23T09:30:27+00:00

This reverts commit 87663c3bef0f6b198945cf3eb83632f461a5d6f8.

The parent CL to this commit should be sufficient to resolve the
failure that prevented "crossystem board_id" on ARM from working.

Original change's description:
> crossystem: Add board_id property
>
> futility is one of a few places in ChromeOS that uses "mosys platform
> version".  The goal is to remove this command from mosys.
>
> This commit adds a new property to crossystem, "board_id", which
> reads the board revision from SMBIOS/FDT, and replaces the call in
> futility with the appropriate VbGetSystemPropertyInt.
>
> BUG=b:187790074
> BRANCH=none
> TEST="crossystem board_id" on hana and brya
>
> Change-Id: Id69c8e309c0e509a165aa6da2778573ac7de3455
> Signed-off-by: Jack Rosenthal 
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4029537
> Reviewed-by: Julius Werner 

BUG=b:187790074
BRANCH=none
TEST="crossystem board_id" on hana and brya

Change-Id: I37b4c622e3c1d294b5be8e0d98ef14175902acc3
Signed-off-by: Jack Rosenthal 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4045047
Reviewed-by: Julius Werner

crossystem: arm: Make FDT_BASE_PATH /proc/device-tree

2022-11-23T09:30:25+00:00

Hard-coding to /proc/device-tree/firmware/chromeos won't let us read
device-tree properties outside of /firmware/chromeos.

The follow-on CL reads from /firmware/coreboot.

BUG=b:187790074
BRANCH=none
TEST=CQ passes

Change-Id: I752aa5a1e20db1dad7f2508852c7a1c982a4bcb4
Signed-off-by: Jack Rosenthal 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4045046
Reviewed-by: Julius Werner

Revert "crossystem: Add board_id property"

2022-11-19T04:37:50+00:00

This reverts commit db1b34f559fdbf5584b57007da43e4dddda43c6a.

Reason for revert: seems to break scarlet - b/259702907

Original change's description:
> crossystem: Add board_id property
>
> futility is one of a few places in ChromeOS that uses "mosys platform
> version".  The goal is to remove this command from mosys.
>
> This commit adds a new property to crossystem, "board_id", which
> reads the board revision from SMBIOS/FDT, and replaces the call in
> futility with the appropriate VbGetSystemPropertyInt.
>
> BUG=b:187790074
> BRANCH=none
> TEST="crossystem board_id" on hana and brya
>
> Change-Id: Id69c8e309c0e509a165aa6da2778573ac7de3455
> Signed-off-by: Jack Rosenthal 
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4029537
> Reviewed-by: Julius Werner 

Bug: b:187790074, b:259702907
Change-Id: Ibdc2525d6f395e2ef63354d36ca02b71543e8079
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4038443
Commit-Queue: Jack Rosenthal 
Tested-by: Jack Rosenthal 
Commit-Queue: Brian Norris 
Reviewed-by: Jack Rosenthal 
Owners-Override: Jack Rosenthal

host/lib/cbfstool: Fix cbfs verification validity check

2022-11-17T19:39:21+00:00

cbfstool uses tab instead of space, and because of that current
code does not work correctly with metadata hash images. Changing
space to tab in pattern fixes the issue.

BRANCH=none
BUG=b:259153966,b:197114807
TEST=build bootimage for volteer/voxel

Signed-off-by: Jakub Czapiga 
Change-Id: Iab6ab56927a6bea9275eda4a5bad1ad73b779a69
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4030402
Commit-Queue: Jakub Czapiga 
Tested-by: Jakub Czapiga 
Reviewed-by: Yu-Ping Wu

crossystem: Add board_id property

2022-11-17T14:56:10+00:00

futility is one of a few places in ChromeOS that uses "mosys platform
version".  The goal is to remove this command from mosys.

This commit adds a new property to crossystem, "board_id", which
reads the board revision from SMBIOS/FDT, and replaces the call in
futility with the appropriate VbGetSystemPropertyInt.

BUG=b:187790074
BRANCH=none
TEST="crossystem board_id" on hana and brya

Change-Id: Id69c8e309c0e509a165aa6da2778573ac7de3455
Signed-off-by: Jack Rosenthal 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4029537
Reviewed-by: Julius Werner

host/lib: Add flashrom_read_region() to read just the requested region

2022-11-17T09:24:43+00:00

The region parameter to flashrom_read_image() is essentially unusable in
isolation since it reads just the requested region into a buffer sized
to the entire flash, at the offset of the region within the flash.

Remove its unused region parameter and split the functionality of
requesting a region into flashrom_read_region() which stores just the
requested region into a buffer sized to the region.

BUG=b:253966060
TEST=futility update --detect-model -a  works as expected
BRANCH=None

Signed-off-by: Sam McNally 
Change-Id: Ibf6c152dd42fbc99c1742fb077bc6aa35feeed08
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3965583
Reviewed-by: Edward O'Callaghan 
Reviewed-by: Yu-Ping Wu

crossystem: arm: Retry if we fail to read a GPIO

2022-10-20T02:42:18+00:00

It turns out that if two processes try to read the same GPIO at the
same time that one of them will fail because the GPIO is
"busy".

This is really by design of the kernel's GPIO API. In order to read a
value, each userspace process "requests" control of the GPIO and then
queries it. There doesn't appear to be any way to "wait" for a GPIO
that's been requested by someone else--we just need to wait a bit and
try again later. ...so that's what we'll do.

Without this patch, if you run the following script on a
write-protected sc7180-trogdor class device in two shells at the same
time:

  old_val=""
  while true; do
    val=$(crossystem wpsw_cur)
    if [[ "${val}" != "${old_val}" ]]; then
      echo "$(date): ${old_val} => ${val}"
      old_val="${val}"
    fi
  done

Then you'll see stuff like this:

  GPIO_GET_LINEHANDLE_IOCTL: Device or resource busy
  Tue Oct 18 11:34:01 PDT 2022: 1 => 0
  Tue Oct 18 11:34:01 PDT 2022: 0 => 1
  GPIO_GET_LINEHANDLE_IOCTL: Device or resource busy
  Tue Oct 18 11:34:01 PDT 2022: 1 => 0
  Tue Oct 18 11:34:01 PDT 2022: 0 => 1

The 0 actually comes from the fact that crossystem falls back to
`GetVdatInt(VDAT_INT_HW_WPSW_BOOT)` if it fails to read the GPIO and
that value isn't initted to anything on trogdor (VDAT_INT_HW_WPSW_BOOT
is deprecated and not populated on trogdor).

It is postulated that the above problem is causing some parts of the
system to get confused about the write protect state of devices.

BRANCH=none
BUG=b:249498455
TEST=Run script in CL commit message and see no errors

Change-Id: I307cdb4e290c27694690a19af60f4697ee0233e4
Signed-off-by: Douglas Anderson 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3963985
Reviewed-by: Brian Norris 
Reviewed-by: Julius Werner 
Commit-Queue: Julius Werner

firmware: host: futility: Add CBFS metadata hash support

2022-10-12T17:41:55+00:00

This patch adds support for signing and verification of coreboot images
supporting VBOOT_CBFS_INTEGRATION. Images with config option
CONFIG_VBOOT_CBFS_INTEGRATION=y will be signed with CBFS metadata hash
in signature. vb2api_get_metadata_hash() should be used to extract hash
value from VBLOCK and then should be used to verify CBFS metadata.
To support full verification, CBFS file data verification should also be
enabled and correctly handled.

BUG=b:197114807
TEST=build with CB:66909 and boot on volteer/voxel with
     CONFIG_VBOOT_CBFS_INTEGRATION=y
BRANCH=none

Signed-off-by: Jakub Czapiga 
Change-Id: I4075c84820949be24c423ed14e291c89a0032863
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3811754
Commit-Queue: Julius Werner 
Reviewed-by: Julius Werner 
Reviewed-by: Yu-Ping Wu