delta/coreboot/vboot.git/host, branch stabilize-12441.B

vboot: update vboot2 functions to use new vb2_error_t

2019-08-13T04:36:52+00:00

To make explicit when vboot2 error codes should be returned,
use the new vb2_error_t type on all functions which return
VB2_ERROR_* constants.

BUG=b:124141368, chromium:988410
TEST=make clean && make runtests
BRANCH=none

Change-Id: Idd3ee8afe8c78347783ce5fa829cb78f1e5719e2
Signed-off-by: Joel Kitching 
Cq-Depend: chromium:1728113, chromium:1728499
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1728292
Reviewed-by: Joel Kitching 
Commit-Queue: Joel Kitching 
Tested-by: Joel Kitching

vboot: deprecate VbExError function

2019-07-24T06:53:41+00:00

Convert uses of this function to call VB2_DEBUG and manually
exit if necessary.

BUG=b:124141368
TEST=make clean && make runtests
BRANCH=none

Change-Id: I9006b1a9c66645757d33310d96207233b88eaed5
Signed-off-by: Joel Kitching 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1710340
Tested-by: Joel Kitching 
Reviewed-by: Julius Werner 
Commit-Queue: Joel Kitching

vboot: remove vboot1 version of ARRAY_SIZE macro

2019-06-26T14:24:47+00:00

Macro already exists in vboot2-style 2common.h.
Relocate tests accordingly.

BUG=b:124141368
TEST=make clean && make runtests
BRANCH=none

Change-Id: I6b96627a05e8c05ff49b8780fe4472890c2a2043
Signed-off-by: Joel Kitching 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1675869
Reviewed-by: Joel Kitching 
Tested-by: Joel Kitching 
Commit-Queue: Joel Kitching

vboot: move vb2_packed_key and several functions from lib20 to 2lib

2019-06-07T07:21:09+00:00

* Move vb2_packed_key from vb2_struct.h to 2struct.h
* Move vb2_verify_member_inside from lib20/common.c to 2common.c
* Move vb2_packed_key_data and vb2_verify_packed_key_inside from
  lib20/packed_key.c to 2packed_key.c
* Relocate tests accordingly

BUG=b:124141368, chromium:968464
TEST=make clean && make runtests
BRANCH=none

Change-Id: I6a9338ffdb640aad071941c3768427e15cd2aa93
Signed-off-by: Joel Kitching 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1642773
Tested-by: Joel Kitching 
Reviewed-by: Julius Werner 
Commit-Queue: Joel Kitching

vboot: update display init to use vboot2 code

2019-05-16T16:04:19+00:00

As per go/vboot2-oprom-cleanup, use vboot2 SD flag
DISPLAY_AVAILABLE, instead of the old vboot1 flags
OPROM_MATTERS and OPROM_LOADED.

Remove instances of "OPROM" and update with correct
nomenclature.

Update code and tests for EC software sync and diagnostic
menu to use vboot2 display init model.

OPROM_MATTERS and OPROM_LOADED are now deprecated, and
will be removed when no references remain in depthcharge
and coreboot.

Deprecate VBERROR_DISPLAY_INIT_MISMATCH (previously
OPROM_MISMATCH) and return VBERROR_REBOOT_REQUIRED
directly when needed.

BUG=b:124141368, b:124192753, chromium:948529
TEST=Build image for eve, force EC update,
     check that the "critical update" screen shows
TEST=make clean && make runtests
BRANCH=none

Change-Id: I889872f886230f8559d5cce09d0de194da3fcc38
Signed-off-by: Joel Kitching 
Reviewed-on: https://chromium-review.googlesource.com/1605641
Commit-Ready: ChromeOS CL Exonerator Bot 
Tested-by: Joel Kitching 
Reviewed-by: Julius Werner

vboot: deprecate Alt OS code

2019-05-15T03:13:17+00:00

BUG=b:124141368, b:131663912
TEST=make clean && make runtests
BRANCH=none

Change-Id: I6aae5683b8306eede4388ff5ed6665e7769756dc
Signed-off-by: Joel Kitching 
Reviewed-on: https://chromium-review.googlesource.com/1588026
Commit-Ready: ChromeOS CL Exonerator Bot 
Tested-by: Joel Kitching 
Reviewed-by: Julius Werner 
Reviewed-by: Ting Shen

Makefile: Enable more warnings for host utilities / tests

2019-05-15T03:13:04+00:00

This patch adds a bunch of more warnings that are already enabled in
coreboot and thus already enabled for firmware builds anyway (because
coreboot just passes its CFLAGS through). Enabling it in the vboot
Makefile means they also apply to host utilities and tests, which sounds
desirable for consistency.

Fix enough of the cruft and bad coding practices that accumulated over
the years of not having warnings enabled to get it to build again (this
includes making functions static, removing dead code, cleaning up
prototypes, etc.).

Also remove -fno-strict-aliasing from the x86 firmware build options,
because it's not clear why it's there (coreboot isn't doing this, so
presumably it's not needed).

BRANCH=None
BUG=None
TEST=make runtests

Change-Id: Ie4a42083c4770a4eca133b22725be9ba85b24184
Signed-off-by: Julius Werner 
Reviewed-on: https://chromium-review.googlesource.com/1598721
Commit-Ready: ChromeOS CL Exonerator Bot

vboot: deprecate GPIO_SIGNAL_TYPE_DEV

2019-03-29T02:04:07+00:00

As part of chromium:942901, physical dev switch functionality
is being deprecated.

BUG=chromiumos:942901
TEST=make clean && make runtests
BRANCH=none

Change-Id: I84d35a3eade6272896e7f9c3c43e87bba090f132
Signed-off-by: Joel Kitching 
Reviewed-on: https://chromium-review.googlesource.com/1539435
Commit-Ready: ChromeOS CL Exonerator Bot 
Tested-by: Joel Kitching 
Reviewed-by: Simon Glass 
Reviewed-by: Julius Werner

vboot: do not check for VBSD_HONOR_VIRT_DEV_SWITCH

2019-03-26T20:20:09+00:00

As part of chromium:942901, physical dev switch functionality
is being deprecated.

As such, we no longer need to specify the flag
VBSD_HONOR_VIRT_DEV_SWITCH -- the virtual dev switch should
always be honoured.

Additionally, there is no longer a need to check this flag
when looking up the value for crossystem devsw_cur.

This constant will be marked as deprecated in a subsequent
CL.

BUG=b:124141368, b:124192753, chromium:942901
TEST=Build locally
TEST=/work/vboot/src/repohooks/pre-upload.py
TEST=make clean && make runtests
TEST=make clean && COV=1 make coverage && make coverage_html
BRANCH=none

Change-Id: Ib1ab86d79b039650136f1038c23175f5990895db
Signed-off-by: Joel Kitching 
Reviewed-on: https://chromium-review.googlesource.com/1526070
Commit-Ready: ChromeOS CL Exonerator Bot 
Tested-by: Joel Kitching 
Reviewed-by: Simon Glass 
Reviewed-by: Julius Werner

vboot/crossystem: deprecate devsw_virtual

2019-03-26T11:43:29+00:00

As part of chromium:942901, physical dev switch functionality
is being deprecated.

There is no longer any need to provide devsw_virtual flag
in crossystem.

BUG=b:124141368, b:124192753, chromium:942901
TEST=Build locally
TEST=/work/vboot/src/repohooks/pre-upload.py
TEST=make clean && make runtests
TEST=make clean && COV=1 make coverage && make coverage_html
TEST=Check for references to devsw_virtual in code search
BRANCH=none

Change-Id: Id80ec1de8c43909ce2ff661744622d2ea36030a6
Signed-off-by: Joel Kitching 
Reviewed-on: https://chromium-review.googlesource.com/1526069
Commit-Ready: Joel Kitching 
Tested-by: Joel Kitching 
Reviewed-by: Simon Glass 
Reviewed-by: Julius Werner