delta/coreboot/vboot.git/host, branch main

Revert "vboot: update get system properties"

2023-05-08T07:09:21+00:00

This reverts commit 8ef4f7a9a9a68bad49e8417d5ed346dc927e1d2c.

Reason for revert: Installer supposedly misuses API with
`VbGetSystemPropertyString("fw_try_next", NULL, 0);`
by passing a `NULL` ptr as dest and so not sized.

The call sites need checking.

BUG=b:280417931
TEST=none

Original change's description:
> vboot: update get system properties
>
> `VbGetSystemPropertyString` header promises that the property string
> will be read into the passed in dest buffer, however for some system
> properties the values are not placed in buffer but returned directly.
> this patch fixes that error
>
> Before, running `VbGetSystemPropertyString("minios_priority", buf,
> size):`
> ```
> buf:  return value: B
> ```
> After, same command:
> ```
> buf: B return value: B
> ```
>
> BRANCH=none
> BUG=none
> TEST=Tested with an executable on brya
>
> Signed-off-by: Saketh Pothireddy 
>
> Change-Id: I87a0aa8638e719bc5bbea579ecaca4754a38c02e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4468208
> Reviewed-by: Jae Hoon Kim 
> Reviewed-by: Julius Werner 
> Commit-Queue: Saketh Pothireddy 
> Tested-by: Saketh Pothireddy 

Bug: none
Change-Id: Ie07363424db92832b485c9efae21edbf0d24fba5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4508974
Commit-Queue: Edward O'Callaghan 
Bot-Commit: Rubber Stamper 
Commit-Queue: Rubber Stamper 
Auto-Submit: Edward O'Callaghan

vboot: update get system properties

2023-04-27T18:29:31+00:00

`VbGetSystemPropertyString` header promises that the property string
will be read into the passed in dest buffer, however for some system
properties the values are not placed in buffer but returned directly.
this patch fixes that error

Before, running `VbGetSystemPropertyString("minios_priority", buf,
size):`
```
buf:  return value: B
```
After, same command:
```
buf: B return value: B
```

BRANCH=none
BUG=none
TEST=Tested with an executable on brya

Signed-off-by: Saketh Pothireddy 

Change-Id: I87a0aa8638e719bc5bbea579ecaca4754a38c02e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4468208
Reviewed-by: Jae Hoon Kim 
Reviewed-by: Julius Werner 
Commit-Queue: Saketh Pothireddy 
Tested-by: Saketh Pothireddy

futility/: host/lib: Add flash chip info subcommand support

2023-04-13T10:05:41+00:00

The AP RO verification tooling requires a understanding of the
underlying flashchip information. Provision support in the
flash subcommand to report back this data from the flashrom
driver.

BUG=b:276981092
BRANCH=none
TEST=on Nissa ```
localhost ~ # futility flash --flash-i{nfo}
Warning: Setting BIOS Control at 0xdc from 0x8b to 0x89 failed.
New value is 0x8b.
Flash vendor: Winbond
Flash name: W25Q256JV_M
Flash vid-pid: 0xef00007019
Flash size: 0x02000000
```.

Cq-Depend: chromium:4401775, chromium:4401776
Change-Id: I58e818f06def4904693f61c6967d70b16c62fa37
Signed-off-by: Edward O'Callaghan 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4402370
Auto-Submit: Edward O'Callaghan 
Tested-by: Edward O'Callaghan 
Commit-Queue: Jakub Czapiga 
Reviewed-by: Nikolai Artemiev

cgpt: Add support for error counter (verity)

2023-03-28T07:04:05+00:00

.. so platform side daemons/process can initiate getting/setting the
error counter (verity) attribute from GPT partitions of CrOS kernels.

```
$> cgpt show 
405504       65536       2  Label: "KERN-A"
                            Type: ChromeOS kernel
                            UUID: 0394A807-59A0-A84C-A443-BC3C555C8842
                            Attr: priority=15 tries=15 successful=1 error_counter=0
...
$> cgpt add -E1 -i2 
$> cgpt show 
405504       65536       2  Label: "KERN-A"
                            Type: ChromeOS kernel
                            UUID: 0394A807-59A0-A84C-A443-BC3C555C8842
                            Attr: priority=15 tries=15 successful=1 error_counter=1
...
$> cgpt add -E0 -i2 
$> cgpt show 
405504       65536       2  Label: "KERN-A"
                            Type: ChromeOS kernel
                            UUID: 0394A807-59A0-A84C-A443-BC3C555C8842
                            Attr: priority=15 tries=15 successful=1 error_counter=0
...
```

BUG=b:274539529
BRANCH=None
TEST=emerge vboot_reference
TEST=comment above

Change-Id: Ib0904378fba8219a3631278c66b7317fd86ea9d8
Signed-off-by: Jae Hoon Kim 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4370744
Reviewed-by: Julius Werner

futility: Add `flash` subcommand

2023-03-16T02:40:04+00:00

Add a new subcommand for getting/setting flash properties such as
the flash size and writeprotect configuration.

The operations provided by `futility flash` require less information
from the user and are less error prone than the equivalents provided by
`flashrom`.

For example, --wp-enable automatically choses the protection range based
on the firmware image and --wp-status gives a warning if the protection
range does not match the RO firmware region.

BUG=b:268574030
BRANCH=none
TEST=`futility flash --{flash-size,wp-enable,wp-disable,wp-status}`

Co-authored-by: Edward O'Callaghan 
Signed-off-by: Edward O'Callaghan 
Signed-off-by: Nikolai Artemiev 
Change-Id: I36d7468616a5bcdf3c4542d48652bd24c3377a61
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4279661
Reviewed-by: Edward O'Callaghan 
Commit-Queue: Edward O'Callaghan

vboot_reference: Change flashrom_get_wp signature

2023-03-09T06:08:41+00:00

Expose more information about WP state from the flashrom_drv WP status
function.

The more detailed WP information is required to properly validate the
system WP configuration.

BUG=b:268574030
TEST=futility update

Signed-off-by: Nikolai Artemiev 
Change-Id: If79b7d8cc68a0583cbf1f7049ac7a2dec088fdd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4301750
Reviewed-by: Edward O'Callaghan 
Tested-by: Edward O'Callaghan 
Reviewed-by: Yu-Ping Wu 
Commit-Queue: Edward O'Callaghan

lib/flashrom_drv.c: Use correct programmer name for programmer init

2023-03-01T04:38:44+00:00

Fix the call to `flashrom_programmer_init()` in `flashrom_get_wp()`. The
programmer name and parameters should be passed separately, e.g:

> flashrom_programmer_init("dummy", "emulate=VARIABLE_SIZE,...")

However a string containing both the name and parameters was incorrectly
used instead, e.g:

> flashrom_programmer_init("dummy:emulate=VARIABLE_SIZE,...", "emulate=VARIABLE_SIZE,...")

This was not noticed before because it did not cause issues if there
were no parameters, e.g. if the programmer was just "host" or "internal"

BUG=b:238694831,b:260531154
TEST=cros_run_unit_tests --board octopus --packages vboot_reference

Change-Id: I4774a82258acbb8be2b430351ccef203e26e6b27
Signed-off-by: Nikolai Artemiev 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4290837
Reviewed-by: Yu-Ping Wu 
Reviewed-by: Edward O'Callaghan 
Commit-Queue: Yu-Ping Wu

futility: flashrom_drv: Support partial read for multiple regions

2023-02-16T12:16:11+00:00

Similar to CL:3490388, support flashrom read for multiple regions.

BUG=b:260531154
TEST=emerge-corsola vboot_reference
BRANCH=none

Change-Id: I1f75832f882004e879bc299be6862db089c2b71d
Signed-off-by: Yu-Ping Wu 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4251503
Reviewed-by: Hung-Te Lin

host/lib/flashrom_drv.c: Move flag to avoid locked ME issue

2023-02-16T10:20:52+00:00

Older Intel DUT's have a ME in "locked" mode in the descriptor
and while the write_flash() attempts to write back to flash
to a specific region it needs to read the FMAP to obtain the
region name. This read overlaps with the "locked" region and
thus the following is observed in logs:

```
FREG2: Management Engine region (0x00001000-0x001fffff) is locked.
[..]
read_flash: cannot read inside Management Engine region (0x001000..0x1fffff).
```

BUG=b:269199980
TEST=builds.

Change-Id: If7bebf28cd4d34cc4074700184233c83edbd2409
Signed-off-by: Edward O'Callaghan 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4248344
Auto-Submit: Edward O'Callaghan 
Reviewed-by: Sam McNally 
Reviewed-by: Hung-Te Lin 
Tested-by: Edward O'Callaghan 
Commit-Queue: Edward O'Callaghan

host: Add region parameter to flashrom_read_image

2023-01-27T10:13:53+00:00

Allow flashrom_read_image to take a parameter to read only a region.

BUG=b:265861606
BRANCH=None
TEST=unit

Change-Id: I835ca341c00b21286721f65c3e009a76753b6628
Signed-off-by: Evan Benn 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4170146
Tested-by: Edward O'Callaghan 
Reviewed-by: Julius Werner 
Reviewed-by: Edward O'Callaghan