delta/coreboot/vboot.git/futility, branch stabilize-14469.58.B

futility: Use crosid to probe firmware manifest key

2022-01-11T23:41:23+00:00

Use the API function crosid_get_firmware_manifest_key from libcrosid
instead of "mosys platform model" to get the firmware manifest key.

Note: this leaves inconsistent terminology around "model" and
"firmware manifest key", which is quite intentional at the moment,
since the model is still the firmware manifest key for the time
being.  Should we decide to change that in the future, we can do
further renaming in futility.

BUG=b:213251232
BRANCH=none
TEST=chromeos-firmwareupdate on delbin
     run recovery on delbin

Cq-Depend: chromium:3364974
Signed-off-by: Jack Rosenthal 
Change-Id: I306ae444849e327ba208f52e34b584b571ef6a3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3368704
Reviewed-by: Raul Rangel

vboot_reference/futility: Pass through SERVOD_NAME.

2022-01-07T04:47:47+00:00

SERVOD_PORT and SERVOD_NAME environment variables are both used by
dut-control to identify the servod instance to use. If SERVOD_NAME is
set, query the servo serial number just like when SERVOD_PORT is set.

BUG=None
TEST=futility --servo -i with SERVOD_NAME set
BRANCH=None

Change-Id: I0c656e25d4f5da67570e3ff7d6cf28fdca5ec1cf
Signed-off-by: Sam McNally 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3367518
Reviewed-by: Edward O'Callaghan

vboot_reference/futility: Support "ccd_gsc" as a servo type fragment.

2022-01-07T04:47:46+00:00

For DT, servo_type reports ccd_gsc instead of ccd_cr50. Treat ccd_gsc
the same as ccd_cr50.

BUG=None
TEST=futility update --servo -i
BRANCH=None

Change-Id: I27f5ea7ccc70fd1a247b844a9929aed7a133ebb3
Signed-off-by: Sam McNally 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3367517
Reviewed-by: Edward O'Callaghan

vboot_reference: Allow flashrom_read_image() reading per-region

2022-01-04T04:32:51+00:00

BUG=b:207808292
BRANCH=none
TEST=`make`

Signed-off-by: Edward O'Callaghan 
Change-Id: I98f1a2566ef50b2c7b1376141bb2f1c096b710a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3358664
Tested-by: Edward O'Callaghan 
Auto-Submit: Edward O'Callaghan 
Reviewed-by: Nikolai Artemiev 
Commit-Queue: Nikolai Artemiev

vboot_ref/futility: Wrap flashrom_drv behind USE_FLASHROM

2021-12-29T21:34:41+00:00

Some users of futility do not need flashrom support such
as upstream coreboot. Allow for explicitly enabling the
paths.

BUG=b:203715651,b:209702505
BRANCH=none
TEST=builds

Signed-off-by: Edward O'Callaghan 
Change-Id: I61095bf91e3d01bd008d3b790478a590758e88cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3350299
Tested-by: Edward O'Callaghan 
Auto-Submit: Edward O'Callaghan 
Reviewed-by: Yu-Ping Wu 
Reviewed-by: Hsuan Ting Chen 
Commit-Queue: Hsuan Ting Chen

vboot_ref/futility: Extract out flashrom call logic

2021-12-24T00:50:51+00:00

Separate out all the flashrom worker code used in futility
to allow for later building a futility without flashrom
support.

BUG=b:203715651,b:209702505
BRANCH=none
TEST=builds

Signed-off-by: Edward O'Callaghan 
Change-Id: I938141056424f8f93a598bbb288ee7c8770edc95
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3350298
Tested-by: Edward O'Callaghan 
Auto-Submit: Edward O'Callaghan 
Reviewed-by: Hung-Te Lin 
Commit-Queue: Edward O'Callaghan

futility/updater: Increase the fw_try_count to 8

2021-12-23T09:22:14+00:00

Some platforms go through extra resets on cold boots. On an update scenario
involving GSC & PD firmware updates, this extra reset depletes the
fw_try_count of 6. This leads to device falling back to old FW slots.
Increase the fw_try_count to 8 to handle extra resets.

BUG=b:190207306
BRANCH=dedede, volteer
TEST=Build and boot to OS in Drawlat. Ensure that the AP + EC + ME + PD
FW updates are applied and the system was able to boot to OS
successfully - https://paste.googleplex.com/4966135716904960.

Signed-off-by: Karthikeyan Ramasubramanian 
Change-Id: I8bb5507d2351cf1511fda773876dedbe098b5c44
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3345900
Reviewed-by: Evan Green 
Reviewed-by: Tim Wawrzynczak 
Reviewed-by: Julius Werner 
Tested-by: Karthikeyan Ramasubramanian 
Reviewed-by: Hung-Te Lin 
Commit-Queue: Bob Moragues

futility/update: Search RO CBFS files in "COREBOOT", not "RO_SECTION"

2021-12-14T19:43:52+00:00

The "RO_SECTION" FMAP area is a parent area that contains multiple
nested areas, including the "COREBOOT" area containing the actual RO
CBFS. On some platforms the "COREBOOT" area may be the first area in
"RO_SECTION", and therefore the start offsets would be equal and
`cbfstool -r RO_SECTION` would accidentally do the right thing -- but
this is not true for all platforms and may break elsewhere.

I don't know what this code does or how to test it but I assume fixing
this issue is a good thing.

BRANCH=None
BUG=None
TEST=None

Signed-off-by: Julius Werner 
Change-Id: Ica281af75299e06c36e2f0437d2b1fcc6c0731e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3299058
Reviewed-by: Yu-Ping Wu 
Reviewed-by: Hung-Te Lin

gscvd: add dedicated test keys

2021-12-03T05:16:14+00:00

This patch extends create_new_keys.sh to generate two additional key
pairs to use for AP RO verification signing. Both new pairs are
RSA4096/SHA256.

The script was ran to generate a new set of keys and the produced AP
RO verification key pairs were copied into tests/devkeys.

BRANCH=none
BUG=b:141191727
TEST=re-signed guybrush AP firmware image following the process
     described in cmd_gscvd.c comments, created a Cr50 image
     incorporating the new root public key hash, updated the DUT AP
     and Cr50 firmware and observed successful AP RO validation.

Change-Id: I03cba1446fc5ffdfef662c5ce1ea3e61950477d4
Signed-off-by: Vadim Bendebury 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3297447
Tested-by: Vadim Bendebury 
Reviewed-by: Mike Frysinger 
Commit-Queue: Vadim Bendebury

vboot_reference/futility: Inline get_host_wp()

2021-11-26T01:08:18+00:00

writeprotect still requires sub-processing flashrom as
libflashrom currently lacks a API to perform this task.
Therefore simplify the remaining sub-process logic for
just this purpose.

BUG=b:203715651
BRANCH=none
TEST=cros deploy to nocturne and ran:
 `/usr/sbin/chromeos-firmwareupdate --mode=recovery --wp=1`.
&& `$ cros_run_unit_tests --board nocturne --packages vboot_reference`.

Signed-off-by: Edward O'Callaghan 
Change-Id: I11c0f89997e3f47e97444cc8186823fa536b8d5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3233704
Tested-by: Edward O'Callaghan 
Commit-Queue: Edward O'Callaghan 
Reviewed-by: Nikolai Artemiev 
Reviewed-by: Sam McNally