<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/coreboot/vboot.git/Makefile, branch stabilize-14469.58.B</title>
<subtitle>review.coreboot.org: vboot.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/'/>
<entry>
<title>futility: Link with libcrosid</title>
<updated>2022-01-10T23:19:15+00:00</updated>
<author>
<name>Jack Rosenthal</name>
<email>jrosenth@chromium.org</email>
</author>
<published>2022-01-06T00:27:33+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=22076b1036354be65ac694e3ed0657b6f344f9d1'/>
<id>22076b1036354be65ac694e3ed0657b6f344f9d1</id>
<content type='text'>
Use pkg-config to link with libcrosid when it's available.

Note that when futility is compiled from the coreboot tree, libcrosid
won't be available, at least at the moment, so expose -DUSE_CROSID to
the C code so we know when we have it available.

BUG=b:213251232
BRANCH=none
TEST=emerge-volteer -j vboot_reference
     "lddtree /build/volteer/usr/bin/futility" lists libcrosid

Cq-Depend: chromium:3367251
Signed-off-by: Jack Rosenthal &lt;jrosenth@chromium.org&gt;
Change-Id: I8e69c5ce4570ac9df72440d0a34b6b03b5a36e77
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3368703
Reviewed-by: Raul Rangel &lt;rrangel@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use pkg-config to link with libcrosid when it's available.

Note that when futility is compiled from the coreboot tree, libcrosid
won't be available, at least at the moment, so expose -DUSE_CROSID to
the C code so we know when we have it available.

BUG=b:213251232
BRANCH=none
TEST=emerge-volteer -j vboot_reference
     "lddtree /build/volteer/usr/bin/futility" lists libcrosid

Cq-Depend: chromium:3367251
Signed-off-by: Jack Rosenthal &lt;jrosenth@chromium.org&gt;
Change-Id: I8e69c5ce4570ac9df72440d0a34b6b03b5a36e77
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3368703
Reviewed-by: Raul Rangel &lt;rrangel@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>crossystem: Remove the stale TPM simulator support</title>
<updated>2022-01-10T05:44:22+00:00</updated>
<author>
<name>Yi Chou</name>
<email>yich@google.com</email>
</author>
<published>2021-12-30T06:11:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=c91e3152722eaa827ea5b86aaf8da8558f74c29b'/>
<id>c91e3152722eaa827ea5b86aaf8da8558f74c29b</id>
<content type='text'>
We don't need the MOUNT_ENCRYPTED_KEY_PATH after we replaced the stale
TPM simulator with the driver-level TPM simulator.
It's time to remove it.

BUG=b:203195852, b:174807059
BRANCH=none
TEST=crossystem clear_tpm_owner_request=1

Signed-off-by: Yi Chou &lt;yich@google.com&gt;
Change-Id: I7c1c9c16697b1bbda9adea13448fdb9cffd9cc7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3358669
Reviewed-by: Julius Werner &lt;jwerner@chromium.org&gt;
Reviewed-by: Leo Lai &lt;cylai@google.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We don't need the MOUNT_ENCRYPTED_KEY_PATH after we replaced the stale
TPM simulator with the driver-level TPM simulator.
It's time to remove it.

BUG=b:203195852, b:174807059
BRANCH=none
TEST=crossystem clear_tpm_owner_request=1

Signed-off-by: Yi Chou &lt;yich@google.com&gt;
Change-Id: I7c1c9c16697b1bbda9adea13448fdb9cffd9cc7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3358669
Reviewed-by: Julius Werner &lt;jwerner@chromium.org&gt;
Reviewed-by: Leo Lai &lt;cylai@google.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Makefile: Fix missed boolean flags</title>
<updated>2022-01-04T11:50:59+00:00</updated>
<author>
<name>Jakub Czapiga</name>
<email>jacz@semihalf.com</email>
</author>
<published>2021-12-20T10:33:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=80629e7fd1935c51c476fb228b3560f922982cbe'/>
<id>80629e7fd1935c51c476fb228b3560f922982cbe</id>
<content type='text'>
Fix flags missed in CL:3306615.

BUG=b:206031372
TEST=make runtests
TEST=sudo emerge-guybrush sys-boot/depthcharge
BRANCH=none

Signed-off-by: Jakub Czapiga &lt;jacz@semihalf.com&gt;
Change-Id: Idbb205bb9e14f44a10806785fb9f7b29572f0626
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3347667
Reviewed-by: Yu-Ping Wu &lt;yupingso@chromium.org&gt;
Tested-by: Jakub Czapiga &lt;czapiga@google.com&gt;
Commit-Queue: Jakub Czapiga &lt;czapiga@google.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix flags missed in CL:3306615.

BUG=b:206031372
TEST=make runtests
TEST=sudo emerge-guybrush sys-boot/depthcharge
BRANCH=none

Signed-off-by: Jakub Czapiga &lt;jacz@semihalf.com&gt;
Change-Id: Idbb205bb9e14f44a10806785fb9f7b29572f0626
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3347667
Reviewed-by: Yu-Ping Wu &lt;yupingso@chromium.org&gt;
Tested-by: Jakub Czapiga &lt;czapiga@google.com&gt;
Commit-Queue: Jakub Czapiga &lt;czapiga@google.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>vboot_ref/futility: Wrap flashrom_drv behind USE_FLASHROM</title>
<updated>2021-12-29T21:34:41+00:00</updated>
<author>
<name>Edward O'Callaghan</name>
<email>quasisec@google.com</email>
</author>
<published>2021-12-21T00:28:38+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=25b9493525325dfb5bc2c36321c43ec7665060fa'/>
<id>25b9493525325dfb5bc2c36321c43ec7665060fa</id>
<content type='text'>
Some users of futility do not need flashrom support such
as upstream coreboot. Allow for explicitly enabling the
paths.

BUG=b:203715651,b:209702505
BRANCH=none
TEST=builds

Signed-off-by: Edward O'Callaghan &lt;quasisec@google.com&gt;
Change-Id: I61095bf91e3d01bd008d3b790478a590758e88cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3350299
Tested-by: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
Auto-Submit: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
Reviewed-by: Yu-Ping Wu &lt;yupingso@chromium.org&gt;
Reviewed-by: Hsuan Ting Chen &lt;roccochen@chromium.org&gt;
Commit-Queue: Hsuan Ting Chen &lt;roccochen@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Some users of futility do not need flashrom support such
as upstream coreboot. Allow for explicitly enabling the
paths.

BUG=b:203715651,b:209702505
BRANCH=none
TEST=builds

Signed-off-by: Edward O'Callaghan &lt;quasisec@google.com&gt;
Change-Id: I61095bf91e3d01bd008d3b790478a590758e88cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3350299
Tested-by: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
Auto-Submit: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
Reviewed-by: Yu-Ping Wu &lt;yupingso@chromium.org&gt;
Reviewed-by: Hsuan Ting Chen &lt;roccochen@chromium.org&gt;
Commit-Queue: Hsuan Ting Chen &lt;roccochen@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>vboot_ref/futility: Extract out flashrom call logic</title>
<updated>2021-12-24T00:50:51+00:00</updated>
<author>
<name>Edward O'Callaghan</name>
<email>quasisec@google.com</email>
</author>
<published>2021-12-21T00:03:53+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=b9859822af4a709e344607fce987a6ef2a75ac75'/>
<id>b9859822af4a709e344607fce987a6ef2a75ac75</id>
<content type='text'>
Separate out all the flashrom worker code used in futility
to allow for later building a futility without flashrom
support.

BUG=b:203715651,b:209702505
BRANCH=none
TEST=builds

Signed-off-by: Edward O'Callaghan &lt;quasisec@google.com&gt;
Change-Id: I938141056424f8f93a598bbb288ee7c8770edc95
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3350298
Tested-by: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
Auto-Submit: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
Reviewed-by: Hung-Te Lin &lt;hungte@chromium.org&gt;
Commit-Queue: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Separate out all the flashrom worker code used in futility
to allow for later building a futility without flashrom
support.

BUG=b:203715651,b:209702505
BRANCH=none
TEST=builds

Signed-off-by: Edward O'Callaghan &lt;quasisec@google.com&gt;
Change-Id: I938141056424f8f93a598bbb288ee7c8770edc95
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3350298
Tested-by: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
Auto-Submit: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
Reviewed-by: Hung-Te Lin &lt;hungte@chromium.org&gt;
Commit-Queue: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>vboot_reference/Makefile: Work towards a common flashrom path</title>
<updated>2021-12-16T16:20:50+00:00</updated>
<author>
<name>Edward O'Callaghan</name>
<email>quasisec@google.com</email>
</author>
<published>2021-12-09T03:13:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=b83cf2cd34ee3430fa9b5cebc111c43fca811cc1'/>
<id>b83cf2cd34ee3430fa9b5cebc111c43fca811cc1</id>
<content type='text'>
There are multiple flashrom calling wrapping code implementations
within vboot_ref. Work towards making a singular canonical
implementation.

BUG=b:207808292
BRANCH=none
TEST=`make`

Signed-off-by: Edward O'Callaghan &lt;quasisec@google.com&gt;
Change-Id: I8e133a11b777b4e80bb4e43a64a5349956cef8eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3325329
Tested-by: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
Auto-Submit: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
Reviewed-by: Nikolai Artemiev &lt;nartemiev@google.com&gt;
Commit-Queue: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
There are multiple flashrom calling wrapping code implementations
within vboot_ref. Work towards making a singular canonical
implementation.

BUG=b:207808292
BRANCH=none
TEST=`make`

Signed-off-by: Edward O'Callaghan &lt;quasisec@google.com&gt;
Change-Id: I8e133a11b777b4e80bb4e43a64a5349956cef8eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3325329
Tested-by: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
Auto-Submit: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
Reviewed-by: Nikolai Artemiev &lt;nartemiev@google.com&gt;
Commit-Queue: Edward O'Callaghan &lt;quasisec@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Makefile: Make boolean variables use zero as disabled</title>
<updated>2021-12-03T11:16:43+00:00</updated>
<author>
<name>Jakub Czapiga</name>
<email>jacz@semihalf.com</email>
</author>
<published>2021-11-29T15:28:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=c597e93127153d7a766540f6815c33b0bfcc098d'/>
<id>c597e93127153d7a766540f6815c33b0bfcc098d</id>
<content type='text'>
Until now some variables had to be unset or set to NULL to disable their
respective features. This patch makes it possible to disable variables
by passing zero as a value.

BUG=b:206031372
TEST=make runtests
TEST=sudo emerge-guybrush sys-boot/depthcharge
BRANCH=none

Signed-off-by: Jakub Czapiga &lt;jacz@semihalf.com&gt;
Change-Id: I1c254ac8ea3237615a20334ba6a66c09a4abd791
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3306615
Tested-by: Jakub Czapiga &lt;czapiga@google.com&gt;
Auto-Submit: Jakub Czapiga &lt;czapiga@google.com&gt;
Reviewed-by: Julius Werner &lt;jwerner@chromium.org&gt;
Commit-Queue: Jakub Czapiga &lt;czapiga@google.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Until now some variables had to be unset or set to NULL to disable their
respective features. This patch makes it possible to disable variables
by passing zero as a value.

BUG=b:206031372
TEST=make runtests
TEST=sudo emerge-guybrush sys-boot/depthcharge
BRANCH=none

Signed-off-by: Jakub Czapiga &lt;jacz@semihalf.com&gt;
Change-Id: I1c254ac8ea3237615a20334ba6a66c09a4abd791
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3306615
Tested-by: Jakub Czapiga &lt;czapiga@google.com&gt;
Auto-Submit: Jakub Czapiga &lt;czapiga@google.com&gt;
Reviewed-by: Julius Werner &lt;jwerner@chromium.org&gt;
Commit-Queue: Jakub Czapiga &lt;czapiga@google.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Makefile: Remove DETACHABLE and PHYSICAL_PRESENCE_KEYBOARD</title>
<updated>2021-12-03T11:16:41+00:00</updated>
<author>
<name>Jakub Czapiga</name>
<email>jacz@semihalf.com</email>
</author>
<published>2021-11-29T12:06:02+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=793d84de3c07c61d3b8cd40d4ec3b734690287e8'/>
<id>793d84de3c07c61d3b8cd40d4ec3b734690287e8</id>
<content type='text'>
DETACHABLE and PHYSICAL_PRESENCE_KEYBOARD are unused in the code and can
be removed from the Makefile.

BUG=b:206031372
TEST=make runtests
BRANCH=none

Signed-off-by: Jakub Czapiga &lt;jacz@semihalf.com&gt;
Change-Id: I6d91f8bfa8342c95959014c3a0efcccf02f1d915
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3306614
Tested-by: Jakub Czapiga &lt;czapiga@google.com&gt;
Reviewed-by: Yu-Ping Wu &lt;yupingso@chromium.org&gt;
Commit-Queue: Jakub Czapiga &lt;czapiga@google.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
DETACHABLE and PHYSICAL_PRESENCE_KEYBOARD are unused in the code and can
be removed from the Makefile.

BUG=b:206031372
TEST=make runtests
BRANCH=none

Signed-off-by: Jakub Czapiga &lt;jacz@semihalf.com&gt;
Change-Id: I6d91f8bfa8342c95959014c3a0efcccf02f1d915
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3306614
Tested-by: Jakub Czapiga &lt;czapiga@google.com&gt;
Reviewed-by: Yu-Ping Wu &lt;yupingso@chromium.org&gt;
Commit-Queue: Jakub Czapiga &lt;czapiga@google.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Makefile: Add dumpRSAPublicKey to SDK utilities</title>
<updated>2021-11-26T04:21:17+00:00</updated>
<author>
<name>Yu-Ping Wu</name>
<email>yupingso@chromium.org</email>
</author>
<published>2021-11-24T07:34:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=afd4e0ae05efda36347a406f429ceb4952faf0a0'/>
<id>afd4e0ae05efda36347a406f429ceb4952faf0a0</id>
<content type='text'>
This utility is used in key generation, so it really belongs in the SDK.
However, some autotests currently also want to generate keys on the DUT.
So let's just install it to both.

BUG=b:207452735
TEST=FEATURES=test emerge-dedede vboot_reference
TEST=sudo emerge vboot_reference &amp;&amp; which dumpRSAPublicKey
BRANCH=none

Change-Id: Ic2395a10557773acffa22ea3c9a1e01cf581053b
Signed-off-by: Yu-Ping Wu &lt;yupingso@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3299839
Reviewed-by: Julius Werner &lt;jwerner@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This utility is used in key generation, so it really belongs in the SDK.
However, some autotests currently also want to generate keys on the DUT.
So let's just install it to both.

BUG=b:207452735
TEST=FEATURES=test emerge-dedede vboot_reference
TEST=sudo emerge vboot_reference &amp;&amp; which dumpRSAPublicKey
BRANCH=none

Change-Id: Ic2395a10557773acffa22ea3c9a1e01cf581053b
Signed-off-by: Yu-Ping Wu &lt;yupingso@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3299839
Reviewed-by: Julius Werner &lt;jwerner@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Makefile: Avoid duplicate installation of utility</title>
<updated>2021-11-26T04:21:16+00:00</updated>
<author>
<name>Yu-Ping Wu</name>
<email>yupingso@chromium.org</email>
</author>
<published>2021-11-24T06:48:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=bd34307782b83ab2391908abfc64df967c545a5d'/>
<id>bd34307782b83ab2391908abfc64df967c545a5d</id>
<content type='text'>
The current rules for 'utils_install_sdk' and 'utils_install_board'
individually install the required list of binaries and scripts. When
there are overlapping files in 'UTIL_NAMES_SDK' and 'UTIL_NAMES_BOARD',
the second executed rule will fail with duplicate installation.

Instead of having a single phony target that installs all the files,
define a rule 'util_install-&lt;FILE&gt;' for each file to ensure that each
one will be installed at most once.

BUG=b:207452735
TEST=make runtests
TEST=emerge-dedede vboot_reference
TEST=FEATURES=test emerge-dedede vboot_reference
TEST=sudo emerge vboot_reference
BRANCH=none

Change-Id: I24c23a61c4ff7de851bf11541bc46c963bf35c22
Signed-off-by: Yu-Ping Wu &lt;yupingso@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3299836
Reviewed-by: Julius Werner &lt;jwerner@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The current rules for 'utils_install_sdk' and 'utils_install_board'
individually install the required list of binaries and scripts. When
there are overlapping files in 'UTIL_NAMES_SDK' and 'UTIL_NAMES_BOARD',
the second executed rule will fail with duplicate installation.

Instead of having a single phony target that installs all the files,
define a rule 'util_install-&lt;FILE&gt;' for each file to ensure that each
one will be installed at most once.

BUG=b:207452735
TEST=make runtests
TEST=emerge-dedede vboot_reference
TEST=FEATURES=test emerge-dedede vboot_reference
TEST=sudo emerge vboot_reference
BRANCH=none

Change-Id: I24c23a61c4ff7de851bf11541bc46c963bf35c22
Signed-off-by: Yu-Ping Wu &lt;yupingso@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3299836
Reviewed-by: Julius Werner &lt;jwerner@chromium.org&gt;
</pre>
</div>
</content>
</entry>
</feed>
