delta/coreboot/vboot.git, branch stabilize-7956.B

vb2: Modify phase2 behavior for S3 resume case

2016-02-24T00:58:50+00:00

If a platform does verification of memory init then it must be careful
to use the same slot for resume that it booted from.  This is
accomplished by adding a context flag to indicate this is an S3 resume
and that vboot should treat it differently than a normal boot.

When this flag is set then the same slot that was booted is read from
VBNV and re-used for the resume path, without adjusting any try flags.
If this slot is B then the related context flag is set.

This will allow the firmware updater to update the other (non-booted)
slot and set flags indicating that on the next boot the updated slot
should be tried, while still allowing suspend/resume to work with the
existing firmware slot.

This assumes that the last tried slot was successfully booted, which
should be a safe assumption since the system was able to boot and then
suspend.  It isn't reliable to check last_fw_result for "success"
status because that status is only set some time after boot when
chromeos-setgoodkernel calls chromeos-firmwareupdate --mode=bootok
and so it may still report a status of "trying" on resume depending
on how soon after boot the suspend happened.

It also avoids setting the vboot flag indicating that a slot choice
was made in order to avoid altering the try counter on failure since
this is explicitly not attempting to boot the new slot.

BUG=chromium:577269
BRANCH=glados
TEST=manually tested on chell:
1) ensure that booting from slot A resumes from slot A.
2) ensure that booting from slot B resumes from slot B.
3) do RW update while booted from slot A (so the flags are set to try
slot B) and ensure that suspend/resume still functions properly using
current slot A.
4) do RW update while booted from slot B (so the flags are set to try
slot A) and ensure that suspend/resume still functions properly using
current slot B.

Change-Id: I500faef2b5d19a02f32839976354abf6d551c9f6
Signed-off-by: Duncan Laurie 
Reviewed-on: https://chromium-review.googlesource.com/328812
Reviewed-by: Aaron Durbin

sign_nv_cbootimage: Update signing scripts for nv bootloader and lp0

2016-02-03T22:59:16+00:00

Currently, nvidia tools do not provide the support to perform signing
of bootloader or lp0 image. Thus, the signing script is updated to
support this. Once, we have the required tools, this script can be
simplified again.

CQ-DEPEND=CL:*244234
BUG=chrome-os-partner:43018
BRANCH=none
TEST=Verified that signed bootloader and lp0 work fine on dev-PKC
fused devices.

Reference:
https://code.google.com/p/chrome-os-partner/issues/attachmentText?id=43018&aid=430180067000&name=sign-lp0.sh&token=ABZ6GAcjz4b2mEk55WqREzwTnWWpEyE_7A%3A1452631308268
https://code.google.com/p/chrome-os-partner/issues/attachmentText?id=43018&aid=430180060000&name=sign.sh&token=ABZ6GAcRky67XrzMOgKZfkJxr70qm-tTAg%3A1452631308240

Change-Id: Icb024a1d9a61714df6e52d94c96cf43481cac869
Signed-off-by: Furquan Shaikh 
Reviewed-on: https://chromium-review.googlesource.com/321459
Commit-Ready: Furquan Shaikh 
Tested-by: Furquan Shaikh 
Reviewed-by: Mike Frysinger

vboot_display: Keep track of displayed screen

2016-01-30T00:01:57+00:00

Vboot needs to track the currently displayed screen so when it needs to
change the locale or display the debug overlay it knows which screen to
redraw.  Currently only the legacy path is doing this so change the new
path to update the current screen if it is successfully drawn.

BUG=chrome-os-partner:49766
BRANCH=glados
TEST=boot on glados in dev mode, hit tab and ensure screen does not go black

Change-Id: I4a2bf028275db57b2d0469fc1cb574e871820713
Signed-off-by: Duncan Laurie 
Reviewed-on: https://chromium-review.googlesource.com/324549
Reviewed-by: Aaron Durbin

vb20: add vb2api_check_hash_get_digest() for retrieving hash result

2016-01-26T22:56:36+00:00

For x86 systems, which resume through the boot reset vector, to
implement vboot verification of the memory init code one needs
check that the slot chosen on the resume path is the same as
the original boot path. That check is done by storing the
resulting hash of the slot. However, vb2api doesn't export
the resulting hash from vb2api_check_hash(). Thus, provide
a variant which saves the resulting digest in the supplied
buffer.

BUG=chrome-os-partner:46049
BRANCH=glados
TEST=Suspended and resumed on chell. Also, tested with an EC build
     which returns a bad hash to ensure that is properly caught.

Change-Id: Ic20be2024afedabc2d8bc767f1b794376348523c
Signed-off-by: Aaron Durbin 
Reviewed-on: https://chromium-review.googlesource.com/323460
Reviewed-by: Randall Spangler 
Reviewed-by: Duncan Laurie

Pipe the custom_music use flag to the define

2016-01-26T22:56:30+00:00

This will allow the definition of CUSTOM_MUSIC from
the individual board ebuilds.

TEST=Define use flag and extra functions on a board, enjoy the custom tunes
BUG=chrome-os-partner:48657
BRANCH=master

Change-Id: I974f9cc51f9b25fb3dff063926e6ea01cf1e031b
Signed-off-by: Alexandru M Stan 
Reviewed-on: https://chromium-review.googlesource.com/323833
Commit-Ready: Alexandru Stan 
Tested-by: Alexandru Stan 
Reviewed-by: Randall Spangler 
Reviewed-by: Julius Werner

Increase MAX_CUSTOM_DELAY to 5 minutes

2016-01-26T22:56:29+00:00

Rialto will soon need a longer dev mode delay, this variable would prevent it.

BUG=chrome-os-partner:48657
TEST=See follow up CLs
BRANCH=master

Change-Id: Ie5ada9c5441b5b042bd0801d66559ab715fbbf47
Signed-off-by: Alexandru M Stan 
Reviewed-on: https://chromium-review.googlesource.com/323832
Commit-Ready: Alexandru Stan 
Tested-by: Alexandru Stan 
Reviewed-by: Randall Spangler 
Reviewed-by: Julius Werner

vboot: Disable VBNV_OPROM_NEEDED after successful update

2016-01-21T02:25:38+00:00

The VBOOT_OPROM_NEEDED flag is used for EC software sync when the
VBSD_EC_SLOW_UPDATE flag is set.

After a successful EC software sync vboot requests a reboot to disable
graphics but it is not clearing the VBNV flag first.  With vboot1 this
was getting cleared as a side effect of calling VbInit in normal mode.

BUG=chrome-os-partner:49560
BRANCH=glados
TEST=Enable EC_SLOW_UPDATE on chell and test EC software sync in normal
mode and ensure that it reboots and does not do graphics init if the
update is successful.

Change-Id: I2aa0c4c3b1ad357a5b8ddc14539e264a1f5b76b2
Signed-off-by: Duncan Laurie 
Reviewed-on: https://chromium-review.googlesource.com/322731
Reviewed-by: Aaron Durbin

Modify EC software sync to update RO if necessary

2016-01-10T21:40:50+00:00

Allow the AP to sync and verify the EC read only image after updating
the rewritable image.

BUG=chrome-os-partner:48703
BRANCH=none
TEST=manual

1. Update EC to a new version
2. rebuild EC code
3. Update AP firmware
4. Reboot and check that the RO image is updated after the RW image is
updated.

CQ-DEPEND=CL:319213

Change-Id: I774ef25320103f20d8c7d1c180a220dd0819c04d
Signed-off-by: Mary Ruthven 
Reviewed-on: https://chromium-review.googlesource.com/320614
Reviewed-by: Randall Spangler

Update a utility to support the new tpm sysfs class directory

2016-01-07T22:29:42+00:00

Kernel TPM patches from 4.x moved /sys/class/misc/tpm0 to /sys/class/tpm/tpm0.
Support both paths in this utility.

BUG=chromium:573368
BRANCH=none
TEST=untested, not sure if this utility is still used.

Change-Id: Ib81476eee4c9de921502a3a47f6990b9e6b1968b
Reviewed-on: https://chromium-review.googlesource.com/320892
Commit-Ready: Bryan Freed 
Tested-by: Bryan Freed 
Reviewed-by: Duncan Laurie

Port to musl: musl doesn't have execinfo.h.

2016-01-07T09:46:35+00:00

Change-Id: Idc2f18880581d3a2e67185becee8b77cfa5cdf04
Reviewed-on: https://chromium-review.googlesource.com/313388
Commit-Ready: Doug Evans 
Tested-by: Doug Evans 
Reviewed-by: Randall Spangler