delta/coreboot/vboot.git, branch stabilize-7356.B

Add "tpmc pcrextend" command to extend a PCR

2015-08-10T20:42:12+00:00

This is useful for testing different configurations without repeatedly
reflashing the firmware, e.g.

    # stop tcsd
    # tpmc pcr 0
    0000000000000000000000000000000000000000
    # tpmc pcrextend 0 c42ac1c46f1d4e211c735cc7dfad4ff8391110e9
    # tpmc pcr 0
    865aedd337518e56f648440b81b4cbd9359fdff3
    

BUG=none
BRANCH=none
TEST=manual

Change-Id: Ie5814ca2a3a5cf5a0eaf0ffee0385315db09bf25
Signed-off-by: Kevin Cernekee 
Reviewed-on: https://chromium-review.googlesource.com/289009
Reviewed-by: Luigi Semenzato 
Reviewed-by: Kees Cook

VbNvStorage: Add flags for misc settings

2015-08-01T02:51:38+00:00

1. Change offset 8 to hold all misc settings (fastboot, boot_on_ac
detect) instead of only fastboot settings.
2. Add flag to hold state of boot_on_ac_detect (If set to 1, AP should
start booting as soon as AC is connected in off-state).

BUG=chrome-os-partner:41680
BRANCH=None
TEST=Compiles successfully. make runtests successful.

Change-Id: I64b3fc69bd52cbcaf5899c953ccafa2e81b5b8a5
Signed-off-by: Furquan Shaikh 
Reviewed-on: https://chromium-review.googlesource.com/289900
Trybot-Ready: Furquan Shaikh 
Tested-by: Furquan Shaikh 
Reviewed-by: Vincent Palatin 
Reviewed-by: Randall Spangler 
Commit-Queue: Furquan Shaikh

futility: Compute / verify root key hash

2015-07-21T21:11:28+00:00

Ryu will store a hash of the GBB root key in a struct inside its boot
block.  Add a vb2_ryu_root_key_hash struct for that.

If 'futility gbb_utility' is used to set the root key, also look for a
root key hash struct and fill it in.  No error if not found, because
this needs to work on other platforms where the struct is not present.
This way, we don't need to change the signing scripts.

Added a --roothash option which can be used to check if the root key
hash is found, and if so, whether it's empty, valid, or invalid.

BUG=chromium:511405
BRANCH=ryu
TEST=manual

    Take any existing image.bin.
    cp image.bin image.orig

    gbb_utility --roothash image.bin
    - ryu root hash not found

    Extract the root key
    gbb_utility -k rootkey.bin image.bin
    - exported root_key to file: rootkey.bin

    Now, append a blank ryu root hash struct to it
    echo '0000000: 5274 4b79 4861 7368 0100 0000 3000 0000' | xxd -r >> image.bin
    echo '0000000: 0000 0000 0000 0000 0000 0000 0000 0000' | xxd -r >> image.bin
    echo '0000000: 0000 0000 0000 0000 0000 0000 0000 0000' | xxd -r >> image.bin

    Nothing is set yet
    gbb_utility --roothash image.bin
    - ryu root hash is unset

    Setting the root key also sets the root hash
    gbb_utility -s -k rootkey.bin image.bin
    - import root_key from rootkey.bin: success
    - calculate ryu root hash: success
    successfully saved new image to: image.bin

    See, it verifies
    gbb_utility --roothash image.bin
    - ryu root hash verified

    Now, append a bad ryu root hash struct to it
    cp image.orig image.bin
    echo '0000000: 5274 4b79 4861 7368 0100 0000 3000 0000' | xxd -r >> image.bin
    echo '0000000: 0001 0000 0000 0000 0000 0000 0000 0000' | xxd -r >> image.bin
    echo '0000000: 0000 0000 0000 0000 0000 0000 0000 0000' | xxd -r >> image.bin

    See, it fails
    gbb_utility --roothash image.bin
    - ryu root hash does not verify

    Make sure the library doesn't contain the magic string
    strings `which futility` | grep RtKyHash
    (should be no output)

Change-Id: Ib46f93cac0f2b532bada4b187ae48efcf4926702
Signed-off-by: Randall Spangler 
Reviewed-on: https://chromium-review.googlesource.com/286237
Reviewed-by: Furquan Shaikh

crossystem: Add Skylake PCH GPIO controller ID

2015-07-21T06:07:18+00:00

Add the GPIO controller ID that is used in the Skylake PCH
so it can properly export and use GPIOs that are exported
in VBNV for write protect.

BUG=chrome-os-partner:42560
BRANCH=none
TEST=verify crossystem output with and without WP enabled

Change-Id: Ic85c202bd0ca15c154c10481926ef18bafe3fac5
Signed-off-by: Duncan Laurie 
Reviewed-on: https://chromium-review.googlesource.com/286827
Reviewed-by: Aaron Durbin

image_signing: Add more description to set_gbb_flags.

2015-07-21T04:50:36+00:00

There are two new GBB flags added (lid/fastboot) and we should update the
description in set_gbb_flags.

BRANCH=none
BUG=none
TEST=emerge-link vboot_reference

Change-Id: I0d16df03e9427ec1c8780fbb6be10c31eed9bf9e
Signed-off-by: Hung-Te Lin 
Reviewed-on: https://chromium-review.googlesource.com/286052
Reviewed-by: Bill Richardson

crossystem: Add skylake platform IDs

2015-07-21T04:50:29+00:00

Add the skylake-u and skylake-y vendor/device IDs so it can be
reported by crossystem.

BUG=chrome-os-partner:42560
BRANCH=none
TEST=run "crossystem platform_family" on glados

Change-Id: I5f9b92d404166e56d77cf8b0cd627a3a0b63bedf
Signed-off-by: Duncan Laurie 
Reviewed-on: https://chromium-review.googlesource.com/286921
Reviewed-by: Aaron Durbin

crossytem:Fix the write protect line gpio value

2015-07-14T03:30:32+00:00

For crossystem to work correctly on Strago/Cyan,
add Braswell string and correct GPIO offset
calculations.
In Braswell, write protect line is MF_ISH_GPIO_4
as encoded as 0x10016 where the GPEAST offset
(COMMUNITY_OFFSET_GPEAT) is 0x10000

BUG=chrome-os-partner:40835
BRANCH=None
TEST=test_that -b   platform_Crossystem

Change-Id: I365f3d6ca9f3ac7ef50abb9b2ba13f184d39c100
Signed-off-by: John Zhao 
Signed-off-by: Arindam Roy 
Reviewed-on: https://chromium-review.googlesource.com/274841
Reviewed-by: Aaron Durbin 
Commit-Queue: Bernie Thompson

crossystem: Revise description of sw_wpsw_boot.

2015-07-09T12:30:38+00:00

The sw_wpsw_boot was made for some feature that was almost never completed, and
only makes sense on Baytrail platforms. To prevent confusion we should address
that in the crossystem description.

BRANCH=none
BUG=chromium:508269
TEST=make test

Change-Id: I1fbc7a0e9e8c1f8503ae8ae9dfb6e80c8da892e3
Reviewed-on: https://chromium-review.googlesource.com/284425
Tested-by: Hung-Te Lin 
Reviewed-by: Bill Richardson 
Commit-Queue: Hung-Te Lin

crossystem: Add check for "mkbp" back

2015-06-30T10:47:49+00:00

We may have been over-zealous earlier when trying to eliminate
references to mkbp. Since crossystem runs on all ChromeOS devices,
this re-adds "mkbp" back to mitigate the risk of encountering
problems on systems running newer versions of ChromeOS but with
older firmware.

BUG=chrome-os-partner:21097
BRANCH=none
TEST=Compiled for veyron_brain

Change-Id: Ia0086687fbc3a1195b062367ccb6ee5c41acd026
Signed-off-by: David Hendricks 
Reviewed-on: https://chromium-review.googlesource.com/282602
Reviewed-by: Randall Spangler 
Reviewed-by: Julius Werner

crossystem: Check for "cros-ec" instead of "mkbp" for *NvStorage

2015-06-25T02:11:47+00:00

This changes the string we look for in the devicetree on ARM
platforms to look for "cros-ec" (DT uses dashes instead of
underscores) instead of "mkbp".

BUG=chrome-os-partner:21097
CQ-DEPEND=CL:273347
BRANCH=none
TEST=with depthcharge patch applied, ran crossystem on newly
booted system and saw VBNV-related variables turn out the same.

Signed-off-by: David Hendricks 
Change-Id: Iac43f5381327eb878a8d0db606b78bb7bdce816f
Reviewed-on: https://chromium-review.googlesource.com/273391
Commit-Queue: Stefan Reinauer 
Tested-by: Stefan Reinauer 
Reviewed-by: Stefan Reinauer