delta/coreboot/vboot.git, branch stabilize-7077.134.B

GBB: Add missing flag LID_SHUTDOWN to vb2_gbb_flag structure

2015-05-16T04:17:26+00:00

BUG=None
BRANCH=None
TEST=Compiles successfully

Change-Id: I80a501efc3940ca5657dc143c0ab3c6b020dc1e0
Signed-off-by: Furquan Shaikh 
Reviewed-on: https://chromium-review.googlesource.com/271620
Trybot-Ready: Furquan Shaikh 
Tested-by: Furquan Shaikh 
Reviewed-by: Aaron Durbin 
Commit-Queue: Furquan Shaikh

GBB: Add flag for forcing full fastboot capability in firmware

2015-05-16T04:17:21+00:00

This flag is equivalent to FORCE_DEV_BOOT_USB. It allows full fastboot
capability in firmware for developer mode.

BUG=chrome-os-partner:40196
BRANCH=None
TEST=Compiles successfully for smaug.

Change-Id: I82a2ebe7a8b3bbf38694ab81ca2678624f77fca1
Signed-off-by: Furquan Shaikh 
Reviewed-on: https://chromium-review.googlesource.com/271410
Reviewed-by: Randall Spangler 
Commit-Queue: Furquan Shaikh 
Trybot-Ready: Furquan Shaikh 
Tested-by: Furquan Shaikh

nvstorage: Add new flag VBNV_DEV_BOOT_FASTBOOT_FULL_CAP

2015-05-16T04:17:16+00:00

Add a new flag to nvstorage for controlling fastboot capabilities
offered in firmware in dev-mode. By default, value of this flag would
be ignored in normal mode. Thus, when fastboot-based recovery is
entered from normal mode, only limited capability would be available
in firmware.

After switching to dev-mode, this flag can be set automatically by
user script after performing the wipe or it can be set manually using
crossystem. When fastboot-based recovery is entered from dev mode and
this flag is set, it will provide full fastboot capability in the
firmware.

BUG=chrome-os-partner:40196
BRANCH=None
TEST=Compiles successfully for smaug. make runalltests successful.

Change-Id: I761a9ab304dd90f0b73081acc9ce1f8d9052325f
Signed-off-by: Furquan Shaikh 
Reviewed-on: https://chromium-review.googlesource.com/271369
Reviewed-by: Aaron Durbin 
Reviewed-by: Randall Spangler 
Commit-Queue: Furquan Shaikh 
Trybot-Ready: Furquan Shaikh 
Tested-by: Furquan Shaikh

chromeos-tpm-recovery: Convert to manual TPM reset script for developers

2015-05-16T01:42:28+00:00

chromeos-tpm-recovery has not been used for anything in forever (see
CL:238236), but it is still installed on every image. Resetting the TPM
(e.g. to resolve rollback issues when reflashing an MP-signed device to
dev firmware) is a common request by developers, and I get tired of
always digging out the required tpmc commands manually again. Let's
repurpose this script as a simple one-shot tool for developers to reset
their TPM, so the next time someone asks we can just tell them 'boot a
test image in recovery mode and run chromeos-tpm-recovery'.

BRANCH=none
BUG=chromium:419942
TEST=Ran on a Jerry, confirmed that TPM spaces were reset.

Change-Id: Ia95246cfed3dc9b0c6fdb0481218e3ae14d8318a
Signed-off-by: Julius Werner 
Reviewed-on: https://chromium-review.googlesource.com/271512
Reviewed-by: Bill Richardson 
Reviewed-by: Luigi Semenzato

vboot2: Support VB2_GBB_FLAG_DISABLE_FW_ROLLBACK_CHECK

2015-05-16T01:42:20+00:00

Looks like the DISABLE_FW_ROLLBACK_CHECK GBB flag (0x200) was forgotten
in the vboot2 implementation. It's too late for Veyron now, but let's at
least fix it for future devices.

BRANCH=none
BUG=None
TEST=make runtests

Change-Id: I867f7aada28be3897efda73a6bdc3b0848c23dca
Signed-off-by: Julius Werner 
Reviewed-on: https://chromium-review.googlesource.com/271419
Reviewed-by: Bill Richardson

Detect GBB 1.1 also as impcompatible version

2015-05-14T02:25:57+00:00

Older GBB headers (e.g. 1.0 and 1.1) do not have hwid_digest. In such cases,
PCR1 is currently extended from 0, causing a remote attestation failure.
This change makes all GBB headers older than 1.2 incompatible.

BUG=none
BRANCH=tot
TEST=make -j runtests

Change-Id: I7a3b19c2da325a3fa4b9c1fe06ed6f43cb51fb9e
Signed-off-by: Daisuke Nojiri 
Reviewed-on: https://chromium-review.googlesource.com/270796
Reviewed-by: Bill Richardson

vboot2: Add support for kernel version secure data space

2015-05-13T22:23:42+00:00

Holds kernel rollback information.  Will be used by vboot 2.0 kernel
verification.

BUG=chromium:487699
BRANCH=none
TEST=make -j runtests

Change-Id: Ib4a70e943ebd79aac06404df09cf4ce62d719201
Signed-off-by: Randall Spangler 
Reviewed-on: https://chromium-review.googlesource.com/270626
Reviewed-by: Bill Richardson

vboot1: Condition default legacy boot on dev_boot_legacy

2015-05-12T01:17:23+00:00

This patch fixes what I think is an inconsistency in the existing legacy
boot behavior: when the GBB flag that defaults to legacy boot is set,
running out the 30 second timer would still boot legacy mode even if
dev_boot_legacy is not actually set (whereas pressing CTRL+L in the
same configuration would beep and refuse).

This patch makes both legacy boot trgiggers check the same condition
before boot. This does not restrict functionality since anyone who sets
the DEFAULT_DEV_BOOT_LEGACY GBB flag could simply set
FORCE_DEV_BOOT_LEGACY at the same time. It does however open up an
interesting new use case of using NVRAM to change back-and-forth between
legacy and normal developer mode (after GBB flags are changed once and
write-protection is enabled again).

If this is updated in the field it might lock existing devices out of
legacy mode... however, since by far the most common GBB flag
combination recommended on the internet seems to be 0x489 (including
FORCE_DEV_BOOT_LEGACY), I doubt this would be a problem in practice.

BRANCH=tbd
BUG=chrome-os-partner:39999
TEST=Booted with GBB flags 0x4b9 and 0x439, observed difference.

Change-Id: If6a6d99ab2cf116db2237fdc3df97fc22a68251c
Signed-off-by: Julius Werner 
Reviewed-on: https://chromium-review.googlesource.com/270182
Reviewed-by: Duncan Laurie

vboot1: Lock TPM physical presence (kernel rollback) on legacy boot

2015-05-12T01:17:16+00:00

Even though legacy boot is an unsafe mode that has to be manually
initiated by the user, we should still lock the kernel TPM space to be
consistent with existing developer mode practice.

BRANCH=tbd
BUG=chrome-os-partner:39999
TEST=Spent over an hour unsuccessfully trying to get SeaBIOS to boot a
Chromium test image on my Falco. Decided that's not worth it an just
tested the firmware side of this (pressing CTRL+L when legacy mode is
enabled and disabled, multiple times, with and without GBB flag
DEFAULT_DEV_BOOT_LEGACY).

Change-Id: I3b02b59a9055431d222c0c7446de2cd7d2e0bb82
Signed-off-by: Julius Werner 
Reviewed-on: https://chromium-review.googlesource.com/270181
Reviewed-by: Duncan Laurie

Make SHA library accessible to calling firmware

2015-05-07T00:00:36+00:00

And add a vb2_digest_buffer() call which produces the hash of a buffer
all in a single function call.  That function actually already
existed, but was in a unit test file rather than in the library
itself.  It's a small function, so adding it won't increase the size
of the library significantly - or at all, on platforms which compile
with -ffunction-sections.

This allows coreboot to reuse this SHA library for hashing CBFS
entries and file data.  All it has to do is #define
NEED_VB2_SHA_LIBRARY and then #include "vb2_api.h".

BUG=chromium:482652
BRANCH=none
TEST=make -j runtests

Change-Id: Ice2d0929324b58b2665f3989b5b887225f6ef61e
Signed-off-by: Randall Spangler 
Reviewed-on: https://chromium-review.googlesource.com/269523
Reviewed-by: Julius Werner