<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/coreboot/vboot.git, branch stabilize-6480.B</title>
<subtitle>review.coreboot.org: vboot.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/'/>
<entry>
<title>Revert "vboot: Plumb the two disk sizes and 'gpt on device' param through"</title>
<updated>2014-11-15T05:59:54+00:00</updated>
<author>
<name>Julius Werner</name>
<email>jwerner@chromium.org</email>
</author>
<published>2014-11-15T03:02:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=79a9e0e63fd1001a3f9615f96c09acba5f20250d'/>
<id>79a9e0e63fd1001a3f9615f96c09acba5f20250d</id>
<content type='text'>
This reverts commit 5040a945dfd0dd305d3ca8e923b8bf0bd5c6528e.

This patch breaks booting any image (both fixed and
removable) on Veyron_Pinky (and presumably every other
non-NAND board?). By the power vested in me through the
office of ChromeOS tree sheriff (well, five hours early
but whatever) it is hereby reverted!

BUG=chromium:425677
BRANCH=none
TEST=Can successfully boot on Veyron_Pinky again.

Change-Id: I9323a3d5e34491337fc7eb09dd00d845ac42997d
Reviewed-on: https://chromium-review.googlesource.com/229963
Reviewed-by: Julius Werner &lt;jwerner@chromium.org&gt;
Commit-Queue: Julius Werner &lt;jwerner@chromium.org&gt;
Tested-by: Julius Werner &lt;jwerner@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reverts commit 5040a945dfd0dd305d3ca8e923b8bf0bd5c6528e.

This patch breaks booting any image (both fixed and
removable) on Veyron_Pinky (and presumably every other
non-NAND board?). By the power vested in me through the
office of ChromeOS tree sheriff (well, five hours early
but whatever) it is hereby reverted!

BUG=chromium:425677
BRANCH=none
TEST=Can successfully boot on Veyron_Pinky again.

Change-Id: I9323a3d5e34491337fc7eb09dd00d845ac42997d
Reviewed-on: https://chromium-review.googlesource.com/229963
Reviewed-by: Julius Werner &lt;jwerner@chromium.org&gt;
Commit-Queue: Julius Werner &lt;jwerner@chromium.org&gt;
Tested-by: Julius Werner &lt;jwerner@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>vboot: Plumb the two disk sizes and 'gpt on device' param through</title>
<updated>2014-11-15T01:13:52+00:00</updated>
<author>
<name>Dan Ehrenberg</name>
<email>dehrenberg@chromium.org</email>
</author>
<published>2014-11-05T00:06:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=5040a945dfd0dd305d3ca8e923b8bf0bd5c6528e'/>
<id>5040a945dfd0dd305d3ca8e923b8bf0bd5c6528e</id>
<content type='text'>
To support an external GPT, disks have two new attributes:
- A binary flag indicating whether the GPT is in the same address
  space as the payloads or a separate one.
- The number of sectors of the streaming portion of storage, as
  opposed to the portion containing the GPT.
These have been added elsewhere to GptData (in cgptlib) and BlockDev
(in depthcharge). This patch adds the plumbing between those, including
in the DiskInfo interface between the firmware and vboot.

BUG=chromium:425677
BRANCH=none
TEST=Interactively wrote the GPT with cgpt and observed the following
boot with depthcharge to read the GPT from SPI and then read from
the proper locations in NAND flash.
make runalltests passes.

Signed-off-by: Dan Ehrenberg &lt;dehrenberg@chromium.org&gt;
Change-Id: I5a77e417aea8ee9442d18c200d1b073aa5375ecf
Reviewed-on: https://chromium-review.googlesource.com/228943
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Reviewed-by: Bill Richardson &lt;wfrichar@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
To support an external GPT, disks have two new attributes:
- A binary flag indicating whether the GPT is in the same address
  space as the payloads or a separate one.
- The number of sectors of the streaming portion of storage, as
  opposed to the portion containing the GPT.
These have been added elsewhere to GptData (in cgptlib) and BlockDev
(in depthcharge). This patch adds the plumbing between those, including
in the DiskInfo interface between the firmware and vboot.

BUG=chromium:425677
BRANCH=none
TEST=Interactively wrote the GPT with cgpt and observed the following
boot with depthcharge to read the GPT from SPI and then read from
the proper locations in NAND flash.
make runalltests passes.

Signed-off-by: Dan Ehrenberg &lt;dehrenberg@chromium.org&gt;
Change-Id: I5a77e417aea8ee9442d18c200d1b073aa5375ecf
Reviewed-on: https://chromium-review.googlesource.com/228943
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Reviewed-by: Bill Richardson &lt;wfrichar@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>vboot: Fix load_kernel_tests to call the right cgpt</title>
<updated>2014-11-14T23:57:00+00:00</updated>
<author>
<name>Nam T. Nguyen</name>
<email>namnguyen@chromium.org</email>
</author>
<published>2014-11-13T17:12:47+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=e8dfacf141844ec1c2c78ecc98d85b3698bf946c'/>
<id>e8dfacf141844ec1c2c78ecc98d85b3698bf946c</id>
<content type='text'>
load_kernel_tests called out to "cgpt" as is and this is interpreted as
"/usr/bin/cgpt" on the host. This CL fixes that by using the right
version in "build/install_for_test/bin/cgpt".

BUG=none
BRANCH=none
TEST=rename /usr/bin/cgpt; make runtests

Change-Id: I65ee0f271b081da6f719764e22c14fef05cdb65b
Reviewed-on: https://chromium-review.googlesource.com/229590
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Commit-Queue: Nam Nguyen &lt;namnguyen@chromium.org&gt;
Tested-by: Nam Nguyen &lt;namnguyen@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
load_kernel_tests called out to "cgpt" as is and this is interpreted as
"/usr/bin/cgpt" on the host. This CL fixes that by using the right
version in "build/install_for_test/bin/cgpt".

BUG=none
BRANCH=none
TEST=rename /usr/bin/cgpt; make runtests

Change-Id: I65ee0f271b081da6f719764e22c14fef05cdb65b
Reviewed-on: https://chromium-review.googlesource.com/229590
Reviewed-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Commit-Queue: Nam Nguyen &lt;namnguyen@chromium.org&gt;
Tested-by: Nam Nguyen &lt;namnguyen@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>vboot2: Add api-level functions to use new data structures</title>
<updated>2014-11-14T23:56:55+00:00</updated>
<author>
<name>Randall Spangler</name>
<email>rspangler@chromium.org</email>
</author>
<published>2014-11-13T00:20:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=efa37b87f2b4cd4b4f515e96201502ae0408cec7'/>
<id>efa37b87f2b4cd4b4f515e96201502ae0408cec7</id>
<content type='text'>
And associated unit tests.

And fix a memory overwrite in the old vb_api_tests.c, which apparently
didn't touch a critical piece of the shared work buffer, but was still
wrong.  (This was a problem in the test, not in the code being
tested.)

BUG=chromium:423882
BRANCH=none
TEST=VBOOT2=1 make runtests

Change-Id: I322fb7e6bb5214b0adcf5d6d48a0cd238abba88e
Signed-off-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/229738
Reviewed-by: Bill Richardson &lt;wfrichar@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
And associated unit tests.

And fix a memory overwrite in the old vb_api_tests.c, which apparently
didn't touch a critical piece of the shared work buffer, but was still
wrong.  (This was a problem in the test, not in the code being
tested.)

BUG=chromium:423882
BRANCH=none
TEST=VBOOT2=1 make runtests

Change-Id: I322fb7e6bb5214b0adcf5d6d48a0cd238abba88e
Signed-off-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/229738
Reviewed-by: Bill Richardson &lt;wfrichar@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>vboot2: Split vb2_guid into its own header file</title>
<updated>2014-11-14T23:56:47+00:00</updated>
<author>
<name>Randall Spangler</name>
<email>rspangler@chromium.org</email>
</author>
<published>2014-11-14T17:39:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=7c1eee09eff54c6e60a3b261e6df790c11331695'/>
<id>7c1eee09eff54c6e60a3b261e6df790c11331695</id>
<content type='text'>
This allows the api header to include it without pulling in the rest
of the vboot2 internal structs.

No functional changes; just moving a struct definition.

BUG=chromium:423882
BRANCH=none
TEST=VBOOT2=1 make runtests

Change-Id: Ife9408f9b597939a3cc85a10d534108e12f2d739
Signed-off-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/229793
Reviewed-by: Daisuke Nojiri &lt;dnojiri@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This allows the api header to include it without pulling in the rest
of the vboot2 internal structs.

No functional changes; just moving a struct definition.

BUG=chromium:423882
BRANCH=none
TEST=VBOOT2=1 make runtests

Change-Id: Ife9408f9b597939a3cc85a10d534108e12f2d739
Signed-off-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/229793
Reviewed-by: Daisuke Nojiri &lt;dnojiri@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>vboot: cgpt: Treat drive_path as the GPT storage</title>
<updated>2014-11-14T22:46:59+00:00</updated>
<author>
<name>Nam T. Nguyen</name>
<email>namnguyen@chromium.org</email>
</author>
<published>2014-11-14T03:30:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=ab899591808dd3e5f955ab7693b54a83389cd35f'/>
<id>ab899591808dd3e5f955ab7693b54a83389cd35f</id>
<content type='text'>
Previously, "cgpt" called out to "flashrom" directly to read and write
NOR area. This CL removes that dependency and always treats "drive_path"
as the storage of GPT structs. This makes it consistent that whatever
device that cgpt reads from or writes to is always the device that
stores GPT structs. We only need to pass in the size of the drive that
contains the partitions, but we do not need to access to that drive.

More information is in the bug.

BUG=chromium:432611
BRANCH=none
TEST=unittest
CQ-DEPEND=CL:228942

Change-Id: Id0139adf70463cec4f2924de8b9a4725dbec822b
Reviewed-on: https://chromium-review.googlesource.com/229736
Reviewed-by: Bill Richardson &lt;wfrichar@chromium.org&gt;
Commit-Queue: Nam Nguyen &lt;namnguyen@chromium.org&gt;
Tested-by: Nam Nguyen &lt;namnguyen@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Previously, "cgpt" called out to "flashrom" directly to read and write
NOR area. This CL removes that dependency and always treats "drive_path"
as the storage of GPT structs. This makes it consistent that whatever
device that cgpt reads from or writes to is always the device that
stores GPT structs. We only need to pass in the size of the drive that
contains the partitions, but we do not need to access to that drive.

More information is in the bug.

BUG=chromium:432611
BRANCH=none
TEST=unittest
CQ-DEPEND=CL:228942

Change-Id: Id0139adf70463cec4f2924de8b9a4725dbec822b
Reviewed-on: https://chromium-review.googlesource.com/229736
Reviewed-by: Bill Richardson &lt;wfrichar@chromium.org&gt;
Commit-Queue: Nam Nguyen &lt;namnguyen@chromium.org&gt;
Tested-by: Nam Nguyen &lt;namnguyen@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>vboot: cgpt: fix my_lba of the secondary GPT</title>
<updated>2014-11-14T22:46:54+00:00</updated>
<author>
<name>Dan Ehrenberg</name>
<email>dehrenberg@chromium.org</email>
</author>
<published>2014-11-07T00:22:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=a524a3a51591618c1395cb9e1238ee72b3f5e767'/>
<id>a524a3a51591618c1395cb9e1238ee72b3f5e767</id>
<content type='text'>
Previously, my_lba of the secondary GPT was recorded as if that
GPT was written at the end of the device. This patch tweaks
my_lba to report where it is in the random-access GPT address space,
namely at the end of that space.

TEST=Compiled it into the firmware and observed the firmware to update
the my_lba field of the secondary GPT.
BRANCH=none
BUG=chromium:425677

Signed-off-by: Dan Ehrenberg &lt;dehrenberg@chromium.org&gt;

Change-Id: I88791fb2cff1086351ca8a3adeef675c4a88cc9a
Reviewed-on: https://chromium-review.googlesource.com/228942
Reviewed-by: Bill Richardson &lt;wfrichar@chromium.org&gt;
Commit-Queue: Daniel Ehrenberg &lt;dehrenberg@chromium.org&gt;
Tested-by: Daniel Ehrenberg &lt;dehrenberg@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Previously, my_lba of the secondary GPT was recorded as if that
GPT was written at the end of the device. This patch tweaks
my_lba to report where it is in the random-access GPT address space,
namely at the end of that space.

TEST=Compiled it into the firmware and observed the firmware to update
the my_lba field of the secondary GPT.
BRANCH=none
BUG=chromium:425677

Signed-off-by: Dan Ehrenberg &lt;dehrenberg@chromium.org&gt;

Change-Id: I88791fb2cff1086351ca8a3adeef675c4a88cc9a
Reviewed-on: https://chromium-review.googlesource.com/228942
Reviewed-by: Bill Richardson &lt;wfrichar@chromium.org&gt;
Commit-Queue: Daniel Ehrenberg &lt;dehrenberg@chromium.org&gt;
Tested-by: Daniel Ehrenberg &lt;dehrenberg@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>vboot2: load keyblock and preamble from new-style structs</title>
<updated>2014-11-14T22:46:42+00:00</updated>
<author>
<name>Randall Spangler</name>
<email>rspangler@chromium.org</email>
</author>
<published>2014-11-10T21:40:52+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=837b408c92d02108cbb16a97769675f39598d576'/>
<id>837b408c92d02108cbb16a97769675f39598d576</id>
<content type='text'>
And associated unit tests.

BUG=chromium:423882
BRANCH=none
TEST=VBOOT2=1 make runtests

Change-Id: I6565d8f5da947b4874a656a61051df1a4ce415c7
Signed-off-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/229163
Reviewed-by: Daisuke Nojiri &lt;dnojiri@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
And associated unit tests.

BUG=chromium:423882
BRANCH=none
TEST=VBOOT2=1 make runtests

Change-Id: I6565d8f5da947b4874a656a61051df1a4ce415c7
Signed-off-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/229163
Reviewed-by: Daisuke Nojiri &lt;dnojiri@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>vboot: cgpt: Support writing GPT structs to NOR flash</title>
<updated>2014-11-13T18:29:09+00:00</updated>
<author>
<name>Nam T. Nguyen</name>
<email>namnguyen@chromium.org</email>
</author>
<published>2014-10-24T20:20:39+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=6ee52d9a929d00e871e7316240b54f381146fbc6'/>
<id>6ee52d9a929d00e871e7316240b54f381146fbc6</id>
<content type='text'>
This CL allows the GPT headers and partition entry arrays to be stored
in a NOR flash device. Instead of treating both the NOR and NAND devices
as one (in a sandwich way), this CL writes and reads the GPT structs
independently of the actual device that houses the partitions.
Therefore, the first usable LBA of the partitions will be at 0, and the
last usable LBA is at the end of the NAND.

  +------------------------+
  | NOR houses GPT structs |
  +------------------------+
        |
  0     |  Index into
  v     v
  +------------------------+
  | NAND houses partitions |
  +------------------------+

Note that the "my_lba", "alternate_lba", "entries_lba" in the GPT headers
are no longer meaningful.

Consumers of cgptlib will have to set "stored_on_device" to either
GPT_STORED_ON_DEVICE or GPT_STORED_OFF_DEVICE, and "gpt_drive_sectors"
to the number of 512-byte sectors available to store GPT structs.

The NOR read and write operations are done by "flashrom".

BUG=chromium:425677
BRANCH=none
TEST=unittest
TEST=build with DEBUG, cgpt create/add/show on a stumpy-moblab

Change-Id: I083b3c94da3b0bb3da1a7b10c6969774080a2afd
Reviewed-on: https://chromium-review.googlesource.com/226800
Reviewed-by: Nam Nguyen &lt;namnguyen@chromium.org&gt;
Commit-Queue: Nam Nguyen &lt;namnguyen@chromium.org&gt;
Tested-by: Nam Nguyen &lt;namnguyen@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This CL allows the GPT headers and partition entry arrays to be stored
in a NOR flash device. Instead of treating both the NOR and NAND devices
as one (in a sandwich way), this CL writes and reads the GPT structs
independently of the actual device that houses the partitions.
Therefore, the first usable LBA of the partitions will be at 0, and the
last usable LBA is at the end of the NAND.

  +------------------------+
  | NOR houses GPT structs |
  +------------------------+
        |
  0     |  Index into
  v     v
  +------------------------+
  | NAND houses partitions |
  +------------------------+

Note that the "my_lba", "alternate_lba", "entries_lba" in the GPT headers
are no longer meaningful.

Consumers of cgptlib will have to set "stored_on_device" to either
GPT_STORED_ON_DEVICE or GPT_STORED_OFF_DEVICE, and "gpt_drive_sectors"
to the number of 512-byte sectors available to store GPT structs.

The NOR read and write operations are done by "flashrom".

BUG=chromium:425677
BRANCH=none
TEST=unittest
TEST=build with DEBUG, cgpt create/add/show on a stumpy-moblab

Change-Id: I083b3c94da3b0bb3da1a7b10c6969774080a2afd
Reviewed-on: https://chromium-review.googlesource.com/226800
Reviewed-by: Nam Nguyen &lt;namnguyen@chromium.org&gt;
Commit-Queue: Nam Nguyen &lt;namnguyen@chromium.org&gt;
Tested-by: Nam Nguyen &lt;namnguyen@chromium.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>vboot2: Add code and tests for verifying vb2_fw_preamble2</title>
<updated>2014-11-12T19:57:57+00:00</updated>
<author>
<name>Randall Spangler</name>
<email>rspangler@chromium.org</email>
</author>
<published>2014-11-05T01:50:32+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/coreboot/vboot.git/commit/?id=43e0a9ed6c0b332631442fcf581e7456d62e4532'/>
<id>43e0a9ed6c0b332631442fcf581e7456d62e4532</id>
<content type='text'>
This is the last low-level data structure verification code for the
new data structures.  Subsequent changes are the next level up the
food chain.

BUG=chromium:423882
BRANCH=none
TEST=VBOOT2=1 make runtests

Change-Id: I2e45106c27447eb624c1ed562e40b98088249742
Signed-off-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/228360
Reviewed-by: Daisuke Nojiri &lt;dnojiri@chromium.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is the last low-level data structure verification code for the
new data structures.  Subsequent changes are the next level up the
food chain.

BUG=chromium:423882
BRANCH=none
TEST=VBOOT2=1 make runtests

Change-Id: I2e45106c27447eb624c1ed562e40b98088249742
Signed-off-by: Randall Spangler &lt;rspangler@chromium.org&gt;
Reviewed-on: https://chromium-review.googlesource.com/228360
Reviewed-by: Daisuke Nojiri &lt;dnojiri@chromium.org&gt;
</pre>
</div>
</content>
</entry>
</feed>
