delta/coreboot/vboot.git, branch stabilize-14150.881.B

vboot: Remove unnecessary flag unset operations

2021-08-12T08:13:14+00:00

Since all flags are initialized as 0 in vb2api_init(),
some flag unset operations are not needed.

Edit few comments to make it more accurate.

BUG=none
TEST=export CC=x86_64-pc-linux-gnu-clang DEBUG=1; \
     make -j32 test_setup && make -j32 runtests;
BRANCH=none

Signed-off-by: edisonhello 
Change-Id: I0129f43342598195800ff671b965100d3d568564
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3066803
Reviewed-by: Julius Werner 
Reviewed-by: Yu-Ping Wu

vboot/misc: Add validity check in vb2api_enable_developer_mode

2021-08-12T08:13:12+00:00

Check vb2api_allow_recovery before actual changes in
vb2api_enable_developer_mode.

Add new API error type VB2_ERROR_API_ENABLE_DEV_NOT_ALLOWED in
vb2_error_t.

Add spaces in the output message of vb2_misc_tests for indentation.

BUG=b:172339016
TEST=export CC=x86_64-pc-linux-gnu-clang DEBUG=1 DETACHABLE=0; \
     make -j32 test_setup && make -j32 runtests;
TEST=export CC=x86_64-pc-linux-gnu-clang DEBUG=1 DETACHABLE=1; \
     make -j32 test_setup && make -j32 runtests;
TEST=Hayato booted into developer mode
BRANCH=none

Change-Id: Ifebdd01ca87cf944c394907eca73a09fc3bf5457
Signed-off-by: edisonhello 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3056240
Reviewed-by: Julius Werner

vboot/ui: Check allocated pointer before using the pointer

2021-08-10T09:28:35+00:00

Change the order of checking whether the allocated pointer is null
and memset the allocated pointer. Prevent using a null pointer, which
may cause segmentation fault.

BUG=none
TEST=export CC=x86_64-pc-linux-gnu-clang DEBUG=1 \
     make -j32 test_setup && make -j32 runtests;
TEST=emerge-asurada depthcharge
BRANCH=none

Signed-off-by: edisonhello 
Change-Id: I5fc91b5157b32b6b7263d580998eceb6efe9a63a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3077962
Reviewed-by: Yu-Ping Wu

vboot/tests: Add test_fail function and TEST_FAIL macro

2021-08-04T02:51:16+00:00

Add test_fail function that will check whether the result value is
not 0.

Add TEST_FAIL macro that will call test_fail.

BUG=none
TEST=export CC=x86_64-pc-linux-gnu-clang DEBUG=1; \
     make -j32 test_setup && make -j32 runtests;
BRANCH=none

Change-Id: I4dfe6a887780f70fbcb753828cfb5500ed810b72
Signed-off-by: edisonhello 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3060562
Reviewed-by: Yu-Ping Wu 
Reviewed-by: Julius Werner 
Commit-Queue: Yu-Ping Wu

vboot: Publicize and create functions for UI migration

2021-07-30T17:37:19+00:00

Publicize vb2api_enable_developer_mode, vb2api_allow_recovery and
VbTryLoadKernel, and modify corresponding parts in tests.

Create vb2api_disable_dev_request, vb2api_request_diagnostics for
wrapping vb2_nv_set(ctx, VB2_NV_DISABLE_DEV_REQUEST, 1) and
vb2_nv_set(ctx, VB2_NV_DIAG_REQUEST, 1).

BUG=b:172339016
TEST=export CC=x86_64-pc-linux-gnu-clang DEBUG=1 DETACHABLE=0; \
     make -j32 test_setup && make -j32 runtests;
TEST=export CC=x86_64-pc-linux-gnu-clang DEBUG=1 DETACHABLE=1; \
     make -j32 test_setup && make -j32 runtests;
TEST=Hayato booted into developer mode
BRANCH=none

Change-Id: I0211a63ed58ce862ee3e17b4835c675544f773a4
Signed-off-by: edisonhello 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3053541
Reviewed-by: Yu-Ping Wu

vboot: Add DEV_BOOT_*ALLOWED in ctx->flags

2021-07-30T17:37:18+00:00

Add DEV_BOOT_ALLOWED, DEV_BOOT_ALTFW_ALLOWED,
DEV_BOOT_EXTERNAL_ALLOWED in ctx->flags, which can be used by
external functions. These flags will be filled in
VbSelectAndLoadKernel, before calling any menu function.

In 2ui.c and 2ui_screen.c, all function calls to vb2_dev_boot_*allowed
are replaced with corresponding flags in ctx->flags.

Remove the parts of mocking these functions in unit tests, and set
ctx->flags instead in reset_common_data.

BUG=b:172339016
TEST=export CC=x86_64-pc-linux-gnu-clang DEBUG=1 DETACHABLE=0; \
     make -j32 test_setup && make -j32 runtests;
TEST=export CC=x86_64-pc-linux-gnu-clang DEBUG=1 DETACHABLE=1; \
     make -j32 test_setup && make -j32 runtests;
TEST=Hayato booted into developer mode
BRANCH=none

Signed-off-by: edisonhello 
Change-Id: Ida9f03557a92a1522d631fc04b281ce85f5049c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3041498
Reviewed-by: Yu-Ping Wu

vboot: add new OWNERS

2021-07-30T00:52:35+00:00

BUG=none
TEST=none
BRANCH=none

Signed-off-by: Joel Kitching 
Change-Id: I70f3de0edeeeabc31b97e4320e7ea420e8bdd2cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3060276
Tested-by: Joel Kitching 
Reviewed-by: Julius Werner 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Hung-Te Lin 
Commit-Queue: Julius Werner

signer: Implement retry logic for signing Android image

2021-07-29T06:36:19+00:00

This retries signing android image in case of integrity check failure.
The reason of failure is still unknown.

BUG=b:175081695
TEST=Locally image signing passed with adding temporary code that
     emulates random diff file error. Confirmed recovery happened
     and signing finished successfully.

BRANCH=none
Signed-off-by: Yury Khmel 
Change-Id: Iffc23145cae21f4f468b987d015f45fec95f29d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3057193
Reviewed-by: Mike Frysinger

vboot: Add vb2api_set_locale_id

2021-07-27T09:32:21+00:00

Add vb2api_set_locale_id to vboot2 API.

Replace the direct access to vb2_nv_get and vb2_nv_set in ui
functions with vb2api_get_locale_id and vb2api_set_locale_id.

BUG=b:172339016
TEST=export CC=x86_64-pc-linux-gnu-clang DEBUG=1 DIAGNOSTIC_UI=1 \
     MINIMAL=1; make -j32 test_setup && make -j32 runtests;
TEST=Hayato booted into developer mode
BRANCH=none

Signed-off-by: edisonhello 
Change-Id: I5a92e571eceed6a402d0d80caa567bb9d77341a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3041506
Commit-Queue: Yu-Ping Wu 
Reviewed-by: Yu-Ping Wu

vboot/ui: Use vb2api_gbb_get_flags instead of vb2_get_gbb

2021-07-27T09:32:20+00:00

Replace direct calls to vb2_get_gbb with vb2api_gbb_get_flags.

This is a preparation work for migrating ui codes from vboot to
depthcharge.

BUG=b:172339016
TEST=export CC=x86_64-pc-linux-gnu-clang DEBUG=1; \
     make -j32 test_setup && make -j32 runtests;
TEST=Hayato booted into developer mode
BRANCH=none

Change-Id: I69b1504c236df1c0b656cb1e6e28a4066d9fad63
Signed-off-by: edisonhello 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3041504
Commit-Queue: Yu-Ping Wu 
Reviewed-by: Yu-Ping Wu