delta/coreboot/vboot.git, branch stabilize-12669.B

futility: updater: Clean up hard-coded section names to preserve

2019-11-08T03:45:26+00:00

The following sections can be now deleted from hard-coded list:

- RO_PRESERVE: no boards use it.
- RO_FSG: new images have set the PRESERVE flag in CBFS.
- SI_GBE, SI_PDR: already using PRESERVE flag since fw branch is cut.

BUG=b:116326638,chromium:936768
TEST=make clean && make runtests

Change-Id: I99759949104bf4f1c1db3556e273923dcb1c5887
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1902841
Tested-by: Hung-Te Lin 
Auto-Submit: Hung-Te Lin 
Reviewed-by: Julius Werner 
Commit-Queue: Hung-Te Lin

vboot: remove VbExEcEnteringMode and friends

2019-11-06T03:49:12+00:00

After informing EC of the mode chosen by vboot, it is stored
in a global and never accessed again.  Remove this function,
its calls, and its tests.

Also note some significant issues which existed:
(1) Using accessor VbGetMode for tests, rather than just
    overriding VbExEcEnteringMode when needed.
(2) The tests checking the value sent to VbExEcEnteringMode
    (vboot_api_kernel2_tests and vboot_detach_menu_tests)
    actually call the function themselves.

BUG=b:124141368, chromium:1014379
TEST=make clean && make runtests
BRANCH=none

Change-Id: Ib8e510a1e1c663bb3f8238a9ad15e3e64d7350b0
Signed-off-by: Joel Kitching 
Cq-Depend: chromium:1864533
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1830239
Reviewed-by: Joel Kitching 
Tested-by: Joel Kitching 
Commit-Queue: Julius Werner

Revert "Clean up implicit fall through."

2019-11-05T22:45:39+00:00

This reverts commit 6a703f5b0edfdbf2eee72d59499f73585262a46f.

Reason for revert: This change breaks building coreboot

Original change's description:
> Clean up implicit fall through.
> 
> Directly use the __attribute__ ((fallthrough)) instead of
> a macro.
> This was suggested in CL:1772474.
> 
> BUG=chromium:997709
> TEST=CQ
> BRANCH=None
> 
> Change-Id: Ic6cd417d7c735395a4b136dbb0879a6f1716da98
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1897360
> Tested-by: Manoj Gupta 
> Reviewed-by: Julius Werner 
> Commit-Queue: Manoj Gupta 

Bug: chromium:997709
Change-Id: Icd0de8bcdee44d1b41f313a4f5aaba8108f734ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1899735
Reviewed-by: Mathew King 
Reviewed-by: Julius Werner 
Commit-Queue: Julius Werner 
Tested-by: Julius Werner

Clean up implicit fall through.

2019-11-05T15:51:53+00:00

Directly use the __attribute__ ((fallthrough)) instead of
a macro.
This was suggested in CL:1772474.

BUG=chromium:997709
TEST=CQ
BRANCH=None

Change-Id: Ic6cd417d7c735395a4b136dbb0879a6f1716da98
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1897360
Tested-by: Manoj Gupta 
Reviewed-by: Julius Werner 
Commit-Queue: Manoj Gupta

vboot: Remove the never called break

2019-11-05T13:43:49+00:00

Clean up the code.

BUG=none
BRANCH=none
TEST=N/A

Change-Id: If4ef76edf5f97fc51a21740e1ca51475b27b5f1a
Signed-off-by: Eric Lai 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1897416
Reviewed-by: Julius Werner

tests: Update futility show expected test output

2019-11-02T07:22:13+00:00

If you read the manpage for printf *really* closely, it seems that the
%#x token only prints the 0x prefix for non-zero values. Huh... never
knew that (and our firmware implementations in fact don't honor that,
but glibc does). Anyway, I think we're fine with either behavior but
this broke the expected output for one of our futility tests, which this
patch fixes (originally broken in CL:1840191).

BRANCH=None
BUG=None
TEST=make runtests

Change-Id: Id54ff6f56e02333ab01b09b75deb16f47da01bc3
Signed-off-by: Julius Werner 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1885411
Reviewed-by: Joel Kitching

cgptlib: Minor edge case fixes

2019-11-02T07:22:11+00:00

This patch fixes a sanitizer issue in cgpt where a GPT entries array may
have been passed even though it was not loaded from disk (parsing an
uninitialized buffer). The GPT library seems to have been written with
the assumption that both headers and entries would always be loaded and
it could recover even if only the primary header and the secondary
entries were valid. In practice, this doesn't really work because the
caller doesn't know how to read entries for an invalid header.
Therefore, change the code so that entries are only assumed to be loaded
for valid headers.

Also fix some minor problems with loading GPTs by aligning sizes up (not
down) to the next sector boundary and making sure we always allocate the
maximum amount of space for entry arrays, even if the current header may
not need that much (in case a repair wants to overwrite it).

This practically reverts CL:276766 which becomes obsolete (and was
really just a dirty hack to hide an underlying problem).

BRANCH=none
BUG=chromium:1017797
TEST=make runtests

Change-Id: I86c601dc074261d53f013b98ae214efdc44f3563
Signed-off-by: Julius Werner 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1885098
Reviewed-by: Mattias Nissler 
Reviewed-by: Randall Spangler

cr50_signing: add code to sign pre-pvt, pre-release and release

2019-11-02T07:06:31+00:00

This patch adds checks necessary before various types of images
signing could proceed.

The checks include verifying that Board ID flags and major version
number match the image type.

Also, manifest modification for node locked images is enhanced by
setting the least significant bit of the tag field to one. This will
ensure that the prod key ladder is not available to node locked images
even though they are signed with a prod key.

BRANCH=none
BUG=b:74100307
TEST=verified various cases by manually editing prod.json and
     signing_instructions.sh and observing results: either error
     messages or successful modification of the manifest and signing.

Change-Id: I0bc4a8acae1ca4e983999fd47e515c48786ded6c
Signed-off-by: Vadim Bendebury 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1894848

cr50_signing: add code to process node locked images

2019-10-30T00:56:00+00:00

Node locked images signed by the builder will have to come from the
factory branch and have version of 0.3.22.

Signing manifest will be processed to insert Device ID values, remove
Board ID values and set the top bit of config1.

BRANCH=none
BUG=b:74100307
TEST=ran the script manually with proper input and verified that
     manifest is processed as expected.

Change-Id: Ib8cbe0f1ae31e79c3228a662c02231caeb901adc
Signed-off-by: Vadim Bendebury 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1880572
Tested-by: George Engelbrecht 
Reviewed-by: Ned Nguyen 
Reviewed-by: George Engelbrecht 
Commit-Queue: George Engelbrecht

OWNERS: engeg@ is owner.

2019-10-29T21:59:34+00:00

BRANCH=None
BUG=None
TEST=None

Change-Id: I6e10fd839e256454ce3671228116d8c3a9ec6092
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1888274
Tested-by: LaMont Jones 
Tested-by: George Engelbrecht 
Auto-Submit: LaMont Jones 
Reviewed-by: George Engelbrecht 
Commit-Queue: George Engelbrecht