delta/coreboot/vboot.git, branch stabilize-11316.146.B

futility: updater: Correct HWID digest when preserving HWID

2019-01-22T16:53:37+00:00

Starting from GBB 1.2, a digest is stored in GBB and must be updated
whenever the HWID string is changed.

In shell script version of updater, the digest is automatically updated
when we do "futility gbb -s --hwid=XXX", but in native updater
implementation we only updated the HWID string and left digest
unchanged, this leaves devices generating wrong PCR1 values.

`cmd_gbb_utility` updates the digest by calling `update_hwid_digest`
using vboot1 structure, so we should introduce a new vboot2 friendly
function, `vb2_change_hwid`, which changes both HWID string and digest
at same time.

Note this has no impact for end user's devices with write protection
enabled. Only changes dogfood units AU results.

BUG=b:122248649
TEST=make futil; tests/futility/run_test_scripts.sh $(pwd)/build/futility
BRANCH=none

Change-Id: I6ad2754e6df3c9dd66d71c560a2afc26d14eae33
Signed-off-by: Hung-Te Lin 
Reviewed-on: https://chromium-review.googlesource.com/1411932
Reviewed-by: Joel Kitching 
(cherry picked from commit 859682accb19893803026a28b4c8ca2cd57945a4)
Reviewed-on: https://chromium-review.googlesource.com/c/1423940
Tested-by: James Chen 
Trybot-Ready: James Chen 
Reviewed-by: John  Chen 
Reviewed-by: Srinivasa duvvuri 
Commit-Queue: John  Chen

futility: updater: quirks: Support special released SNOW RO

2019-01-10T19:06:51+00:00

A special Snow RO firmware had been released and would break existing
platform check: 'Google_Snow_Rev4.2695.128.0'. As a result, we want to
bypass platform check in quirk 'daisy_snow_dual_model'.

BUG=chromium:917581
TEST=make futil; tests/futility/run_test_scripts.sh $(pwd)/build/futility
BRANCH=None

Change-Id: I10b0e4c2b8a11faff979b4add368f342a72a6cec
Signed-off-by: Hung-Te Lin 
Reviewed-on: https://chromium-review.googlesource.com/1390083
Commit-Ready: ChromeOS CL Exonerator Bot 
Reviewed-by: Joel Kitching 
(cherry picked from commit a32c930e8c46424a3bba3c296fd78b3e60f50aeb)
Reviewed-on: https://chromium-review.googlesource.com/c/1405389
Reviewed-by: Bernie Thompson 
Commit-Queue: Bernie Thompson 
Tested-by: Bernie Thompson

futility: updater: Skip applying white label for local build

2018-12-04T22:14:34+00:00

For developers running a local build on white label models, currently
the chromeos-firmwareupdate will always fail if VPD `whitelabel_tag` is
set because the `keyset/` folder does not exist (which was created by
signer bot).

Developers in this case usually don't really care about which key to use
and will be happy with the default (DEV signed) keys, also the key
compatibility will be still checked later, so we can skip the white
label patching if no keyset folder, which would allow developers getting
same experience on WL and non-WL devices.

BUG=b:120268135
TEST=TEST=make futil; tests/futility/run_test_scripts.sh $(pwd)/build/futility
BRANCH=None

Change-Id: I3992301ff4c406096e11e1ae8129f2f68b2319b5
Signed-off-by: Hung-Te Lin 
Reviewed-on: https://chromium-review.googlesource.com/1356688
Reviewed-by: C Shapiro 
(cherry picked from commit 73d3c0e3d2d170e9bd34dacdbbdaa5d52860dea2)
Reviewed-on: https://chromium-review.googlesource.com/c/1358531
Commit-Queue: YH Lin 
Tested-by: YH Lin

futility: updater: quirks: Fix firmware names for Veyron family

2018-12-03T02:34:01+00:00

The firmware name for Veyron devices are Google_Veyron_XXX and we have
to correct the names in quirks database.

BUG=chromium:910085
TEST=make futil; tests/futility/run_test_scripts.sh $(pwd)/build/futility
BRANCH=None

Change-Id: I3bf3bbb32fe90ebf370c1bc51c54d0280ddb7e98
Signed-off-by: Hung-Te Lin 
Reviewed-on: https://chromium-review.googlesource.com/1354147
Reviewed-by: Youcheng Syu 
(cherry picked from commit 979f8b906cfda7af57a4a526d352216eeafe1746)
Reviewed-on: https://chromium-review.googlesource.com/c/1356692

futility: updater: Revise error message when model is not defined in manifest

2018-11-27T15:57:51+00:00

"Model '%s' is not defined in manifest." is not very easy to understand
for people who are debugging devices in early stages. We should provide
better instructions. For example, running with Coral updater will now
show:

ERROR: manifest_find_model: Cannot get model name.
You are probably running an image for wrong board, or a device in early
stage that 'mosys' command is not ready, or image from old (or factory)
branches that Unified Build config is not updated yet for 'mosys'.
Please check command 'mosys platform model', which should output one of
the supported models below:
 unprovisioned_meep sparky orbatrix unprovisioned_fleex grabbiter bobba
 unprovisioned_bobba mimrock fleex meep yorp phaser360 sparky360 phaser
 bobba360 unprovisioned_phaser bip

BUG=chromium:875551
TEST=TEST=make futil; tests/futility/run_test_scripts.sh $(pwd)/build/futility
BRANCH=None

Change-Id: Ib17fcb654d1530b94c44cf21aaa28717841f11ed
Signed-off-by: Hung-Te Lin 
Reviewed-on: https://chromium-review.googlesource.com/1351171
Reviewed-by: Cheng-Han Yang 
Reviewed-by: Ting Shen

firmware: tpm2_lite: Implement TlclGetRandom()

2018-11-27T08:34:09+00:00

Implement support for getting random bytes from the TPM in the tpm2
library. The intent is to use this to seed the kaslr-seed DT property on
ARM devices.

BRANCH=None
BUG=None
TEST=Generate some random bytes in depthcharge using this API,
and 'stop trunksd; tpmc rand ' with sizes (0, 1, 0xf0, and
0xf1) on the device and see the last one fail

Change-Id: Ied0dc1ead70ac4daa2cee315516160ec100039be
Signed-off-by: Stephen Boyd 
Reviewed-on: https://chromium-review.googlesource.com/1327187
Commit-Ready: ChromeOS CL Exonerator Bot 
Reviewed-by: Andrey Pronin

test/ec_sync_test: Add mock test for VB_AUX_FW_NO_DEVICE severity

2018-11-27T08:33:58+00:00

Add a mock test to handle VB_AUX_FW_NO_DEVICE severity

BUG=chromium:896451
BRANCH=None
TEST=/mnt/host/source/chromite/bin/cros_run_unit_tests
      --board=octopus --packages=chromeos-base/vboot_reference

Change-Id: Ifdabdf3cee1130a8c853d57c278f0e557ebbb96f
Signed-off-by: Karthikeyan Ramasubramanian 
Reviewed-on: https://chromium-review.googlesource.com/1299994
Commit-Ready: ChromeOS CL Exonerator Bot 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Julius Werner 
Reviewed-by: Jett Rink

vboot_api: Add new VB_AUX_FW_NO_DEVICE update severity

2018-11-27T08:33:58+00:00

There is a possibility that a registered device is not present at
run-time and this scenario needs to be handled a little different. Add a
new update severity to handle this situation.

BUG=chromium:896451
BRANCH=None
TEST=bootup to ChromeOS by connecting and disconnecting the USB
daughterboard

Change-Id: I8a2044ce6a10fe611ee1f47262a7b54598a53ce3
Signed-off-by: Karthikeyan Ramasubramanian 
Reviewed-on: https://chromium-review.googlesource.com/1299993
Commit-Ready: ChromeOS CL Exonerator Bot 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Julius Werner 
Reviewed-by: Jett Rink

futility: updater: Revise output messages for debug logs

2018-11-25T03:21:29+00:00

In auto update and recovery, the firmware updater was executed with both
stdout and stderr logged. However, the logs usually comes with all stderr
first then all stdout. This makes it harder to debug because the
messages logged in out of order.

TO solve that, few macros are introduced:
 INFO: for useful information.
 STATUS: the most common information, usually comes with a prefix code.

And all messages should now go to stderr except the final execution
result (and those output commands, for example --manifest).

BUG=chromium:875551
TEST=TEST=make futil; tests/futility/run_test_scripts.sh $(pwd)/build/futility
CQ-DEPEND=CL:1345250
BRANCH=None

Change-Id: Ie0dc6594ece10e7e15caf9c36353e2b3ec8754c5
Signed-off-by: Hung-Te Lin 
Reviewed-on: https://chromium-review.googlesource.com/1345611
Reviewed-by: Youcheng Syu

futility: updater: Add new quirk 'allow_empty_wltag'

2018-11-25T03:21:28+00:00

There were devices shipped as "only device" (no key set) and then became
one of the "white label" family. This is now no longer valid on newer
devices but we have to support the legacy ones, for example Reks.

BUG=chromium:906962
TEST=make futil; tests/futility/run_test_scripts.sh $(pwd)/build/futility
BRANCH=None

Change-Id: I437be08726ab2c46229062689bf765ac6837ca5d
Signed-off-by: Hung-Te Lin 
Reviewed-on: https://chromium-review.googlesource.com/1345610
Reviewed-by: Youcheng Syu