delta/coreboot/vboot.git, branch release-R88-13597.B

minidiag/ui: Prevent calling update action if there were no updates

2020-11-12T12:40:05+00:00

Add a return code `VB2_ERROR_EX_DIAG_TEST_UPDATED` to determine if
updating needed.

BUG=b:168776970
BRANCH=none
TEST=Build locally, boot recovery, select 'run diagnostics',
     enter memory test (quick) screen,
     and observe that the delay reduces while pressing keyboard

Cq-Depend: chromium:2423699
Signed-off-by: Hsuan Ting Chen 
Change-Id: I7606911bee7257e8eed4ec35d197efaa57b72e13
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2424370
Reviewed-by: Yu-Ping Wu

minidiag/ui: Prevent calling update action if memory test is finished

2020-11-12T12:40:04+00:00

Skip calling diagnostics_memory_update_screen() action if memory test is
finished to reduce delays in memory diagnostics screens.

BUG=b:168776970, b:171852478
BRANCH=none
TEST=Build locally, boot recovery, select 'run diagnostics',
     enter memory test (quick) screen, wait until test is finished,
     and observe that the delay reduces while pressing keyboard

Signed-off-by: Hsuan Ting Chen 
Change-Id: I4f8dbadc68989112bce418119ff7405ec150a7df
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2423089

vboot/ui: Remove extra delay for long iteration time

2020-11-12T12:40:03+00:00

If an iteration takes longer than KEY_DELAY_MS, no extra delay.
Otherwise, delay until the iteration time reaches KEY_DELAY_MS.

BUG=b:168776970
BRANCH=none
TEST=Build locally

Signed-off-by: Hsuan Ting Chen 
Change-Id: Ia78dbe1cc87d08c02f99f4fc9269929c12c18b77
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2424373

vboot/ui/tests: Remove unnecessary aborting delay check

2020-11-12T12:40:01+00:00

- Do not check if delay is aborted every time since we already have
an individual test item.
- Do not save the last return value of vb2ex_mtime() to allow us to use
vb2ex_mtime() elsewhere.
- Use fuzzy match for `delay finished` test items.

BUG=b:156448738
BRANCH=none
TEST=CC=x86_64-pc-linux-gnu-clang;
     make clean && make runtests

Signed-off-by: Hsuan Ting Chen 
Change-Id: Ic211955637c67dc35ffd4c12194a8ccb77e1bf9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2508104
Reviewed-by: Joel Kitching 
Reviewed-by: Yu-Ping Wu

vboot/ui/tests: Add time-related constants in 2ui_private.h

2020-11-04T11:49:58+00:00

Add several constants in 2ui_private.h for testing:
- KEY_DELAY_MS
- DEV_DELAY_SHORT_MS
- DEV_DELAY_NORMAL_MS
- DEV_DELAY_BEEP1_MS
- DEV_DELAY_BEEP2_MS

BUG=b:156448738
BRANCH=none
TEST=CC=x86_64-pc-linux-gnu-clang;
     make clean && make runtests

Signed-off-by: Hsuan Ting Chen 
Change-Id: I7349d5214a90699fda67135329d7a6b93022bb27
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2513418
Reviewed-by: Yu-Ping Wu 
Reviewed-by: Joel Kitching

vboot/ui: Suffix "_ms" to time-related variables

2020-11-04T11:49:55+00:00

For test/vb2_ui_tests.c:
- Rename mock_get_timer_last to mock_get_timer_last_ms.
- Rename mock_time to mock_time_ms.
- Rename mock_time_start to mock_time_start_ms.

For 2lib/2ui.c and 2lib/2ui_screen.c:
- Rename start_time to start_time_ms in struct vb2_ui_context.
- Rename elapsed to elapsed_ms in developer_mode_action().

BUG=b:156448738
BRANCH=none
TEST=CC=x86_64-pc-linux-gnu-clang;
     make clean && make runtests

Signed-off-by: Hsuan Ting Chen 
Change-Id: Icabe04003f0dc95f41c9ed8b8e2292f1f64e86bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2513417

common: log loopback detaches

2020-11-03T07:15:12+00:00

We want to find the culprit loopback device which isn't detatching on
crbug.com/1141907. We might as well log our cleanup actions anyway, and
this will allow us to see the last loopback processed in production.

BUG=chromium:1141907
TEST=just a log message
BRANCH=None
Signed-off-by: George Engelbrecht 
Change-Id: I126efceae4f67993069675c23f6c4af61c7e5667
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2514561
Reviewed-by: LaMont Jones

common: save the existing return value on cleanup

2020-11-03T07:15:11+00:00

Currently this trap initiated function will not save the orginal return
value of the script. Save it and return it on exit.

BUG=chromium:1141907
TEST=unittest and manually on a signer
BRANCH=None
Signed-off-by: George Engelbrecht 
Change-Id: Icd807f4d153e4bcc1d309fbcea43c2b3344771ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2514560
Reviewed-by: Sean McAllister 
Reviewed-by: LaMont Jones

cleanup_minimal: remove duplicate trap for temps and mounts

2020-11-03T07:15:10+00:00

BUG=chromium:1141907
TEST=unit tests and manual signing run
Signed-off-by: George Engelbrecht 
BRANCH=none

Change-Id: I0316f464e138dea9e77b2554a3b31250e8b92c07
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2514559
Reviewed-by: Sean McAllister 
Reviewed-by: LaMont Jones 
Commit-Queue: George Engelbrecht 
Tested-by: George Engelbrecht

common.sh: adapt to get clean shellcheck

2020-11-03T07:15:08+00:00

BUG=chromium:1141907
TEST=unit tests and manual signing run
Signed-off-by: George Engelbrecht 
BRANCH=none

Change-Id: I39b133ca69e717576140b418fc59dd167f068d59
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/2514558
Reviewed-by: Sean McAllister 
Reviewed-by: LaMont Jones 
Commit-Queue: George Engelbrecht 
Tested-by: George Engelbrecht